On Wed, Apr 29, 2020 at 09:15:06AM +0900, Michael Paquier wrote:
> I am letting that aside for a couple of days to see if others have
> more comments, and will likely commit it after an extra lookup.
And applied after an extra lookup. Thanks for the discussion, James.
--
Michael
signature.asc
D
On Thu, Apr 30, 2020 at 03:06:08PM +0300, Victor Wagner wrote:
> Fix is very simple, see attach.
>
> Patch is made against REL_12_STABLE, but probably applicable to other
> versions as well.
Indeed, thanks.
> my $pythonprog = "import sys;print(sys.prefix);"
> . "pri
В Fri, 1 May 2020 17:52:15 +0900
Michael Paquier пишет:
> On Thu, Apr 30, 2020 at 03:06:08PM +0300, Victor Wagner wrote:
> > Fix is very simple, see attach.
> >
> > Patch is made against REL_12_STABLE, but probably applicable to
> > other versions as well.
>
> Indeed, thanks.
>
> >
Hi,
When I tried to reset a counter in pg_stat_slru using
pg_stat_reset_slru(name),
not only the specified counter but all the counters were reset.
postgres=# SELECT * FROM pg_stat_slru ;
name | blks_zeroed | blks_hit | blks_read | blks_written |
blks_exists | flushes | truncates
On 30/4/20 6:22, Thomas Munro wrote:
On Thu, Apr 30, 2020 at 12:26 PM Tomas Vondra
wrote:
Yeah, I think the question is what are the expected benefits of using
raw devices. It might be an interesting exercise / experiment, but my
understanding is that most of the benefits can be achieved by usi
Collegues,
Postgresql embeded perl, plperl contain code long time ago copied
from POSIX.xs file in the perl distribution.
It is function setlocale_perl, which does some allocation of
perl-specific locale data using functions(or macros) new_ctype,
new_collate and new_numeric.
This is used only for
On 4/30/20 9:52 PM, Bruce Momjian wrote:
On Thu, Apr 30, 2020 at 09:51:10PM -0400, Tom Lane wrote:
John Naylor writes:
As I understand it, the point of having "do {} while (0)" in a
multi-statement macro is to turn it into a simple statement.
Right.
As such,
ending with a semicolon in both
[proposal for PG 14]
There are a number of Remove${Something}ById() functions that are
essentially identical in structure and only different in which catalog
they are working on. This patch refactors this to be one generic
function. The information about which oid column, index, etc. to use
pá 1. 5. 2020 v 16:39 odesílatel Peter Eisentraut <
peter.eisentr...@2ndquadrant.com> napsal:
> [proposal for PG 14]
>
> There are a number of Remove${Something}ById() functions that are
> essentially identical in structure and only different in which catalog
> they are working on. This patch ref
On Fri, May 1, 2020 at 10:51 AM Pavel Stehule wrote:
> +1
+1 from me, too, but I have a few suggestions:
+DropGenericById(const ObjectAddress *object)
How about "Generic" -> "Object" or "Generic" -> "ObjectAddress"?
+ elog(ERROR, "cache lookup failed for %s entry %u",
+ elog(ERROR, "could not
On Fri, May 1, 2020 at 4:46 AM Michael Paquier wrote:
>
> On Wed, Apr 29, 2020 at 09:15:06AM +0900, Michael Paquier wrote:
> > I am letting that aside for a couple of days to see if others have
> > more comments, and will likely commit it after an extra lookup.
>
> And applied after an extra looku
On Wed, Apr 29, 2020 at 11:38 PM Masahiko Sawada
wrote:
> Thank you for the explanation. This makes sense to me.
Pushed both of the fixes.
Thanks!
--
Peter Geoghegan
On Thu, Apr 30, 2020 at 6:06 PM Robert Haas wrote:
> On Thu, Apr 30, 2020 at 3:52 PM Andres Freund wrote:
> > Why 8kb? That's smaller than what we currently do in pg_basebackup,
> > afaictl, and you're actually going to be bottlenecked by syscall
> > overhead at that point (unless you disable / d
On Fri, May 1, 2020 at 12:28 PM Jonah H. Harris wrote:
> Also, this will likely have an issue with O_DIRECT as additional buffer
> manager alignment is needed and I haven't tracked it down in 13 yet. As my
> default development is on a Mac, I have POSIX AIO only. As such, I can't
> natively pla
On Fri, May 1, 2020 at 4:59 PM Thomas Munro wrote:
> On Fri, May 1, 2020 at 12:28 PM Jonah H. Harris
> wrote:
> > Also, this will likely have an issue with O_DIRECT as additional buffer
> manager alignment is needed and I haven't tracked it down in 13 yet. As my
> default development is on a Mac
David Steele writes:
> On 4/30/20 9:52 PM, Bruce Momjian wrote:
>> On Thu, Apr 30, 2020 at 09:51:10PM -0400, Tom Lane wrote:
>>> Yeah. I'd call these actual bugs, and perhaps even back-patch worthy.
>> Agreed. Those semicolons could easily create bugs.
> +1. The patch looks good to me.
Greppi
Em sex., 1 de mai. de 2020 às 11:39, Peter Eisentraut <
peter.eisentr...@2ndquadrant.com> escreveu:
> [proposal for PG 14]
>
> There are a number of Remove${Something}ById() functions that are
> essentially identical in structure and only different in which catalog
> they are working on. This pat
Hi all
I am sharing here a document patch based on top of kms_v10 that was shared
awhile back. This document patch aims to cover more design details of the
current KMS design and to help people understand KMS better. Please let me know
if you have any more comments.
thank you
Best regar
On Thu, Apr 30, 2020 at 01:40:11PM +0900, Michael Paquier wrote:
On Thu, Apr 30, 2020 at 09:37:41AM +0800, Richard Guo wrote:
On Thu, Apr 30, 2020 at 8:11 AM Tomas Vondra
wrote:>
FWIW it'd be better to send the patch to the original thread instead of
starting a new one.
Ah yes, you're right.
On Fri, May 01, 2020 at 11:49:51AM +0900, Fujii Masao wrote:
On 2020/05/01 3:19, Tomas Vondra wrote:
On Fri, May 01, 2020 at 03:02:59AM +0900, Fujii Masao wrote:
On 2020/04/02 9:41, Tomas Vondra wrote:
Hi,
I've pushed this after some minor cleanup and improvements.
+static char *slru_na
On Fri, May 01, 2020 at 12:04:56PM +0900, Fujii Masao wrote:
> I applied cosmetic changes to the patch (attached). Barring any objection,
> I will push this patch (also back-patch to v10 where wait-event for timeline
> file was added).
Sorry for arriving late to the party. I have one tiny comment
On Thu, Apr 30, 2020 at 11:40:59PM +0900, Fujii Masao wrote:
> Also the number of bytes can be added into and substracted from LSN using the
> +(pg_lsn,numeric) and -(pg_lsn,numeric)
> operators, respectively. Note that the calculated LSN should be in the range
> of pg_lsn type, i.e., between 0/0 a
Hi all,
The first part of src/backend/replication/README lists all the APIs
usable for a WAL receiver, but these have aged and lost track of most
changes that happened over the years. Four functions are listed in
the README, with incorrect signatures and many others are missing:
- walrcv_connect(
On Thu, Apr 16, 2020 at 9:24 AM Alvaro Herrera wrote:
> On 2020-Apr-09, Alvaro Herrera wrote:
> > It seems worth pointing out that the new GetWalRcvWriteRecPtr function
> > has a different signature from the original one -- so any third-party
> > code using the original function will now get a com
On 2020/05/02 9:08, Tomas Vondra wrote:
On Fri, May 01, 2020 at 11:49:51AM +0900, Fujii Masao wrote:
On 2020/05/01 3:19, Tomas Vondra wrote:
On Fri, May 01, 2020 at 03:02:59AM +0900, Fujii Masao wrote:
On 2020/04/02 9:41, Tomas Vondra wrote:
Hi,
I've pushed this after some minor clean
25 matches
Mail list logo
