Re: General purpose hashing func in pgbench

Hello Ildar, Actually the "bad" one appears in YCSB. Fine. Then it must be kept, whatever its quality. But if we should choose the only one I would stick to murmur too given it provides better results while having similar computational complexity. No. Keep both as there is a justificatio

Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions

logical replication of 2 instances is OK but 3 and up fail with: TRAP: FailedAssertion("!(last_lsn < change->lsn)", File: "reorderbuffer.c", Line: 1773) I can cobble up a script but I hope you have enough from the assertion to see what's going wrong... The assertion says that the iterator p

Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions

On 12/24/2017 05:51 AM, Craig Ringer wrote: > On 23 December 2017 at 12:57, Tomas Vondra > wrote: > > Hi all, > > Attached is a patch series that implements two features to the logical > replication - ability to define a memory limit for the reo

Re: Reproducible builds: genbki.pl and Gen_fmgrtab.pl

On 12/21/17 08:13, Andrew Dunstan wrote: > Looks reasonable. Regarding the change to TestLib.pm, we should make > sure that the tests have unique names. There is a small amount of > duplication currently: > > ./src/bin/pg_dump/t/001_basic.pl > ./src/bin/pg_rewind/t/001_basic.pl > ./src

Re: Reproducible builds: genbki.pl and Gen_fmgrtab.pl

On 12/20/17 21:50, Tom Lane wrote: > -my $this_script = $0; > +my $this_script = 'src/backend/utils/mb/Unicode/UCS_to_BIG5.pl'; This kind of things looks awful. Why is this better? -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Tra

Re: Reproducible builds: genbki.pl and Gen_fmgrtab.pl

On Sun, Dec 24, 2017 at 12:26:53PM -0500, Peter Eisentraut wrote: > On 12/20/17 21:50, Tom Lane wrote: > > -my $this_script = $0; > > +my $this_script = 'src/backend/utils/mb/Unicode/UCS_to_BIG5.pl'; > > This kind of things looks awful. Why is this better? What's wrong with using the path? As y

Re: AS OF queries

On 21/12/17 15:00, Konstantin Knizhnik wrote: On 20.12.2017 19:26, Tom Lane wrote: Peter Eisentraut writes: On 12/20/17 10:29, Tom Lane wrote: Please say that's just an Oracle-ism and not SQL standard, because it's formally ambiguous. The SQL standard syntax appears to be something like

Re: Reproducible builds: genbki.pl and Gen_fmgrtab.pl

On Mon, Dec 25, 2017 at 2:25 AM, Peter Eisentraut wrote: > On 12/21/17 08:13, Andrew Dunstan wrote: >> Looks reasonable. Regarding the change to TestLib.pm, we should make >> sure that the tests have unique names. There is a small amount of >> duplication currently: >> >> ./src/bin/pg_dump/t/

Re: User defined data types in Logical Replication

On Sat, Dec 23, 2017 at 4:08 PM, Dang Minh Huong wrote: > On 2017/12/21 10:05, Masahiko Sawada wrote: > >> On Wed, Dec 20, 2017 at 5:39 PM, Huong Dangminh >> wrote: >>> >>> Hi Sawada-san, >>> Thank you for quick response. The changes look good to me. But I wonder if the following change

Re: AS OF queries

On 24 December 2017 at 04:53, konstantin knizhnik wrote: > > > But what if I just forbid to change recent_global_xmin? > If it is stalled at FirstNormalTransactionId and never changed? > Will it protect all versions from been deleted? > That's totally impractical, you'd have unbounded bloat and

RE: User defined data types in Logical Replication

> From: Masahiko Sawada [mailto:sawada.m...@gmail.com] > >> Attached a new version patch incorporated the aboves. Please review it. > > > > Thanks for updating the patch. > > It looks fine to me. I mean that it passes make check, and subscription TAP tests too. > > > > Thank you for confirmation

Re: Observations in Parallel Append

On Sun, Dec 24, 2017 at 12:06 PM, Robert Haas wrote: > On Fri, Dec 22, 2017 at 6:18 AM, Amit Kapila wrote: > >> Also, don't we need to use parallel_divisor for partial paths instead >> of non-partial paths as those will be actually distributed among >> workers? > > Uh, that seems backwards to me.

Re: [HACKERS] Proposal: Local indexes for partitioned table

Hi Alvaro, On 2017/12/23 0:10, Alvaro Herrera wrote: > I believe these are all fixed by the attached delta patch. @@ -1676,7 +1694,12 @@ psql_completion(const char *text, int start, int end) "UNION SELECT 'ALL IN TABLESPACE'"); /* ALTER INDEX */ else

Re: [HACKERS] taking stdbool.h into use

On Thu, Dec 21, 2017 at 1:02 AM, Peter Eisentraut wrote: > On 11/15/17 15:13, Peter Eisentraut wrote: >> I'm going to put this patch set as Returned With Feedback for now. The >> GinNullCategory issues look like they will need quite a bit of work. >> But it will be worth picking this up some time