pgsql: Define LDAPS_PORT if it's missing and disable implicit LDAPS on

2018-01-04 Thread Peter Eisentraut
Define LDAPS_PORT if it's missing and disable implicit LDAPS on Windows Some versions of Windows don't define LDAPS_PORT. Also, Windows' ldap_sslinit() is documented to use LDAPS even if you said secure=0 when the port number happens to be 636 or 3269. Let's avoid using the port number to imply

Re: pgsql: Allow ldaps when using ldap authentication

2018-01-04 Thread Peter Eisentraut
ause it means that the same connection string > could have a different meaning on Windows and Unix. So I also propose > that we also tweak the code to prevent that. pushed -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

pgsql: Refactor channel binding code to fetch cbind_data only when nece

2018-01-04 Thread Peter Eisentraut
Refactor channel binding code to fetch cbind_data only when necessary As things stand now, channel binding data is fetched from OpenSSL and saved into the SCRAM exchange context for any SSL connection attempted for a SCRAM authentication, resulting in data fetched but not used if no channel bindin

pgsql: Implement channel binding tls-server-end-point for SCRAM

2018-01-04 Thread Peter Eisentraut
Implement channel binding tls-server-end-point for SCRAM This adds a second standard channel binding type for SCRAM. It is mainly intended for third-party clients that cannot implement tls-unique, for example JDBC. Author: Michael Paquier Branch -- master Details --- https://git.postg

pgsql: Fix build with older OpenSSL versions

2018-01-04 Thread Peter Eisentraut
Fix build with older OpenSSL versions Apparently, X509_get_signature_nid() is only in fairly new OpenSSL versions, so use the lower-level interface it is built on instead. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/ac3ff8b1d8f98da38c53a701e6397931080a39cf Modi

pgsql: Add missing includes

2018-01-04 Thread Peter Eisentraut
Add missing includes is necessary to look into the X509 struct, used by ac3ff8b1d8f98da38c53a701e6397931080a39cf. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/1834c1e432d22f9e186950c7dd8598958776e016 Modified Files -- src/backend/libpq/be-secure-ope

pgsql: Another attempt at fixing build with various OpenSSL versions

2018-01-04 Thread Peter Eisentraut
Another attempt at fixing build with various OpenSSL versions It seems we can't easily work around the lack of X509_get_signature_nid(), so revert the previous attempts and just disable the tls-server-end-point feature if we don't have it. Branch -- master Details --- https://git.postgre

pgsql: Fix ssl tests for when tls-server-end-point is not supported

2018-01-09 Thread Peter Eisentraut
Fix ssl tests for when tls-server-end-point is not supported Add a function to TestLib that allows us to check pg_config.h and then decide the expected test outcome based on that. Author: Michael Paquier Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/c3d41ccf5931

pgsql: Remove PortalGetQueryDesc()

2018-01-09 Thread Peter Eisentraut
Remove PortalGetQueryDesc() After having gotten rid of PortalGetHeapMemory(), there seems little reason to keep one Portal access macro around that offers no actual abstraction and isn't consistently used anyway. Reviewed-by: Andrew Dunstan Reviewed-by: Alvaro Herrera Branch -- master Det

pgsql: Update portal-related memory context names and API

2018-01-09 Thread Peter Eisentraut
Update portal-related memory context names and API Rename PortalMemory to TopPortalContext, to avoid confusion with PortalContext and align naming with similar top-level memory contexts. Rename PortalData's "heap" field to portalContext. The "heap" naming seems quite antiquated and confusing. A

pgsql: Give more accurate error message for dropping pinned portal

2018-01-10 Thread Peter Eisentraut
Give more accurate error message for dropping pinned portal The previous code gave the same error message for attempting to drop pinned and active portals, but those are separate states, so give separate error messages. Branch -- master Details --- https://git.postgresql.org/pg/commitdif

pgsql: Move portal pinning from PL/pgSQL to SPI

2018-01-10 Thread Peter Eisentraut
Move portal pinning from PL/pgSQL to SPI PL/pgSQL "pins" internally generated (unnamed) portals so that user code cannot close them by guessing their names. This logic is also useful in other languages and really for any code. So move that logic into SPI. An unnamed portal obtained through SPI_c

pgsql: Revert "Move portal pinning from PL/pgSQL to SPI"

2018-01-10 Thread Peter Eisentraut
Revert "Move portal pinning from PL/pgSQL to SPI" This reverts commit b3617cdfbba1b5381e9d1c6bc0839500e8eb7273. This broke returning unnamed cursors from PL/pgSQL functions. Apparently, there are no test cases for this. Branch -- master Details --- https://git.postgresql.org/pg/commitdi

pgsql: Add tests for PL/pgSQL returning unnamed portals as refcursor

2018-01-10 Thread Peter Eisentraut
Add tests for PL/pgSQL returning unnamed portals as refcursor Existing tests only covered returning explicitly named portals as refcursor. The unnamed cursor case was recently broken without a test failing. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/5115854170

pgsql: Use portal pinning in PL/Perl and PL/Python

2018-01-10 Thread Peter Eisentraut
Use portal pinning in PL/Perl and PL/Python PL/pgSQL "pins" internally generated portals so that user code cannot close them by guessing their names. Add this functionality to PL/Perl and PL/Python as well, preventing users from manually closing cursors created by spi_query and plpy.cursor, respe

pgsql: Fix Latin spelling

2018-01-11 Thread Peter Eisentraut
Fix Latin spelling "c.f." should be "cf.". Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/9e945f862633882cae3183d465f321bd8dd591f9 Modified Files -- src/backend/catalog/catalog.c | 2 +- src/backend/optimizer/util/clauses.c

pgsql: Refactor subscription tests to use PostgresNode's wait_for_catch

2018-01-11 Thread Peter Eisentraut
Refactor subscription tests to use PostgresNode's wait_for_catchup This was nearly the same code. Extend wait_for_catchup to allow waiting for pg_current_wal_lsn() and use that in the subscription tests. Also change one use in the pg_rewind tests to use this. Also remove some broken code in wai

pgsql: Remove useless use of bit-masking macros

2018-01-16 Thread Peter Eisentraut
Remove useless use of bit-masking macros In this case, the macros SET_8_BYTES(), GET_8_BYTES(), SET_4_BYTES(), GET_4_BYTES() are no-ops, so we can just remove them. The plan is to perhaps remove them from the source code altogether, so we'll start here. Discussion: https://www.postgresql.org/me

pgsql: doc: Expand documentation of session_replication_role

2018-01-18 Thread Peter Eisentraut
doc: Expand documentation of session_replication_role Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/a063d842f8f48e197f5a9bfb892210ce219c5556 Modified Files -- doc/src/sgml/config.sgml | 26 -- doc/src/sgml/ref/alter_tabl

pgsql: Add tests for session_replication_role

2018-01-18 Thread Peter Eisentraut
Add tests for session_replication_role This was hardly tested at all. The trigger case was lightly tested by the logical replication tests, but rules and event triggers were not tested at all. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/77216cae47e3ded13f36361f

pgsql: Fix typo and improve punctuation

2018-01-18 Thread Peter Eisentraut
Fix typo and improve punctuation Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/958c7ae0b7ca4ee9d422271c2ffbef4e3a6d1c47 Modified Files -- src/test/ssl/t/001_ssltests.pl | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-)

pgsql: Update comment

2018-01-18 Thread Peter Eisentraut
Update comment The "callback" that this comment was referring to was removed by commit c0a15e07cd718cb6e455e68328f522ac076a0e4b, so update to match the current code. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/a228e44ce4a2bfd1de3764763039cfcb009d7864 Modified F

pgsql: Replace GrantObjectType with ObjectType

2018-01-19 Thread Peter Eisentraut
Replace GrantObjectType with ObjectType There used to be a lot of different *Type and *Kind symbol groups to address objects within different commands, most of which have been replaced by ObjectType, starting with b256f2426433c56b4bea3a8102757749885b81ba. But this conversion was never done for th

pgsql: Replace AclObjectKind with ObjectType

2018-01-19 Thread Peter Eisentraut
Replace AclObjectKind with ObjectType AclObjectKind was basically just another enumeration for object types, and we already have a preferred one for that. It's only used in aclcheck_error. By using ObjectType instead, we can also give some more precise error messages, for example "index" instead

pgsql: PL/Python: Simplify PLyLong_FromInt64

2018-01-19 Thread Peter Eisentraut
PL/Python: Simplify PLyLong_FromInt64 We don't actually need two code paths, one for 32 bits and one for 64 bits. Since the existing code already assumed that "long long" is available, we can just use PyLong_FromLongLong() for 64 bits as well. In Python 2.5 and later, PyLong_FromLong() and PyLong

pgsql: Improve type conversion of SPI_processed in Python

2018-01-20 Thread Peter Eisentraut
Improve type conversion of SPI_processed in Python The previous code converted SPI_processed to a Python float if it didn't fit into a Python int. But Python longs have unlimited precision, so use that instead in all cases. As in eee50a8d4c389171ad5180568a7221f7e9b28f09, we use the Python LongLo

pgsql: Transaction control in PL procedures

2018-01-22 Thread Peter Eisentraut
Transaction control in PL procedures In each of the supplied procedural languages (PL/pgSQL, PL/Perl, PL/Python, PL/Tcl), add language-specific commit and rollback functions/commands to control transactions in procedures in that language. Add similar underlying functions to SPI. Some additional

pgsql: PL/Python: Fix tests for older Python versions

2018-01-22 Thread Peter Eisentraut
PL/Python: Fix tests for older Python versions Commit 8561e4840c81f7e345be2df170839846814fa004 neglected to handle older Python versions that don't support the "with" statement. So write the tests in a way that older versions can handle as well. Branch -- master Details --- https://git.

pgsql: Extract common bits from OpenSSL implementation

2018-01-23 Thread Peter Eisentraut
Extract common bits from OpenSSL implementation Some things in be-secure-openssl.c and fe-secure-openssl.c were not actually specific to OpenSSL but could also be used by other implementations. In order to avoid copy-and-pasting, move some of that code to common files. Branch -- master Deta

pgsql: Add installcheck support to more test suites

2018-01-23 Thread Peter Eisentraut
Add installcheck support to more test suites Several of the test suites under src/test/ were missing an installcheck target. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/f5da5683a86e9fc42fdf3eae2da8b096bda76a8a Modified Files -- src/test/authenticati

pgsql: Move SSL API comments to header files

2018-01-23 Thread Peter Eisentraut
Move SSL API comments to header files Move the documentation of the SSL API calls are supposed to do into the headers files, instead of keeping them in the files for the OpenSSL implementation. That way, they don't have to be duplicated or be inconsistent when other implementations are added. Br

pgsql: Split out documentation of SSL parameters into their own section

2018-01-23 Thread Peter Eisentraut
Split out documentation of SSL parameters into their own section Split the "Authentication and Security" section into two separate sections "Authentication" and "SSL". The latter part has gotten much longer over time, and doesn't primarily have to do with authentication. Also, the row_security p

pgsql: Move EDH support to common files

2018-01-23 Thread Peter Eisentraut
Move EDH support to common files The EDH support is not really specific to the OpenSSL implementation, so move the support and documentation comments to common files. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/573bd08b99e277026e87bb55ae69c489fab321b8 Modified

pgsql: pgbench: Remove accidental garbage in test file

2018-01-23 Thread Peter Eisentraut
pgbench: Remove accidental garbage in test file Author: Fabien COELHO Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/f9bbd46adbf350ba9e99a808f2c759e4aab9ea70 Modified Files -- src/bin/pgbench/t/001_pgbench_with_server.pl | 6 -- 1 file changed, 6 d

pgsql: Add tests for record_image_eq and record_image_cmp

2018-01-24 Thread Peter Eisentraut
Add tests for record_image_eq and record_image_cmp record_image_eq was covered a bit by the materialized view code that it is meant to support, but record_image_cmp was not tested at all. While we're here, add more tests to record_eq and record_cmp as well, for symmetry. Reviewed-by: Michael Paq

pgsql: Allow spaces in connection strings in SSL tests

2018-01-25 Thread Peter Eisentraut
Allow spaces in connection strings in SSL tests Connection strings can have items with spaces in them, wrapped in quotes. The tests however ran a SELECT '$connstr' upon connection which broke on the embedded quotes. Use dollar quotes on the connstr to protect against this. This was hit during t

pgsql: Remove use of byte-masking macros in record_image_cmp

2018-01-25 Thread Peter Eisentraut
Remove use of byte-masking macros in record_image_cmp These were introduced in 4cbb646334b3b998a29abef0d57608d42097e6c9, but after further analysis and testing, they should not be necessary and probably weren't the part of that commit that fixed anything. Reviewed-by: Michael Paquier Branch ---

pgsql: Update documentation to mention huge pages on other OSes

2018-01-25 Thread Peter Eisentraut
nd mention that some OSes may use huge pages automatically. Author: Thomas Munro and Catalin Iacob Reviewed-By: Justin Pryzby, Peter Eisentraut Discussion: https://postgr.es/m/CAEepm=3qzr-hfjepymohuc4xo5phxosoipojm6behnjhjnr...@mail.gmail.com Branch -- master Details --- https://git.post

pgsql: Remove byte-masking macros for Datum conversion macros

2018-01-26 Thread Peter Eisentraut
Remove byte-masking macros for Datum conversion macros As the comment there stated, these were needed for old-style user-defined functions, but since we removed support for those, we don't need this anymore. Reviewed-by: Michael Paquier Branch -- master Details --- https://git.postgres

pgsql: Use abstracted SSL API in server connection log messages

2018-01-26 Thread Peter Eisentraut
Use abstracted SSL API in server connection log messages The existing "connection authorized" server log messages used OpenSSL API calls directly, even though similar abstracted API calls exist. Change to use the latter instead. Change the function prototype for the functions that return the TLS

pgsql: psql documentation fixes

2018-01-29 Thread Peter Eisentraut
psql documentation fixes Update the documentation for \pset to mention columns|linestyle. Author: Дилян Палаузов Branch -- REL9_3_STABLE Details --- https://git.postgresql.org/pg/commitdiff/98e4dce78b5139a1a7935903627498c41f0b2d6a Modified Files -- doc/src/sgml/ref/psql-re

pgsql: psql documentation fixes

2018-01-29 Thread Peter Eisentraut
psql documentation fixes Update the documentation for \pset to mention columns|linestyle. Author: Дилян Палаузов Branch -- REL9_4_STABLE Details --- https://git.postgresql.org/pg/commitdiff/b37422de89e569a474509cd26ec49e27866d01e8 Modified Files -- doc/src/sgml/ref/psql-re

pgsql: psql documentation fixes

2018-01-29 Thread Peter Eisentraut
psql documentation fixes Update the documentation for \pset to mention columns|linestyle|pager_min_lines. Author: Дилян Палаузов Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/697ee73596b9ebef684c1196e15cc2afd08a3631 Modified Files -- doc/src/

pgsql: psql documentation fixes

2018-01-29 Thread Peter Eisentraut
psql documentation fixes Update the documentation for \pset to mention columns|linestyle|pager_min_lines. Author: Дилян Палаузов Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/8067cf816cd49d47f258a1115a1443a4e70b3864 Modified Files -- doc/src/

pgsql: doc: Clarify pg_upgrade documentation

2018-01-29 Thread Peter Eisentraut
doc: Clarify pg_upgrade documentation Clarify that the restriction against reg* types only applies to table columns using these types, not to the type appearing in any other way, for example as a function argument. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/1e1

pgsql: Silence complaint about dead assignment

2018-01-29 Thread Peter Eisentraut
Silence complaint about dead assignment The preferred place for "placate compiler" assignments is after elog(ERROR), not before it. Otherwise, scan-build complains about a dead assignment. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/07e524d3e955a79b94918d076642

pgsql: Add some noreturn attributes to help static analyzers

2018-01-29 Thread Peter Eisentraut
Add some noreturn attributes to help static analyzers Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/a044378ce2f6268a996c8cce2b7bfb5d82b05c90 Modified Files -- src/backend/utils/adt/json.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

pgsql: Remove dead assignment

2018-01-29 Thread Peter Eisentraut
Remove dead assignment per scan-build Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/6ad3611e1ea6fef6ac0c746d1565b3f6a856b593 Modified Files -- contrib/spi/refint.c | 1 - 1 file changed, 1 deletion(-)

pgsql: Fix up references to scram-sha-256

2018-01-30 Thread Peter Eisentraut
Fix up references to scram-sha-256 pg_hba_file_rules erroneously reported this as scram-sha256. Fix that. To avoid future errors and confusion, also adjust documentation links and internal symbols to have a separator between "sha" and "256". Reported-by: Christophe Courtois Author: Michael Paq

pgsql: Fix up references to scram-sha-256

2018-01-30 Thread Peter Eisentraut
Fix up references to scram-sha-256 pg_hba_file_rules erroneously reported this as scram-sha256. Fix that. To avoid future errors and confusion, also adjust documentation links and internal symbols to have a separator between "sha" and "256". Reported-by: Christophe Courtois Author: Michael Paq

pgsql: Exclude common/int128.h from cpluspluscheck

2018-01-30 Thread Peter Eisentraut
Exclude common/int128.h from cpluspluscheck It uses static assertions, which are not supported under C++ in this branch. This change only goes into the 9.4 branch, because 9.5 and beyond will primarily use the USE_NATIVE_INT128 branch, so cpluspluscheck isn't bothered. In PG11 we will have C++ s

pgsql: Refactor client-side SSL certificate checking code

2018-01-30 Thread Peter Eisentraut
Refactor client-side SSL certificate checking code Separate the parts specific to the SSL library from the general logic. The previous code structure was open_client_SSL() calls verify_peer_name_matches_certificate() calls verify_peer_name_matches_certificate_name() calls wildcard_certificate_ma

pgsql: Fix application of identity values in some cases

2018-02-02 Thread Peter Eisentraut
Fix application of identity values in some cases Investigation of 2d2d06b7e27e3177d5bef0061801c75946871db3 revealed that identity values were not applied in some further cases, including logical replication subscribers, VALUES RTEs, and ALTER TABLE ... ADD COLUMN. To fix all that, apply the ident

pgsql: Fix application of identity values in some cases

2018-02-02 Thread Peter Eisentraut
Fix application of identity values in some cases Investigation of 2d2d06b7e27e3177d5bef0061801c75946871db3 revealed that identity values were not applied in some further cases, including logical replication subscribers, VALUES RTEs, and ALTER TABLE ... ADD COLUMN. To fix all that, apply the ident

pgsql: doc: Fix index link

2018-02-02 Thread Peter Eisentraut
doc: Fix index link The index entry was pointing to a slightly wrong location. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/bc38bdba04d75f7c39d57f3eba9c01958d8d2f7c Modified Files -- doc/src/sgml/logicaldecoding.sgml | 2 +- 1 file changed, 1 insertio

pgsql: doc: Fix index link

2018-02-02 Thread Peter Eisentraut
doc: Fix index link The index entry was pointing to a slightly wrong location. Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/dcc1e61cb23606bf3e90079a0529821939c0e9c6 Modified Files -- doc/src/sgml/logicaldecoding.sgml | 2 +- 1 file changed, 1 i

pgsql: doc: Clarify psql --list documentation a bit more

2018-02-03 Thread Peter Eisentraut
doc: Clarify psql --list documentation a bit more Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/1d81c093db81f63727436c736d9d27b7bedb4b66 Modified Files -- doc/src/sgml/ref/psql-ref.sgml | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-)

pgsql: doc: Clarify psql --list documentation a bit more

2018-02-03 Thread Peter Eisentraut
doc: Clarify psql --list documentation a bit more Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/6dbae688d8526e4f277c4a7bf85497e03a947e59 Modified Files -- doc/src/sgml/ref/psql-ref.sgml | 12 +--- 1 file changed, 9 insertions(+), 3 deleti

pgsql: doc: Fix name in release notes

2018-02-03 Thread Peter Eisentraut
doc: Fix name in release notes Author: Alexander Lakhin Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/4ac583f36a0c5452047531f56703b8ea51e718ad Modified Files -- doc/src/sgml/release-10.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: doc: Fix name in release notes

2018-02-03 Thread Peter Eisentraut
doc: Fix name in release notes Author: Alexander Lakhin Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/a643f5c2adc7698d0cfa1f3648074b1a27c6168d Modified Files -- doc/src/sgml/release-10.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: doc: Update mentions of MD5 in the documentation

2018-02-04 Thread Peter Eisentraut
doc: Update mentions of MD5 in the documentation Reported-by: Shay Rojansky Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/20446a4a04240ce9880331eea3082c906ede4f26 Modified Files -- doc/src/sgml/runtime.sgml | 34 +--

pgsql: doc: Update mentions of MD5 in the documentation

2018-02-04 Thread Peter Eisentraut
doc: Update mentions of MD5 in the documentation Reported-by: Shay Rojansky Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/ad14919ac901e9703d81a5bf8a6b608719c85b60 Modified Files -- doc/src/sgml/runtime.sgml | 34 +- 1 f

pgsql: Translation updates

2018-02-05 Thread Peter Eisentraut
Translation updates Source-Git-URL: git://git.postgresql.org/git/pgtranslation/messages.git Source-Git-Hash: 729c338a50b452e86cd740cb9878554be4264f32 Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/c452abbd060e290d4f47d2a25285cc1bd032b2c4 Modified Files

pgsql: Translation updates

2018-02-05 Thread Peter Eisentraut
Translation updates Source-Git-URL: git://git.postgresql.org/git/pgtranslation/messages.git Source-Git-Hash: 8d2416b5dc311bbf942125650a2d2c162a4f5453 Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/dc6fb453a33659c5b8e916c67121eba5d78c52b4 Modified Files

pgsql: Translation updates

2018-02-05 Thread Peter Eisentraut
Translation updates Source-Git-URL: git://git.postgresql.org/git/pgtranslation/messages.git Source-Git-Hash: 1bde68354ce9389733ebee17e76817f3bda1edf1 Branch -- REL9_4_STABLE Details --- https://git.postgresql.org/pg/commitdiff/0a5dcba2abc68996a22387f1186889447a4126ce Modified Files

pgsql: Translation updates

2018-02-05 Thread Peter Eisentraut
Translation updates Source-Git-URL: git://git.postgresql.org/git/pgtranslation/messages.git Source-Git-Hash: 5d1489f84240611b69adf3f4cc0b0501e41e Branch -- REL9_3_STABLE Details --- https://git.postgresql.org/pg/commitdiff/790808b37736798c4da776bd91d8440d0e856e11 Modified Files

pgsql: Translation updates

2018-02-05 Thread Peter Eisentraut
Translation updates Source-Git-URL: git://git.postgresql.org/git/pgtranslation/messages.git Source-Git-Hash: 8c0c2fe449f6c310f83664b946ba85309a69bdf6 Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/5bdbc5b7550091be3ccf56eed8e6b4e0197fa7f1 Modified Files

pgsql: Add more information_schema columns

2018-02-07 Thread Peter Eisentraut
Add more information_schema columns - table_constraints.enforced - triggers.action_order - triggers.action_reference_old_table - triggers.action_reference_new_table Reviewed-by: Michael Paquier Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/32ff2691173559e5f0ca3e

pgsql: Make new triggers tests more robust

2018-02-07 Thread Peter Eisentraut
Make new triggers tests more robust Add explicit collation on the trigger name to avoid locale dependencies. Also restrict the tables selected, to avoid interference from concurrently running tests. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/7c44b75a2a0705bf17d

pgsql: Refine SSL tests test name reporting

2018-02-08 Thread Peter Eisentraut
Refine SSL tests test name reporting Instead of using the psql/libpq connection string as the displayed test name and relying on "notes" and source code comments to explain the tests, give the tests self-explanatory names, like we do elsewhere. Reviewed-by: Michael Paquier Reviewed-by: Daniel Gu

pgsql: Fix typo

2018-02-12 Thread Peter Eisentraut
Fix typo Author: Masahiko Sawada Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/ebdb42a0d6a61b93a5bb9f4204408edf5959332c Modified Files -- src/backend/replication/logical/origin.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: In LDAP test, restart after pg_hba.conf changes

2018-02-13 Thread Peter Eisentraut
In LDAP test, restart after pg_hba.conf changes Instead of issuing a reload after pg_hba.conf changes between test cases, run a full restart. With a reload, an error in the new pg_hba.conf is ignored and the tests will continue to run with the old settings, invalidating the subsequent test cases.

pgsql: Add procedure support to pg_get_functiondef

2018-02-13 Thread Peter Eisentraut
Add procedure support to pg_get_functiondef This also makes procedures work in psql's \ef and \sf commands. Reported-by: Pavel Stehule Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/7a32ac8a66903de8c352735f2a26f610f5e47090 Modified Files -- doc/src/s

pgsql: doc: pg_function_is_visible also applies to aggregates and proce

2018-02-13 Thread Peter Eisentraut
doc: pg_function_is_visible also applies to aggregates and procedures Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/2ac3e6acc228e4b99022019379c6d5c4b61b231c Modified Files -- doc/src/sgml/func.sgml | 2 ++ 1 file changed, 2 insertions(+)

pgsql: Add tests for pg_get_functiondef

2018-02-13 Thread Peter Eisentraut
Add tests for pg_get_functiondef Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/7cd56f218d0f8953999b944bc558cd6684b15cdc Modified Files -- src/test/regress/expected/create_function_3.out | 44 + src/test/regress/sql/create_functio

pgsql: Fix typo

2018-02-13 Thread Peter Eisentraut
Fix typo Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/a7b8f0661d9ca9656ba58546ed871b36dbf8504d Modified Files -- src/test/regress/expected/create_function_3.out | 144 src/test/regress/sql/create_function_3.sql | 88 +

pgsql: Rename enable_partition_wise_join to enable_partitionwise_join

2018-02-16 Thread Peter Eisentraut
Rename enable_partition_wise_join to enable_partitionwise_join Discussion: https://www.postgresql.org/message-id/flat/ad24e4f4-6481-066e-e3fb-6ef4a3121882%402ndquadrant.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/2fb1abaeb016aeb45b9e6d0b81b7a7e92bb251b9 Mo

pgsql: Fix crash when canceling parallel query

2018-02-16 Thread Peter Eisentraut
Fix crash when canceling parallel query elog(FATAL) would end up calling PortalCleanup(), which would call executor shutdown code, which could fail and crash, especially under parallel query. This was introduced by 8561e4840c81f7e345be2df170839846814fa004, which did not want to mark an active por

pgsql: Move function comment to the right place

2018-02-17 Thread Peter Eisentraut
Move function comment to the right place Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/1a1adb215c69bbf64fd8e01cc1706812dc8ba15b Modified Files -- src/backend/commands/tablecmds.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-)

pgsql: Minor comment fix

2018-02-17 Thread Peter Eisentraut
Minor comment fix Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/7923118c16aa3408a994f297d8bdd68292f45324 Modified Files -- src/backend/access/transam/xact.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Message style fix

2018-02-18 Thread Peter Eisentraut
Message style fix Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/97a804cb2bba49d5ff04795cf500722977e5af9a Modified Files -- src/backend/commands/dbcommands.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

pgsql: Fix StaticAssertExpr() under C++

2018-02-18 Thread Peter Eisentraut
Fix StaticAssertExpr() under C++ The previous code didn't compile, because static_assert() must end with a semicolon. To fix, wrap it in a block, similar to the C code. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/ebf6049ebea19e4123fefce7b542189e84084cd1 Modifi

pgsql: Remove redundant function declaration

2018-02-18 Thread Peter Eisentraut
Remove redundant function declaration Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/2e1d1ebdffa2c69779573c2e561056cd08541e74 Modified Files -- src/backend/catalog/partition.c | 3 --- 1 file changed, 3 deletions(-)

pgsql: Error message improvement

2018-02-20 Thread Peter Eisentraut
Error message improvement Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/c2ff42c6c1631c6c67d09fc8574186a984566a0d Modified Files -- src/backend/commands/tablecmds.c | 2 +- src/test/regress/expected/truncate.out | 4 ++-- 2 files changed, 3 insertio

pgsql: Add user-callable SHA-2 functions

2018-02-22 Thread Peter Eisentraut
Add user-callable SHA-2 functions Add the user-callable functions sha224, sha256, sha384, sha512. We already had these in the C code to support SCRAM, but there was no test coverage outside of the SCRAM tests. Adding these as user-callable functions allows writing some tests. Also, we have a us

pgsql: Update gratuitous use of MD5 in documentation

2018-02-22 Thread Peter Eisentraut
Update gratuitous use of MD5 in documentation It seems some people are bothered by the outdated MD5 appearing in example code. So replace it with more modern alternatives or by a different example function. Reported-by: Jon Wolski Branch -- master Details --- https://git.postgresql.or

pgsql: Fix perlcritic warnings

2018-02-22 Thread Peter Eisentraut
Fix perlcritic warnings Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/abcba7001e481a565b8fba2393666dc54e90db61 Modified Files -- src/bin/pgbench/t/001_pgbench_with_server.pl | 8 1 file changed, 4 insertions(+), 4 deletions(-)

pgsql: Support parameters in CALL

2018-02-22 Thread Peter Eisentraut
Support parameters in CALL To support parameters in CALL, move the parse analysis of the procedure and arguments into the global transformation phase, so that the parser hooks can be applied. And then at execution time pass the parameters from ProcessUtility on to ExecuteCallStmt. Branch --

pgsql: Fix filtering of unsupported relations in logical replication

2018-02-23 Thread Peter Eisentraut
Fix filtering of unsupported relations in logical replication In the pgoutput plugin, skip changes for relations that are not publishable, per is_publishable_class(). This concerns in particular materialized views and information_schema tables. While those relations cannot be part of a publicati

pgsql: Fix filtering of unsupported relations in logical replication

2018-02-23 Thread Peter Eisentraut
Fix filtering of unsupported relations in logical replication In the pgoutput plugin, skip changes for relations that are not publishable, per is_publishable_class(). This concerns in particular materialized views and information_schema tables. While those relations cannot be part of a publicati

pgsql: Check error messages in SSL tests

2018-02-24 Thread Peter Eisentraut
Check error messages in SSL tests In tests that check whether a connection fails, also check the error message. That makes sure that the connection was rejected for the right reason. This discovered that two tests had their connection failing for the wrong reason. One test failed because pg_hba

pgsql: Use croak instead of die in Perl code when appropriate

2018-02-24 Thread Peter Eisentraut
Use croak instead of die in Perl code when appropriate Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/fde03e8b559d0e00bf4acd8cea3bb49411099c34 Modified Files -- src/backend/utils/mb/Unicode/convutils.pm | 5 +++-- src/bin/pg_rewind/RewindTest.pm

pgsql: Update headers of generated files

2018-02-24 Thread Peter Eisentraut
Update headers of generated files The scripts were changed in c98c35cd084a25c6cf9b08c76de8b89facd75fe7, but the output files were not updated to reflect the script changes. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/c4ba1bee68abe217e441fb81343e5f9e9e2a5353 Mod

pgsql: Add current directory to Perl include path

2018-02-24 Thread Peter Eisentraut
Add current directory to Perl include path Recent Perl versions don't have the current directory in the module include path anymore, so we need to add it here explicitly to make these scripts continue to work. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/9ee0573e

pgsql: Translation updates

2018-02-26 Thread Peter Eisentraut
Translation updates Source-Git-URL: git://git.postgresql.org/git/pgtranslation/messages.git Source-Git-Hash: b97fb93ecf9b04faed73a68db33226f33ae3065e Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/bcce4c3bc75d31867be894ed5c0da23b2ff7fbb2 Modified Files

pgsql: Translation updates

2018-02-26 Thread Peter Eisentraut
Translation updates Source-Git-URL: git://git.postgresql.org/git/pgtranslation/messages.git Source-Git-Hash: 32d52a32046b02d63f91aa7968636423c79982dc Branch -- REL9_3_STABLE Details --- https://git.postgresql.org/pg/commitdiff/90b50c6e9b74d819ef153e959dc38d2278120d0c Modified Files

pgsql: Translation updates

2018-02-26 Thread Peter Eisentraut
Translation updates Source-Git-URL: git://git.postgresql.org/git/pgtranslation/messages.git Source-Git-Hash: e859c0a3a8ac0fc7ae28150aff33153ec532ef04 Branch -- REL9_4_STABLE Details --- https://git.postgresql.org/pg/commitdiff/fd090d0d6f719c83b5e28f58c3e72f52296951e6 Modified Files

pgsql: Translation updates

2018-02-26 Thread Peter Eisentraut
Translation updates Source-Git-URL: git://git.postgresql.org/git/pgtranslation/messages.git Source-Git-Hash: 4b11a4320dc2d543629ae1b61cc39112cc8f3947 Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/7dd49bdb7418ea6ebd72470f274b9e45847c5cb5 Modified Files

pgsql: Translation updates

2018-02-26 Thread Peter Eisentraut
Translation updates Source-Git-URL: git://git.postgresql.org/git/pgtranslation/messages.git Source-Git-Hash: cf38d09075039ec3151f5226b4002569d05c489c Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/8c97abb98ec2919da69beea93bfe3bedc2f6abfe Modified Files

pgsql: Fix typo in internal error message

2018-02-26 Thread Peter Eisentraut
Fix typo in internal error message Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/964bddf1e87a42bbaaa989be0aabee94dbac9432 Modified Files -- src/pl/plpgsql/src/pl_exec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

  1   2   3   4   5   6   7   8   9   10   >