Re: [pgAdmin][RM-6916]: Allow disabling GPU hardware acceleration

2022-01-18 Thread Dave Page
Hi On Tue, Jan 18, 2022 at 6:20 AM Akshay Joshi wrote: > Hi Dave/Nikhil > > On Thu, Jan 13, 2022 at 1:31 PM Dave Page wrote: > >> >> >> On Thu, 13 Jan 2022 at 07:38, Akshay Joshi >> wrote: >> >>> Thanks, the patch applied. >>> >> >> Should we really hard code this? I’m not sure the GPU would a

pgAdmin 4 commit: Fixed feature test cases for maintenance dialog.

2022-01-18 Thread Akshay Joshi
Fixed feature test cases for maintenance dialog. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e7e4d5cf0a82773f10b2ec58ae981ce6642cc41b Author: Nikhil Mohite Modified Files -- web/pgadmin/feature_tests/pg_utilities_maintenance_t

pgAdmin 4 commit: Fixed following code smells reported by SonarQube:

2022-01-18 Thread Akshay Joshi
Fixed following code smells reported by SonarQube: 1) Immediately return this expression instead of assigning it to the temporary variable. 2) Extract this nested ternary operation into an independent statement. 3) Expected a `for-of` loop instead of a `for` loop with this simple iteration. Br

Re: [pgAdmin]: Fix test cases for maintenance dialog.

2022-01-18 Thread Akshay Joshi
Thanks, the patch applied. On Mon, Jan 17, 2022 at 3:00 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Hackers, > > Please find the attached patch to fix the feature test case falling for > the Maintenance dialog. > > > -- > *Thanks & Regards,* > *Nikhil Mohite* > *Senior Software

[pgAdmin][patch] Form Input Select enhancements

2022-01-18 Thread Aditya Toshniwal
Hi Hackers, Attached will add support for grouping in input select boxes and allow setting default selected options. Please review. -- Thanks, Aditya Toshniwal pgAdmin Hacker | Software Architect | *edbpostgres.com* "Don't Complain about Heat, Plant a TREE" inputselect

Re: [pgAdmin][RM-6916]: Allow disabling GPU hardware acceleration

2022-01-18 Thread Aditya Toshniwal
Hi, The only ways to pass flags are using cli or putting it in package.json. If we want to keep it configurable then we need to spawn in from the main process and pass the flags. On Tue, Jan 18, 2022 at 2:21 PM Dave Page wrote: > Hi > > On Tue, Jan 18, 2022 at 6:20 AM Akshay Joshi < > akshay.jo

Re: [pgAdmin][patch] Form Input Select enhancements

2022-01-18 Thread Aditya Toshniwal
Hi Hackers, Please ignore the previous patch. Attached is the updated version. On Tue, Jan 18, 2022 at 4:21 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached will add support for grouping in input select boxes and allow > setting default selected options.

pgAdmin 4 commit: Fixed context menu issue.

2022-01-18 Thread Akshay Joshi
Fixed context menu issue. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6adc1bfd4268b227c10cce95329537fa5dd3c786 Modified Files -- web/pgadmin/browser/static/js/browser.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgAdmin 4 commit: Added support for grouping in input select boxes and

2022-01-18 Thread Akshay Joshi
Added support for grouping in input select boxes and allow setting default selected options. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fbc3b1a3185fbc1dd16de14f31f5c0280d5d547d Author: Aditya Toshniwal Modified Files -- .../

Re: [pgAdmin][patch] Form Input Select enhancements

2022-01-18 Thread Akshay Joshi
Thanks, the patch applied. On Tue, Jan 18, 2022 at 6:39 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Please ignore the previous patch. Attached is the updated version. > > On Tue, Jan 18, 2022 at 4:21 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com>

Re: [pgAdmin][RM-6916]: Allow disabling GPU hardware acceleration

2022-01-18 Thread Dave Page
Hi On Tue, Jan 18, 2022 at 12:24 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > The only ways to pass flags are using cli or putting it in package.json. > If we want to keep it configurable then we need to spawn in from the main > process and pass the flags. > Urgh. In

pgAdmin 4 commit: Fixed enable/disable menu issue introduced by SonarQu

2022-01-18 Thread Akshay Joshi
Fixed enable/disable menu issue introduced by SonarQube fix. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=dabe64a8df1a22095d63dade37025e64c8339394 Modified Files -- web/pgadmin/browser/static/js/browser.js | 8 +--- 1 file ch

[pgAdmin][Patch] - Housekeeping #7017- [React] Port Import Export dialog to React.

2022-01-18 Thread Yogesh Mahajan
Hi Hackers, Please find the patch which port import/export data dialogue to react. Thanks, Yogesh Mahajan EnterpriseDB RM_7017_v1.patch Description: Binary data

[pgAdmin][RM-7035]: v6.2 keeps opening connections to (closed) connections on initial connection to database server/cluster

2022-01-18 Thread Nikhil Mohite
Hi Hackers, Please find the attached patch for RM-7035: v6.2 keeps opening connections to (closed) connections on the initial connection to the database server/cluster -- *Thanks & Regards,* *Nikhil Mohite* *Senior Software Engineer.* *EDB Postgres*