[pgAdmin]:Patch for SonarQube fixes.

2021-03-18 Thread Pradip Parkale
Hi Hackers, I have fixed a few sonarQube issues.PFA patch. - Fts Configuration 1. Remove this commented-out code. - Funtion 1. Update this function so that its implementation is not identical to the one on line 51. 2. Unexpected empty method 'validate'. - Trigger func

pgAdmin 4 commit: Ensure that toggle buttons are accessible by most scr

2021-03-18 Thread Akshay Joshi
Ensure that toggle buttons are accessible by most screen readers. Fixes #6317 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b973d6055dc316be021ec1fb5105e6c16661b7f6 Author: Khushboo Vashi Modified Files -- docs/en_US/release_not

Re: [pgAdmin4][Patch]: RM 6317 - Toggle buttons are inaccessible

2021-03-18 Thread Akshay Joshi
Thanks, patch applied. On Wed, Mar 17, 2021 at 2:36 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix the RM #6317: Toggle buttons are > inaccessible. > > Our toggle buttons are not the HTML buttons but the combinations of HTML > tags whi

pgAdmin 4 commit: Fixed some issues reported by SonarQube.

2021-03-18 Thread Akshay Joshi
Fixed some issues reported by SonarQube. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=24dc7f4a91230f95b74b326b247743c02b3aca4c Author: Pradip Parkale Modified Files -- .../static/js/fts_configuration.js | 1 - .

pgAdmin 4 commit: Fixed cognitive complexity reported by SonarQube.

2021-03-18 Thread Akshay Joshi
Fixed cognitive complexity reported by SonarQube. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f5cc1d1c7e20ba1eba0167b1feee1fb78d017346 Author: Rahul Shirsat Modified Files -- .../databases/schemas/functions/__init__.py

Re: [pgAdmin]:Patch for SonarQube fixes.

2021-03-18 Thread Akshay Joshi
Thanks, patch applied. On Thu, Mar 18, 2021 at 2:51 PM Pradip Parkale < pradip.park...@enterprisedb.com> wrote: > Hi Hackers, > > I have fixed a few sonarQube issues.PFA patch. > >- Fts Configuration > > >1. Remove this commented-out code. > > >- Funtion > > >1. Update this functi

Re: SonarQube Fixes #5 Roles & Functions

2021-03-18 Thread Akshay Joshi
Thanks, patch applied. On Wed, Mar 17, 2021 at 4:50 PM Rahul Shirsat < rahul.shir...@enterprisedb.com> wrote: > Hi Hackers, > > Please find the patch which resolves below sonar qube issues: > > For Roles: > Refactor this function to reduce its Cognitive Complexity from 21 to the > 15 allowed > Re