[pgAdmin]: Patch for SonarQube fixes.

2021-03-01 Thread Nikhil Mohite
Hi Team, I have fixed a few sonarQube issues, PFA patch Details as follows: 1. Back-form (backform.pgadmin.js): - TypeError can be thrown as "$tabContent" might be null or undefined here. 2. User Management (user_management.js): - 'self' is already declared in the upper scope. - '

pgAdmin 4 commit: Clarify docs around configuration.

2021-03-01 Thread Dave Page
Clarify docs around configuration. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6cf3913c8ed998ab4d57cd2e8c3730ac249be7ea Modified Files -- docs/en_US/config_py.rst | 22 +- docs/en_US/master_password.rst

Re: [pgAdmin]: Patch for SonarQube fixes.

2021-03-01 Thread Akshay Joshi
Hi Nikhil You forgot to attach the patch :) On Mon, Mar 1, 2021 at 4:12 PM Nikhil Mohite wrote: > Hi Team, > > I have fixed a few sonarQube issues, PFA patch > Details as follows: > > 1. Back-form (backform.pgadmin.js): > >- TypeError can be thrown as "$tabContent" might be null or undefin

Re: [pgAdmin]: Patch for SonarQube fixes.

2021-03-01 Thread Nikhil Mohite
Hi Akshay, Sorry for the inconvenience, Please find the attached patch. Regards, Nikhil Mohite. On Mon, Mar 1, 2021 at 4:37 PM Akshay Joshi wrote: > Hi Nikhil > > You forgot to attach the patch :) > > On Mon, Mar 1, 2021 at 4:12 PM Nikhil Mohite < > nikhil.moh...@enterprisedb.com> wrote: > >>

Re: Feature 6270: Allow for --load-servers to replace current server list

2021-03-01 Thread Alessandro De Maria
Hey Akshay, Thank you for the suggestions, here are the patches. Regards Alessandro On Fri, 26 Feb 2021 at 09:25, Akshay Joshi wrote: > Hi Alessandro > > Patch looks good to me. Please fix the following issues: > >- Fix the PEP8 issue. >- Documentation needs to be updated with this new

pgAdmin 4 commit: Added '--replace' option in Import server to replace

2021-03-01 Thread Akshay Joshi
Added '--replace' option in Import server to replace the list of servers with the newly imported one. Fixes #6270 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=faa66f1636ef3a8e6e8f82c011126f11a08b7ad0 Author: Alessandro De Maria Modified F

pgAdmin 4 commit: Fixed SonarQube issues.

2021-03-01 Thread Akshay Joshi
Fixed SonarQube issues. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=cb5d7190c417adae5c784314bfeb4ff42ccf27f8 Author: Nikhil Mohite Modified Files -- web/pgadmin/static/js/backform.pgadmin.js | 2 +- .../user_managemen

Re: [pgAdmin]: Patch for SonarQube fixes.

2021-03-01 Thread Akshay Joshi
Thanks, patch applied. On Mon, Mar 1, 2021 at 4:42 PM Nikhil Mohite wrote: > Hi Akshay, > > Sorry for the inconvenience, Please find the attached patch. > > Regards, > Nikhil Mohite. > > On Mon, Mar 1, 2021 at 4:37 PM Akshay Joshi > wrote: > >> Hi Nikhil >> >> You forgot to attach the patch :)

Re: Feature 6270: Allow for --load-servers to replace current server list

2021-03-01 Thread Akshay Joshi
Thanks, patch applied. On Mon, Mar 1, 2021 at 4:42 PM Alessandro De Maria < alessandro.dema...@gmail.com> wrote: > Hey Akshay, > > Thank you for the suggestions, here are the patches. > > Regards > Alessandro > > On Fri, 26 Feb 2021 at 09:25, Akshay Joshi > wrote: > >> Hi Alessandro >> >> Patch

pgAdmin 4 - desktop version - RPM

2021-03-01 Thread gmail Vladimir Koković
After many years of using "pgAdmin III", I tried several times to run the "pgAdmin 4" desktop version, but always without success! So it is on this day in an attempt to run pgadmin4-desktop-5.0-1.fc33.x86_64.rpm (snapshots/2021-03-01). After extracting the files from the RPM to the /tmp/vk/rpm/

Re: pgAdmin 4 - desktop version - RPM

2021-03-01 Thread Dave Page
On Mon, Mar 1, 2021 at 3:25 PM gmail Vladimir Koković < vladimir.koko...@gmail.com> wrote: > After many years of using "pgAdmin III", I tried several times to run the > "pgAdmin 4" desktop version, but always without success! > > So it is on this day in an attempt to run > pgadmin4-desktop-5.0-1.f

Re: pgAdmin 4 - desktop version - RPM

2021-03-01 Thread gmail Vladimir Koković
Hi Dave, You are absolutely right, you need to extract the server first and then the desktop RPM and the "pgAdmin 4" desktop version works! By the way, I'm on Linux Manjaro for which you don't have a package and that's why it's easiest to use the RPM package. On 1.3.21. 16:48, Dave Page wro

Re: pgAdmin 4 - desktop version - RPM

2021-03-01 Thread Dave Page
On Mon, Mar 1, 2021 at 4:03 PM gmail Vladimir Koković < vladimir.koko...@gmail.com> wrote: > Hi Dave, > > You are absolutely right, you need to extract the server first and then > the desktop RPM and the "pgAdmin 4" desktop version works! > > By the way, I'm on Linux Manjaro for which you don't ha