Re: [pgAdmin] RM6098 Manually deleting from table view hangs

2021-01-19 Thread Akshay Joshi
Hi Nikhil Can you please review it. On Mon, Jan 18, 2021 at 8:21 PM Rahul Shirsat < rahul.shir...@enterprisedb.com> wrote: > Hi Hackers, > > Please find the attached patch which resolves the issue of deleting > records when the user tries to delete multiple records step by step. > > -- > *Rahul

pgAdmin 4 commit: Fixed cognitive complexity reported by SonarQube.

2021-01-19 Thread Akshay Joshi
Fixed cognitive complexity reported by SonarQube. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=da9f9017a94fe6fe94c2fd7832bef07aa568c4e8 Author: Nikhil Mohite Modified Files -- .../databases/schemas/tables/schema_diff_utils.py

pgAdmin 4 commit: Fixed API test cases for Kerberose.

2021-01-19 Thread Akshay Joshi
Fixed API test cases for Kerberose. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=94d2ad958406c6c83e42196f38021f2365dc72bc Author: Nikhil Mohite Modified Files -- web/pgadmin/browser/tests/test_kerberos_with_mocking.py | 2 -- 1

Re: [pgAdmin]: Fix for kerberos test cases.

2021-01-19 Thread Akshay Joshi
Thanks, patch applied. On Tue, Jan 19, 2021 at 12:30 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Team, > > Please find the patch to fix the failing test cases. > > > -- > *Thanks & Regards,* > *Nikhil Mohite* > *Software Engineer.* > *EDB Postgres*

Re: [pgAdmin]: Patch for SonarQube fixes

2021-01-19 Thread Akshay Joshi
Thanks, patch applied. On Tue, Jan 19, 2021 at 12:58 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Team, > > I have fixed a few sonarQube issues, PFA patch > Details as follows: > > Schema diff: > >- Refactor this function to reduce its Cognitive Complexity from 17 to >th

pgAdmin 4 commit: 1) Handle the version conflict exception in dependenc

2021-01-19 Thread Akshay Joshi
1) Handle the version conflict exception in dependency inventory. 2) Update Dependencies. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=459c6ab796e9e1ef7887035ddf99456e354c49e4 Modified Files -- DEPENDENCIES | 64

pgAdmin 4 commit: Update copyright notice for ERD and Kerberos files.

2021-01-19 Thread Akshay Joshi
Update copyright notice for ERD and Kerberos files. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9fa29457a45150bb8cd16c61f0452bbb5fcb832b Modified Files -- web/pgadmin/authenticate/kerberos.py

pgAdmin 4 commit: Fixed an issue of deleting records when the user trie

2021-01-19 Thread Akshay Joshi
Fixed an issue of deleting records when the user tries to delete multiple records. Fixes #6098 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b3ca172f3a193dfad2602ff1bcbf69ec776d8652 Author: Rahul Shirsat Modified Files -- docs/

[pgAdmin4][Patch] - Fixed various issues of the Macros

2021-01-19 Thread Khushboo Vashi
Hi, Please find the attached patch to fix below the issues of the macro module: #5905 - Save button is enabled by-default #5906 - Consistent behaviour should be displayed if user clear manage macro #5907 - We need to fix the behaviour of Clear All Rows if user does not enter any value #5929 - Mes