Re: [pgAdmin][RM5330]: [Code Coverage] Improve API test cases for Functions

Hi Akshay/Team, I checked the code and found an issue in the "msql" function, due to which test cases were failing. I have fixed the issue, PFA updated patch for the same. Sorry for the inconvenience. Regards, Nikhil Mohite. On Tue, Sep 22, 2020 at 11:41 AM Akshay Joshi wrote: > Hi Nikhil >

Re: [pgAdmin][SonarQube] Reduce cognitive complexity

Hi Aditya The patch fixes only 1 code smell and introduce 1 new. Please fix those and resend the patch. On Tue, Sep 22, 2020 at 11:04 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached path will reduce the cognitive complexity as > below:web/pgadmin/misc/

pgAdmin 4 commit: Improve code coverage and API test cases for Function

Improve code coverage and API test cases for Functions. Fixes #5330 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=43d97b0e6f5ea910586092113ec3baf8b74ded9d Author: Nikhil Mohite Modified Files -- docs/en_US/release_notes_4_27.rst

pgAdmin 4 commit: Fixed an issue where the server is not able to connec

Fixed an issue where the server is not able to connect using the service. Fixes #5841 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=458036ad6ba3e3dd936330de56b2fbc1708084d7 Author: Pradip Parkale Modified Files -- docs/en_US/re

Re: [pgAdmin][SonarQube] Reduce cognitive complexity

Hi, Please find the updated patch. On Tue, Sep 22, 2020 at 2:56 PM Akshay Joshi wrote: > Hi Aditya > > The patch fixes only 1 code smell and introduce 1 new. Please fix those > and resend the patch. > > On Tue, Sep 22, 2020 at 11:04 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wro

Re: [pgAdmin][RM5330]: [Code Coverage] Improve API test cases for Functions

Thanks, patch applied On Tue, 22 Sep, 2020, 12:44 Nikhil Mohite, wrote: > Hi Akshay/Team, > > I checked the code and found an issue in the "msql" function, due to which > test cases were failing. > I have fixed the issue, PFA updated patch for the same. > Sorry for the inconvenience. > > > Regar

Re: RM5841: server.username can be empty when using .pg_service.conf

Thanks, patch applied On Tue, 22 Sep, 2020, 12:10 Pradip Parkale, wrote: > Hi Akshay, > > Please find the updated patch. > > On Mon, Sep 21, 2020 at 4:41 PM Pradip Parkale < > pradip.park...@enterprisedb.com> wrote: > >> Hi Akshay, >> >> >> On Mon, Sep 21, 2020 at 9:30 AM Akshay Joshi < >> aksha

[pgAdmin][RM5843] [SQL] - Some 'options' values for function not shown in sql

Hi Hackers, The 'Unsafe' parallel option was not visible in the SQL for function and procedure. Attached is the patch to fix this issue. -- Thanks & Regards, Pradip Parkale Software Engineer | EnterpriseDB Corporation RM5843.patch Description: Binary data

Re: [pgAdmin][RM5843] [SQL] - Some 'options' values for function not shown in sql

Hi Pradip RESQL tests are failing on EPAS 9.5, 9.6, and 10. Please fix and resend the patch. On Tue, Sep 22, 2020 at 6:41 PM Pradip Parkale < pradip.park...@enterprisedb.com> wrote: > Hi Hackers, > > The 'Unsafe' parallel option was not visible in the SQL for function and > procedure. Attached i