RM_5734 Patch

Hi, PFA patch for RM_5734. It is about correcting the description of GiST and GIN Indexes in the pgAdmin4 Online Help. Thanks, Best Regards, Nidhi Bhammar www.enterprisedb.com RM_5734.patch Description: Binary data

Patch for SonarQube code scan fixes.

Hi Team, I have fixed some code smell issues in the SonarQube scan, PFA patch. Details as follows: 1. psycopg2/connection: - Refactor this function to reduce its Cognitive Complexity from 32 to the 15 allowed. - Refactor this function to reduce its Cognitive Complexity from 17 to the

Re: Patch for SonarQube code scan fixes.

Hi, sqlautocomplete code is mostly inherited from the pgcli project. Changing it might create trouble in updating the code with new versions. On Tue, Sep 8, 2020 at 2:59 PM Nikhil Mohite wrote: > Hi Team, > > I have fixed some code smell issues in the SonarQube scan, PFA patch. > Details as fol

Re: Patch for SonarQube code scan fixes.

On Tue, Sep 8, 2020 at 11:01 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > sqlautocomplete code is mostly inherited from the pgcli project. Changing > it might create trouble in updating the code with new versions. > Send a patch upstream :-) > > On Tue, Sep 8, 2020

Re: Patch for SonarQube code scan fixes.

Hi Dave, On Tue, Sep 8, 2020 at 3:53 PM Dave Page wrote: > > On Tue, Sep 8, 2020 at 11:01 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi, >> >> sqlautocomplete code is mostly inherited from the pgcli project. Changing >> it might create trouble in updating the code wit

Re: Patch for SonarQube code scan fixes.

On Tue, Sep 8, 2020 at 11:40 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Dave, > > On Tue, Sep 8, 2020 at 3:53 PM Dave Page wrote: > >> >> On Tue, Sep 8, 2020 at 11:01 AM Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Hi, >>> >>> sqlautocomplete co

[pgAdmin][SonarQube] Reduce cognitive complexity

Attached patch reduces the cognitive complexity as below: web/pgadmin/tools/sqleditor/utils/is_begin_required.py - 89 to 15 web/pgadmin/utils/driver/psycopg2/connection.py - 16 to 15 web/setup.py - 17 to 15 Please review. -- Thanks, Aditya Toshniwal pgAdmin hacker | Sr. Software Engineer | *edbp

pgAdmin 4 commit: Fixed cognitive complexity issues reported by SonarQu

Fixed cognitive complexity issues reported by SonarQube. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=72f0e87367cfd052d9c6df9e606d80157e80c42e Author: Nikhil Mohite Modified Files -- web/pgadmin/utils/driver/psycopg2/connection

Re: [pgAdmin][SonarQube] Reduce cognitive complexity

Thanks, patch applied. On Tue, Sep 8, 2020 at 6:13 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Attached patch reduces the cognitive complexity as below: > web/pgadmin/tools/sqleditor/utils/is_begin_required.py - 89 to 15 > web/pgadmin/utils/driver/psycopg2/connection.py - 16

pgAdmin 4 commit: Fixed cognitive complexity issues reported by SonarQu

Fixed cognitive complexity issues reported by SonarQube. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=535739c0c76348f1dad3882cf6ac5e81ed5f5a81 Author: Aditya Toshniwal Modified Files -- .../tools/sqleditor/utils/is_begin_requir

Re: Patch for SonarQube code scan fixes.

Thanks, patch applied. I haven't committed changes for "sqlautocomplete/parseutils", as Dave suggested send the patch to pgcli. On Tue, Sep 8, 2020 at 2:59 PM Nikhil Mohite wrote: > Hi Team, > > I have fixed some code smell issues in the SonarQube scan, PFA patch. > Details as follows: > > 1. ps

Re: [pgAdmin][RM5794] Excessive CPU usage while browser is idle

Hi, In the previous patch, I had changed the react state directly, which is not recommended and can cause unpredictable behavior. Attached patch changes the previous commit to avoid changing state directly. Please review. On Mon, Sep 7, 2020 at 6:48 PM Akshay Joshi wrote: > Thanks, patch appli