Hi Warren,
Can you check the browser console if any errors ? Can you also share the
patch so that I can help you further by debugging at my end ?
On Wed, Sep 2, 2020 at 9:51 AM Warren Chan wrote:
> Hi,
>
> I'm trying to learn about the pgAdmin4 project and am hoping to make some
> contributions
Rename the menu option 'Search objects' to 'Search Objects...'
Branch
--
master
Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1c9badec9cc9852688df44ddd12b03547cb37957
Modified Files
--
web/pgadmin/tools/search_objects/static/js/search_objects.js
Added exclamation icon to alertify warning messages.
Branch
--
master
Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ddf5b332195dc3819b61eb3ed3ba84785d2a332f
Modified Files
--
web/pgadmin/static/js/alertify.pgadmin.defaults.js | 15 ++-
Fixed cognitive complexity issues reported by SonarQube.
Branch
--
master
Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8f3bdf1cf3180102b81f3400bb3228daf9197bae
Author: Aditya Toshniwal
Modified Files
--
.../server_groups/servers/pgagent/__init_
Thanks, patch applied.
On Tue, Sep 1, 2020 at 3:34 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:
> Hi Hackers,
>
> Attached patch reduces cognitive complexity as below:
>
> web/.../server_groups/servers/pgagent/__init__.py - 23 to 15
> web/pgadmin/utils/driver/psycopg2/__init__.
Hi Warren,
The patch works fine, just that replacing sequences with foos was missing
at 1-2 places. I guess you've not restarted the dev server after the
changes. :)
- Always restart the backend dev server if there is any change in Python or
any template files.
- You can run webpack in continuous
Hi Aditya,
thats it, I wasn't running yarn bundle after my modifications to the templates.
Thanks for tip to run webpack in continuous mode, that's great.
Really appreciate the help in getting past this.
Best Regards,Warren Chan
On Thursday, 3 September 2020, 2:43:56 pm AEST, Aditya Toshn
Hi Warren,
On Thu, Sep 3, 2020 at 11:14 AM Warren Chan wrote:
> Hi Aditya,
>
> thats it, I wasn't running yarn bundle after my modifications to the
> templates. Thanks for tip to run webpack in continuous mode, that's great.
>
You need to restart the backend server if you change the templates. y
