[pgAdmin][RM5344][Code Coverage] Improve API test cases for Grant Wizard

Hi Team, I have added test cases for Grant wizard as per RM-5344 PFA patch for the same. Regards, Nikhil Mohite. RM_5344_v1.patch Description: Binary data

pgAdmin 4 commit: Fixed following SonarQube issues:

Fixed following SonarQube issues: 1. String literals should not be duplicated. 2. Cognitive Complexity of functions should not be too high. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0668a52c6bbc919c33575ebeb3e47dd71ffcb6e6 Author: Yoges

pgAdmin 4 commit: Fixed cognitive complexity issues reported by SonarQu

Fixed cognitive complexity issues reported by SonarQube. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4b56962c1b72d49820f0dcc158073001363ab3ac Author: Nikhil Mohite Modified Files -- .../servers/databases/languages/__init__.py

Re: Patch for SonarQube code scan fixes.

Thanks, patch applied. On Mon, Aug 17, 2020 at 11:17 AM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Team, > > I have fixed some code smell issues in the SonarQube scan, PFA patch. > Details as follows: > > 1. languages: > >- Refactor this function to reduce its Cognitive Compl

Re: [pgAdmin4][Patch] - SonarQube Issues - 14 (String literals should not be duplicated, Cognitive Complexity of functions should not be too high)

Thanks, patch applied. On Wed, Aug 12, 2020 at 8:13 PM Yogesh Mahajan < yogesh.maha...@enterprisedb.com> wrote: > Hello, > > Please find patch which fixes issues related to rule from feature test > modules - > 1.String literals should not be duplicated - 3 issues > 2.Cognitive Complexity of funct

Re: [pgAdmin4][Patch] - SonarQube Fixes

Hi, Please find the attached updated patch. On Tue, Aug 4, 2020 at 12:10 PM Akshay Joshi wrote: > Hi Khushboo > > As per offline discussion, multiple developers declaring the constant for > the same string and error messages. To avoid that only one developer should > work on this task. > Sugge

pgAdmin 4 commit: Fixed code smell 'String literals should not be dupli

Fixed code smell 'String literals should not be duplicated'. Create a constant.py file which contains the common Constants. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=cc5a7ea334cd862ee54e4bc2f35026f40ea991d5 Author: Khushboo Vashi Modif

Re: [pgAdmin4][Patch] - SonarQube Fixes

Thanks, patch applied. On Wed, Aug 19, 2020 at 2:01 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached updated patch. > > > On Tue, Aug 4, 2020 at 12:10 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Khushboo >> >> As per offline disc

Re: [pgAdmin4][Patch] - SonarQube Fixes #2

Hi Rahul I have committed Khushboo's patch where she has introduced a new method 'not_found_error_msg', so instead of creating a new constant 'TABLE_NOT_FOUND_MSG' use self.not_found_error_msg. Also, instead of _NODE_CSS = ‘node.css’ _COLLECTION_CSS = ‘collection.css’ We can use the following: _

Re: [pgAdmin][RM5990]: Update the style guide on pgAdmin4 website

Hi Dave/Team, As per discussion with the UX team, Few updates on style-guide patch. 1. I have missed removing the "proposed" keyword from the "High-Contract" theme name. 2. I have not added the "Writing Style" section in the style guide as we don’t have the information for it (UX design is also pe