pgAdmin 4 commit: Added ability to generate code coverage reports for j

2020-08-07 Thread Akshay Joshi
Added ability to generate code coverage reports for java script files. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=68a5027d15a8889e5cffd8338210e21b88a9ffc9 Author: Pramod Ahire Modified Files -- .gitignore

pgAdmin 4 commit: Replace the generic exception class with a more speci

2020-08-07 Thread Akshay Joshi
Replace the generic exception class with a more specific one. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d6400bbcae1cddba5f77a7c39b3b2876b7c9a1db Author: Aditya Toshniwal Modified Files -- web/pgAdmin4.py

Re: [pgAdmin][SonarQube] Replace the generic exception class with a more specific one

2020-08-07 Thread Akshay Joshi
Thanks, patch applied. On Fri, Aug 7, 2020 at 11:36 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the followup patch to fix all the remaining issues (around 30) > related to replacing the generic exception class with more specific ones. > Please rev

Re: Code coverage report generation for JS files

2020-08-07 Thread Pramod Ahire
Thank you :) Pramod Ahire Software Engineer C: +91-020-66449600/601 D: +91-9028697679 edbpostgres.com From: Akshay Joshi Date: Friday, 7 August 2020 at 12:38 PM To: Pramod Ahire Cc: Aditya Toshniwal , pgadmin-hackers , Dave Page Subject: Re: Code coverage report generation

Re: Code coverage report generation for JS files

2020-08-07 Thread Dave Page
Was a Makefile target added? Maybe "make coverage"... On Fri, Aug 7, 2020 at 8:10 AM Pramod Ahire wrote: > Thank you :) > > > > *Pramod Ahire* > > *Software Engineer* > > > > [image: > https://lh4.googleusercontent.com/U1erEuyI_d0xEUA0CrKjwx9aWQ52HNCxc38dMsLP-ZrLgfVNrhsrNobxlmeOdb1kMPtrrxcUwEHZg

pgAdmin 4 commit: Clarify some of the differences when running in serve

2020-08-07 Thread Dave Page
Clarify some of the differences when running in server mode in the docs. Fixes #5724 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d9c20de31fbb66690a4e3a86f22c1aa07f75f165 Modified Files -- docs/en_US/release_notes_4_25.rst | 3

[pgAdmin][RM5713]:Incorrect DROP SQL for Catalog and Foreign Server

2020-08-07 Thread Nikhil Mohite
Hi Team, I have resolved the issue in SQL statements for RM-5713 . PFA patch. RM_5713_v1.patch Description: Binary data

Bug #5670 - Backup dialog error message does not have close button

2020-08-07 Thread Yogesh Mahajan
Hello, Please find a patch which adds a close button to error messages shown in backup, restore tab. Also fix width issue Thanks, Yogesh Mahajan QA - Team EnterpriseDB Corporation Phone: +91-9741705709 RM5670_v1.patch Description: Binary data

pgAdmin 4 commit: Fixed an issue where the error message does not have

2020-08-07 Thread Akshay Joshi
Fixed an issue where the error message does not have a close button on utility dialogs. Fixes #5670 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3672013ddc2369970883cfa3c2a7f9e16461c39c Author: Yogesh Mahajan  Modified Files -

pgAdmin 4 commit: Added make file target for the coverage of JS files.

2020-08-07 Thread Akshay Joshi
Added make file target for the coverage of JS files. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=23a12efd29598d71344c44d9792380434a47a378 Author: Pramod Ahire Modified Files -- Makefile | 3 +++ 1 file changed, 3 insertions(+)

pgAdmin 4 commit: Corrected DROP SQL syntax for catalog. Fixes #5713

2020-08-07 Thread Akshay Joshi
Corrected DROP SQL syntax for catalog. Fixes #5713 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9ad7476a34c77999bc43ecc0f6a03b7cd01862fd Author: Nikhil Mohite  Modified Files -- docs/en_US/release_notes_4_25.rst

pgAdmin 4 commit: Added the 'ORDER BY' clause for the privileges type t

2020-08-07 Thread Akshay Joshi
Added the 'ORDER BY' clause for the privileges type to fix schema diff issue. Fixes #5689 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=518b13c77981125fe03be28b4d08694400efee8b Modified Files -- docs/en_US/release_notes_4_25.rst

Re: Bug #5670 - Backup dialog error message does not have close button

2020-08-07 Thread Akshay Joshi
Thanks, patch applied. On Fri, Aug 7, 2020 at 3:14 PM Yogesh Mahajan < yogesh.maha...@enterprisedb.com> wrote: > Hello, > > Please find a patch which adds a close button to error messages shown in > backup, restore tab. > Also fix width issue > > Thanks, > Yogesh Mahajan > QA - Team > EnterpriseD

Re: [pgAdmin][RM5713]:Incorrect DROP SQL for Catalog and Foreign Server

2020-08-07 Thread Akshay Joshi
Thanks, patch applied. On Fri, Aug 7, 2020 at 2:49 PM Nikhil Mohite wrote: > Hi Team, > > I have resolved the issue in SQL statements for RM-5713 > . > > PFA patch. > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Sr. Software Architect* *ED

Re: Code coverage report generation for JS files

2020-08-07 Thread Pramod Ahire
Thank you ! appreciates your quick action. Pramod Ahire Software Engineer C: +91-020-66449600/601 D: +91-9028697679 edbpostgres.com From: Akshay Joshi Date: Friday, 7 August 2020 at 5:25 PM To: Pramod Ahire Cc: Dave Page , Aditya Toshniwal , pgadmin-hackers Subject: Re: Co

Bug #5664 SQL DDL output generator for view

2020-08-07 Thread Rahul Shirsat
Hi Hackers, Please find the attached patch below which resolves the following issue of SQL DDL output generator for view (preserving default values of columns) Also, when changing VIEW's column's default value, the SQL generates ALTER TABLE, now this would be as ALTER VIEW instead. This fix coul

Re: WIP: SQL Formatter

2020-08-07 Thread Dave Page
On Mon, Aug 3, 2020 at 10:51 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > On Mon, Aug 3, 2020 at 3:06 PM Dave Page wrote: > >> >> >> On Mon, Aug 3, 2020 at 10:31 AM Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Hi, >>> >>> On Fri, Jul 31, 2020