pgAdmin 4 v4.24 released

2020-07-23 Thread Akshay Joshi
The pgAdmin Development Team is pleased to announce pgAdmin 4 version 4.24. This release of pgAdmin 4 includes 34 bug fixes and new features. For more details please see the release notes at: https://www.pgadmin.org/docs/pgadmin4/4.24/release_notes_4_24.html. pgAdmin is the leading Open Sourc

pgAdmin 4 commit: Tag REL-4_24 has been created.

2020-07-23 Thread Akshay Joshi
Tag REL-4_24 has been created. View: https://git.postgresql.org/gitweb?p=pgadmin4.git;a=tag;h=refs/tags/REL-4_24 Log Message --- Tag v4.24

Re: [pgAdmin][RM3904] Replace charting library Flotr2 with ChartJS using React

2020-07-23 Thread Dave Page
Very nice. One quick issue that I immediately saw - if the dashboard is not the top-most tab when pgAdmin opens, then when you've selected something on the treeview and then click on the dashboard tab, the graphs don't populate until you select a different object. I'll play some more tomorrow when

pgAdmin 4 commit: Fixed code smell 'Unused local variables should be re

2020-07-23 Thread Akshay Joshi
Fixed code smell 'Unused local variables should be removed'. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=dd27e08a98c1564431d5464bc52687935b897474 Author: Yogesh Mahajan Modified Files -- tools/copyright_updater.py

Re: [pgAdmin4][Patch] - SonarQube Issues - 11 (Unused local variables should be removed)

2020-07-23 Thread Akshay Joshi
Thanks, patch applied. On Wed, Jul 22, 2020 at 5:42 PM Yogesh Mahajan < yogesh.maha...@enterprisedb.com> wrote: > Hello, > > Please find an attached patch fixing 17 sonarqube issues related to below > rule - > - Unused local variables should be removed. > > Thanks, > Yogesh Mahajan > QA - Team >

pgAdmin 4 commit: 1) Fixed cognitive complexity issues reported by Sona

2020-07-23 Thread Akshay Joshi
1) Fixed cognitive complexity issues reported by SonarQube. 2) Fixed code smell 'Add a nested comment explaining why this method is empty, or complete the implementation'. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=505a3ac960400025e4fea

Re: [pgAdmin][SonarQube] Complete the implementation of empty methods

2020-07-23 Thread Akshay Joshi
Thanks, patch applied. On Thu, Jul 23, 2020 at 11:41 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to close all the 32 SonarQube issues under the rule > - "Add a nested comment explaining why this method is empty, or complete > the impleme

pgAdmin 4 commit: Fixed cognitive complexity issues reported by SonarQu

2020-07-23 Thread Akshay Joshi
Fixed cognitive complexity issues reported by SonarQube. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1fbf298d30acef69b98f11b6d711ad5ff38587fa Author: Nikhil Mohite Modified Files -- .../tables/constraints/foreign_key/utils.py

Re: [pgAdmin][SonarQube] Reduce cognitive complexity of functions

2020-07-23 Thread Akshay Joshi
Thanks, patch applied. On Mon, Jul 20, 2020 at 12:25 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to reduce cognitive complexity of functions: > 1) web/.../exclusion_constraint/__init__.py > create > from 25 to 15 > 2) web/.../exclusion_c

Re: Patch for SonarQube code scan fixes.

2020-07-23 Thread Akshay Joshi
Thanks, patch applied. On Tue, Jul 21, 2020 at 10:45 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Team, > > I have fixed some code smell issues in the SonarQube scan, PFA patch. > Details as follows: > 1. Database utils: > >- Refactor this function to reduce its Cognitive Co