Runtime refactoring

Here's a pretty large patch that implements a major refactoring of the runtime code. Specifically: - Move the bulk of the core code from main() into a new Runtime class. - Break up the mass of code that was main() into a number of relatively simple functions. - Make the Configuration dialog synchr

Re: [pgAdmin][SonarQube] Shadowing variables

Hi Hackers, Attached is the patch to fix a few more SonarQube reported issues(around 28) related to "potential hiding of variables declared in an outer scope". Please review. On Tue, Jul 14, 2020 at 4:06 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Mon, Jul 13, 2020 at 10:15 AM Aditya

[pgAdmin 4 - Bug #5137] Focussing in and then out of numeric input enables the save button in dialog

Hi Hackers, Please find the patch which fixes the bug related to save-button getting enabled on hitting tab key/focusing in and out of the numeric field(empty/non-empty). Kindly review the patch. Thanks, Sathish V RM5137s1.patch Description: Binary data

[pgAdmin][RM5675] csrf token error on safari iframe

Hi Hackers, Attached is the patch to fix CSRF errors when pgAdmin opened in an iframe on safari browser. Please review. -- Regards, Aditya Toshniwal pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* "Don't Complain about Heat, Plant a TREE" RM5675.patch Descri

pgAdmin 4 commit: Fixed following SoanrQube issues

Fixed following SoanrQube issues   1) Rename field "node_type" to prevent any misunderstanding/clash with field "NODE_TYPE" defined.   2) Define a constant instead of duplicating this literal. Solution: 1) Rename the field "NODE_TYPE" and "COLLECTION_LABEL" to "_NODE_TYPE" and "_COLLECTION_LAB

pgAdmin 4 commit: Fixed code smell 'potential hiding of variables decla

Fixed code smell 'potential hiding of variables declared in an outer scope'. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9d0f3ce90b0fa1437d12a39fc6c2c0ec78c39f7c Author: Aditya Toshniwal Modified Files -- web/pgadmin/misc/file

Re: [pgAdmin][SonarQube] Shadowing variables

Thanks, patch applied. On Thu, Jul 16, 2020 at 3:11 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to fix a few more SonarQube reported issues(around > 28) related to "potential hiding of variables declared in an outer scope". > Please revi

Re: [pgAdmin][RM5653]: High Contrast UI Theme

Aditya, can you please do the code review. On Thu, Jul 16, 2020 at 6:54 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Team, > > I have completed changes for the support of the new High-Contrast UI > Theme RM-#5653 . > > PFA patch. > >