Re: [pgAdmin][RM5666]: Added missing dependencies/dependent node

Hi, I'll be reviewing the patch. On Tue, Jul 14, 2020 at 12:46 PM Akshay Joshi wrote: > Hi Hackers > > Attached is the patch to add missing dependencies/dependent nodes > > Added following missing nodes: > >- Materialized View >- Event Trigger >- Collation >- FTS Configuration,

pgAdmin 4 commit: Improve code coverage and API test cases for Foreign

Improve code coverage and API test cases for Foreign Data Wrapper. Fixes #5323. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a91e4d8a7f4c980f8ee63c9801e0f7d672439879 Author: Satish V Modified Files -- docs/en_US/release_notes_4

pgAdmin 4 commit: Fixed cognitive complexity issues reported by SonarQu

Fixed cognitive complexity issues reported by SonarQube. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0013a3b047f7a4c77c29ad1ee7083b5bc120e17c Author: Nikhil Mohite Modified Files -- .../servers/databases/schemas/tables/__init_

pgAdmin 4 commit: Fixed code smell 'Variables should not be shadowed'.

Fixed code smell 'Variables should not be shadowed'. Fixed all the duplicate CSS blocks issues raised by SonarQube. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=161c9b0fc7455c5d9619b7feac94dd3f1755cc09 Author: Aditya Toshniwal Modified Fil

Re: Patch for SonarQube code scan fixes

Thanks, patch applied. I have changed the function name from "def _get_reverse_engineered_sql_for_" to "def _get_resql_for_", because function name is too long. On Mon, Jul 13, 2020 at 9:40 AM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Team, > > I have fixed some code smell issue

Re: Re-[pgAdmin][RM-5323]

Thanks, patch applied. On Mon, Jul 13, 2020 at 7:26 PM Satish V wrote: > Hi Hackers, > > Please find the patch which improves the API test cases for Foreign Data > Wrappers. > > Before patch - 46% > After Patch - 73% > Kindly review and share the changes if required. > > Thanks, > Sathish V >

Re: [pgAdmin][SonarQube] Shadowing variables

Thanks, patch applied. On Mon, Jul 13, 2020 at 10:15 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to fix the SonarQube reported issues (40+) > which potentially hides a variable declared in an outer scope. > > Please review. > > -- > Than

Re: [pgAdmin][SonarQube] Duplicate CSS blocks

Thanks, patch applied. On Tue, Jul 14, 2020 at 10:27 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to fix all the duplicate CSS blocks issues raised by > SonarQube. > Please review. > > -- > Thanks and Regards, > Aditya Toshniwal > pgAdmin

Re: [pgAdmin4][Patch] - SonarQube Fixes

Hi, Please find the more fixes for the SonarQube Code smells having Rule "*Functions, methods and lambdas should not have too many parameters*". Thanks, Khushboo On Fri, Jul 3, 2020 at 2:40 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Fri, Jul 3, 2020 at 1:12 PM Khushboo Vashi < > k

pgAdmin 4 commit: Fixed code smell 'Functions, methods, and lambdas sho

Fixed code smell 'Functions, methods, and lambdas should not have too many parameters' reported by SonarQube. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bd9dc97b4f1373687be9f2eeb105fb4451447680 Author: Khushboo Vashi Modified Files

pgAdmin 4 commit: Fixed reverse engineered SQL for partitions when stor

Fixed reverse engineered SQL for partitions when storage parameters are specified. Fixes #5569. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d6893f9d8a1a4aed95daf20664e4af3655692a11 Author: Rahul Shirsat Modified Files -- docs

pgAdmin 4 commit: Added missing dependencies/dependent and corrected so

Added missing dependencies/dependent and corrected some wrongly identified. Fixes #5666 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4f34bc0f0eb4ed33cb010055c0fe02c892b10631 Modified Files -- docs/en_US/release_notes_4_24.rst

Re: [pgAdmin4][Patch] - SonarQube Fixes

Thanks, patch applied. On Tue, Jul 14, 2020 at 6:34 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the more fixes for the SonarQube Code smells having Rule > "*Functions, > methods and lambdas should not have too many parameters*". > > Thanks, > Khushboo > > >

[pgAdmin4][Patch] - SonarQube Fixes

Hi Hackers, Please find the patch which fixes sonarQube issues related to variable shadowing. Files altered - backgird.js, backgrid.pgadmin.js Kindly review and share your feedback. Thanks, Sathish V variableShadowing.patch Description: Binary data