Re: [pgAdmin][RM5569] [SQL] Bad display of tables storage parameters in the "SQL" tab (correction of bug #5398 not complete)

Hi Rahul, - The storage parameters should be displayed in the parent table's SQL too - Please write test cases, preferably re-sql test cases Thanks, Khushboo On Mon, Jul 6, 2020 at 11:28 AM Akshay Joshi wrote: > Hi Khushboo, > > Can you please review it. > > On Sat, Jul 4, 2020 at 1:45 AM Rahu

Re: [pgAdmin4][Patch] - RM 5484 Support LDAP based auth also when users do not have the same DN structure

Hi Aditya, Please find the attached updated patch. On Mon, Jul 6, 2020 at 11:44 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Khushboo, > > I suggest, > 1) Remove the commented code > > +# if 'mail' in entry: > > +# user_email = entry['m

Re: [pgAdmin4][Patch] - RM 5484 Support LDAP based auth also when users do not have the same DN structure

On Mon, Jul 6, 2020 at 2:55 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Aditya, > > Please find the attached updated patch. > > On Mon, Jul 6, 2020 at 11:44 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Khushboo, >> >> I suggest, >> 1) Remove the co

Re: [pgAdmin4][Patch] - RM 5484 Support LDAP based auth also when users do not have the same DN structure

On Mon, Jul 6, 2020 at 3:02 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > > > On Mon, Jul 6, 2020 at 2:55 PM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi Aditya, >> >> Please find the attached updated patch. >> >> On Mon, Jul 6, 2020 at 11:44 AM Aditya Tos

Re: [pgAdmin4][Patch] - RM 5484 Support LDAP based auth also when users do not have the same DN structure

On Mon, Jul 6, 2020 at 3:16 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Mon, Jul 6, 2020 at 3:02 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> >> >> On Mon, Jul 6, 2020 at 2:55 PM Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> H

Re: [pgAdmin4][Patch] - RM 5484 Support LDAP based auth also when users do not have the same DN structure

On Mon, Jul 6, 2020 at 3:20 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > > > On Mon, Jul 6, 2020 at 3:16 PM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On Mon, Jul 6, 2020 at 3:02 PM Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >

Re: Reg - [RM-3814] Backup dialog does not show details of error if file name box kept empty

Hi Akshay, Patch looks good. Thanks, Yogesh Mahajan QA - Team EnterpriseDB Corporation Phone: +91-9741705709 On Mon, Jul 6, 2020 at 11:28 AM Akshay Joshi wrote: > Hi Yogesh, > > Can you please review it. > > On Fri, Jul 3, 2020 at 4:30 PM Satish V wrote: > >> Hi Hackers, >> >> Please find t

pgAdmin 4 commit: Fixed issue of error message not getting displayed wh

Fixed issue of error message not getting displayed when filename is empty for backup, restore, and import/export. Fixes #3814. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2ebf20341296ed51bc87675a33392a9b0efab155 Author: Satish V Modified

pgAdmin 4 commit: Fixed SonarQube issues in css/scss files.

Fixed SonarQube issues in css/scss files. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a6ce78a8c01166cb91219e61a0160f5ba5f45cd2 Author: Pramod Ahire Modified Files -- web/pgadmin/dashboard/static/scss/_dashboard.scss

pgAdmin 4 commit: Added support for LDAP authentication with different

Added support for LDAP authentication with different DN by setting the dedicated user for the LDAP connection. Fixes #5484 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=58b4c45d0c08040c49ed24c72e12245b833265e1 Author: Khushboo Vashi Modifi

Re: Reg - [RM-3814] Backup dialog does not show details of error if file name box kept empty

Thanks, patch applied. On Mon, Jul 6, 2020 at 5:08 PM Yogesh Mahajan < yogesh.maha...@enterprisedb.com> wrote: > Hi Akshay, > > Patch looks good. > > Thanks, > Yogesh Mahajan > QA - Team > EnterpriseDB Corporation > > Phone: +91-9741705709 > > > On Mon, Jul 6, 2020 at 11:28 AM Akshay Joshi < > ak

Re: [pgAdmin4][Patch] - RM 5484 Support LDAP based auth also when users do not have the same DN structure

Thanks, patch applied. On Mon, Jul 6, 2020 at 4:05 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Mon, Jul 6, 2020 at 3:20 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> >> >> On Mon, Jul 6, 2020 at 3:16 PM Khushboo Vashi < >> khushboo.va...@enterpris

[pgAdmin][RM5622]: Permissive or restricted policy on table from PG 10 and above

Hi Hackers, Please find the attached patch for a permissive and restrictive RLS policy support. I have also updated the document with new screenshots. -- Thanks & Regards, Pradip Parkale QMG, EnterpriseDB Corporation RM5622.patch Description: Binary data

Patch for SonarQube code scan fixes

Hi Team, I have fixed some code smell issues in the SonarQube scan, PFA patch. Details as follows: 1. Table Index files(utils and init): - Refactor this function to reduce its Cognitive Complexity from 27 to the 15 allowed. - Refactor this function to reduce its Cognitive Complexity from

Re: Patch for SonarQube code scan fixes

Hi Nikhil Fix the PEP8 issues. On Tue, Jul 7, 2020 at 9:35 AM Nikhil Mohite wrote: > Hi Team, > > I have fixed some code smell issues in the SonarQube scan, PFA patch. > Details as follows: > 1. Table Index files(utils and init): > >- Refactor this function to reduce its Cognitive Complexit

Re- Patch for SonarQube issues

Hi Hackers, I have fixed some issues related to variable shadowing. Please find the patch in the attachments. Files changed import_export.js and maintenance.js Thanks, Sathish V variable_shadow.patch Description: Binary data

Re: [pgAdmin][RM5622]: Permissive or restricted policy on table from PG 10 and above

Patch not applied. Please check and resend it. On Mon, Jul 6, 2020 at 8:37 PM Pradip Parkale < pradip.park...@enterprisedb.com> wrote: > Hi Hackers, > > Please find the attached patch for a permissive and restrictive RLS policy > support. I have also updated the document with new screenshots. > >

Re: Patch for SonarQube code scan fixes

Hi Akshay, I have resolved the PEP8 issues, PFA updated patch. Regards, Nikhil Mohite. On Tue, Jul 7, 2020 at 10:19 AM Akshay Joshi wrote: > Hi Nikhil > > Fix the PEP8 issues. > > On Tue, Jul 7, 2020 at 9:35 AM Nikhil Mohite < > nikhil.moh...@enterprisedb.com> wrote: > >> Hi Team, >> >> I hav

[pgAdmin4][Patch] - SonarQube Issues - 9 (Variables and functions should not be redeclared, Variables should not be shadowed)

Hi, Please find a patch which fixes issues related to rule- a.Variables should not be shadowed. b.Variables and functions should not be redeclared. Thanks, Yogesh Mahajan QA - Team EnterpriseDB Corporation Phone: +91-9741705709 SonarQubeFix9_v1.patch Description: Binary data