Re: [pgAdmin][RM5287] Dark theme and other CSS related fixes

2020-07-03 Thread Aditya Toshniwal
Hi, The jasmine test cases are failing with this commit. Attached is the patch to fix the test cases. On Fri, Jul 3, 2020 at 11:49 AM Akshay Joshi wrote: > Thanks, patch applied. > > On Thu, Jul 2, 2020 at 5:54 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >

Re: [pgAdmin][RM5287] Dark theme and other CSS related fixes

2020-07-03 Thread Akshay Joshi
Thanks, patch applied. On Fri, Jul 3, 2020 at 12:47 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > The jasmine test cases are failing with this commit. Attached is the patch > to fix the test cases. > > On Fri, Jul 3, 2020 at 11:49 AM Akshay Joshi < > akshay.jo...@enter

pgAdmin 4 commit: Fixed jasmin test cases failed due to last commit.

2020-07-03 Thread Akshay Joshi
Fixed jasmin test cases failed due to last commit. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3d5a2046c43514530e19a8a71235077b22886ff7 Author: Aditya Toshniwal Modified Files -- web/regression/javascript/alerts/alertify_wrapp

[pgAdmin4][Patch] - SonarQube Fixes

2020-07-03 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the SonarQube Code smells having Rule "*Functions, methods and lambdas should not have too many parameters*". In this patch, I have covered sql and delete functions of all the reported nodes. Thanks, Khushboo Sonar_Qube_Fixes.patch Description: Binary

[pgAdmin4][Patch] - SonarQube Issues - 8 (Variables should not be shadowed)

2020-07-03 Thread Yogesh Mahajan
Hi, Please find a patch which fixes issues related to rule- 'Variables should not be shadowed'. Thanks, Yogesh Mahajan QA - Team EnterpriseDB Corporation Phone: +91-9741705709 diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/fts_configurations/static/js/fts_configuration.

pgAdmin 4 commit: Fixed the SonarQube Code smells having Rule 'Function

2020-07-03 Thread Akshay Joshi
Fixed the SonarQube Code smells having Rule 'Functions, methods and lambdas should not have too many parameters'. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b5f0190799dfc8617ba9b6cfda62ee91be51ed97 Author: Khushboo Vashi Modified Files

pgAdmin 4 commit: Fixed the SoanrQube code smell 'Variables should not

2020-07-03 Thread Akshay Joshi
Fixed the SoanrQube code smell 'Variables should not be shadowed'. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=80ab5969920b1b258c4bb52020badbc67cf805ab Author: Yogesh Mahajan Modified Files -- .../static/js/fts_configuration.j

Re: [pgAdmin4][Patch] - SonarQube Issues - 8 (Variables should not be shadowed)

2020-07-03 Thread Akshay Joshi
Thanks, patch applied. On Fri, Jul 3, 2020 at 1:40 PM Yogesh Mahajan < yogesh.maha...@enterprisedb.com> wrote: > Hi, > > Please find a patch which fixes issues related to rule- 'Variables should > not be shadowed'. > > Thanks, > Yogesh Mahajan > QA - Team > EnterpriseDB Corporation > > Phone: +91

Re: [pgAdmin4][Patch] - SonarQube Fixes

2020-07-03 Thread Akshay Joshi
Thanks, patch applied. On Fri, Jul 3, 2020 at 1:12 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix the SonarQube Code smells having > Rule "*Functions, methods and lambdas should not have too many parameters* > ". > > In this patch, I ha

Reg - [RM-3814] Backup dialog does not show details of error if file name box kept empty

2020-07-03 Thread Satish V
Hi Hackers, Please find the patch in the attachment which resolves the issue of error messages not getting displayed in the dialog boxes of *backup, restore *and *import/export.* Kindly review the patch. Thanks, Sathish V RM3814vs1.patch Description: Binary data

Re: pgAdmin 4 commit: Added support for schema level restriction. Fixes #55

2020-07-03 Thread Murtuza Zabuawala
Hi Akshay, PFA patch to add the same changes for EPAS templates as well. -- Regards, Murtuza Zabuawala *EDB* *POWER TO POSTGRES* https://www.edbpostgres.com On Tue, Jun 30, 2020 at 7:16 PM Akshay Joshi wrote: > Added support for schema level restriction. Fixes #5583 > > Allow user to edit th

pgAdmin 4 commit: Modified EPAS templates to support schema restriction

2020-07-03 Thread Akshay Joshi
Modified EPAS templates to support schema restriction. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=cb1cdd1b23176e40b8cb6a491a840fd1f853e4c3 Author: Murtuza Zabuawala Modified Files -- .../databases/schemas/templates/schemas/pp

pgAdmin 4 commit: Fixed code smells having rule 'Functions, methods and

2020-07-03 Thread Akshay Joshi
Fixed code smells having rule 'Functions, methods and lambdas should not have too many parameters'. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0d920591552a21f918e0fbfe5a1a2519e4d118f1 Modified Files -- .../foreign_servers/use

Re: pgAdmin 4 commit: Added support for schema level restriction. Fixes #55

2020-07-03 Thread Akshay Joshi
Thanks, patch applied. On Fri, Jul 3, 2020 at 5:07 PM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Akshay, > > PFA patch to add the same changes for EPAS templates as well. > > > -- > Regards, > Murtuza Zabuawala > *EDB* > *POWER TO POSTGRES* > https://www.edbpostgres.com >

Re- SonarQube[Variables should not be shadowed]

2020-07-03 Thread Satish V
Hi Hackers, Please find the patch which fixes some of the sonar qube issues related to variable shadowing. Thanks, Sathish V variable_shadow1.patch Description: Binary data

[pgAdmin][RM5569] [SQL] Bad display of tables storage parameters in the "SQL" tab (correction of bug #5398 not complete)

2020-07-03 Thread Rahul Shirsat
Hi Hackers, Please find the attached patch which fixes the issue related to the partition table with storage parameters. -- *Rahul Shirsat* Software Engineer | EnterpriseDB Corporation. RM5569.patch Description: Binary data