pgAdmin 4 commit: Add proper indentation to the code while generating f

2020-06-29 Thread Akshay Joshi
Add proper indentation to the code while generating functions, procedures, and trigger functions. Fixes #3851 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7add777b21e09d5a5900fb05633b76b74419ea9d Author: Rahul Shirsat Modified Files -

Re: [pgAdmin][RM3851] Add proper indentation to the code when generating a stored procedure

2020-06-29 Thread Akshay Joshi
Thanks, patch applied. On Sun, Jun 28, 2020 at 9:46 PM Rahul Shirsat < rahul.shir...@enterprisedb.com> wrote: > Corrected some indentations. Find the patch below. > > On Sun, Jun 28, 2020 at 9:21 PM Rahul Shirsat < > rahul.shir...@enterprisedb.com> wrote: > >> Akshay, >> >> Ignore the above patch

pgAdmin 4 commit: Fixed an issue where panels get disappeared. Regressi

2020-06-29 Thread Akshay Joshi
Fixed an issue where panels get disappeared. Regression of SonarQube fix. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=102d6e7a9ae808cc8fd2238e0a1692ae754fecd2 Modified Files -- web/pgadmin/utils/menu.py | 10 +- 1 file c

Re: Support schema level restrictions and edit connection properties when already connected.

2020-06-29 Thread Akshay Joshi
Hi Nikhil Please fix below issues and resend the patch, I'll review once the following will be fixed: - Fix PEP8. - Fix linter errors. - Your patch introduces some new sonarqube issues. - The database dialog width is 700px which is too wide, it should be 600px - Add documentatio

[pgAdmin4][patch] trigger's when clause related fixes

2020-06-29 Thread Zhang, Jie
Hi, all [Incident] '()' appears twice in trigger's when clause?. [scenario 1] The step is as follow: 1) The SQL to create the trigger is as follows. - CREATE TRIGGER trigger1 BEFORE UPDATE ON public.tab1 FOR EACH ROW WHEN (new.a IS NOT

Patch for SonarQube code scan fixes

2020-06-29 Thread Nikhil Mohite
Hi Team, I have fixed some code smell issues in the SonarQube scan, PFA patch. Details as follows: 1. Sequences files: - Refactor this function to reduce its Cognitive Complexity from 33 to the 15 allowed. - Refactor this function to reduce its Cognitive Complexity from 16 to the 15 a

Re- [SonarQube][patch]- codesmell

2020-06-29 Thread Satish V
Hi Hackers, Please find the patch which fixes the code smell issues related to the rule "Variables should not be shadowed". Thanks, Sathish V Variables_should_not_be_shadowed.patch Description: Binary data