Re: Remove Python 2 support from the desktop runtime

2020-04-28 Thread Dave Page
Apparently, yes :-( On Mon, Apr 27, 2020 at 9:15 PM Ashesh Vashi wrote: > Did you forget to attach? > > — Ashesh > > On Mon, 27 Apr 2020 at 21:47, Dave Page wrote: > >> Patch for $SUBJECT attached. >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseD

[pgAdmin4][Patch] - RM 5422 - Synonym Dependencies tab shows incorrect data

2020-04-28 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the RM 5422 - Synonym Dependencies tab shows incorrect data. Thanks, Khushboo RM_5422.patch Description: Binary data

Re: [pgAdmin4][Patch] - RM 5422 - Synonym Dependencies tab shows incorrect data

2020-04-28 Thread navnath gadakh
Hi , I'm reviewing this task. On Wed, Apr 29, 2020 at 9:36 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix the RM 5422 - Synonym Dependencies > tab shows incorrect data. > > Thanks, > Khushboo > -- Regards, Navnath Gadakh

Re: Remove Python 2 support from the desktop runtime

2020-04-28 Thread Neel Patel
Hi Dave, I reviewed and tested and it looks good to me. Thanks, Neel Patel On Tue, Apr 28, 2020 at 1:32 PM Dave Page wrote: > Apparently, yes :-( > > On Mon, Apr 27, 2020 at 9:15 PM Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> Did you forget to attach? >> >> — Ashesh >> >> On Mo

Re: [pgAdmin4][Patch] - RM 5422 - Synonym Dependencies tab shows incorrect data

2020-04-28 Thread navnath gadakh
Hi Khushboo, Patch looks good to me except there are no API test cases written for dependents and dependencies. Thanks! On Wed, Apr 29, 2020 at 10:40 AM navnath gadakh < navnath.gad...@enterprisedb.com> wrote: > Hi , > > I'm reviewing this task. > > On Wed, Apr 29, 2020 at 9:36 AM Khushboo Va