Re: Translators: Release next week

hello in attachment french translation for upcoming relase bye Fred - Mail original - De: "Akshay Joshi" À: "pgadmin-hackers" Envoyé: Vendredi 24 Avril 2020 15:03:07 Objet: Translators: Release next week Hi Translators, We will have a release next week, so updates to tran

Re: [pgAdmin][RM4279] : Issue with File Browser Home button

Hi Yogesh, Just did an eyeball review. You've included homedir path in the response rendered JS file. You're exposing underlying directory structure to users even in server mode. This is not appropriate. This info should remain at the server and not at the client side. +homedir=os.path.exp

[pgAdmin4][Patch] - Improve LDAP Error messages

Hi, Please find the attached patch to improve the ldap error messages. Thanks, Khushboo ldap_error_messages.patch Description: Binary data

Re: Addition of support for base path in pgAdmin Web

Hi Aditya Can you please review it. On Sat, Apr 25, 2020 at 3:28 PM Eldhose M Joy wrote: > Hi, > > I have added a commit on 2 files to include a base path that would avoid > all the hassle while doing a reverse proxy on to the pgAdmin. Please find > the commits below. > > https://github.com/po

Re: [pgAdmin][RM4279] : Issue with File Browser Home button

Hi Aditya, Thanks for the feedback. Here is an updated patch, regarding the same. Please Review. PFA. On Mon, Apr 27, 2020 at 9:05 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Yogesh, > > Just did an eyeball review. You've included homedir path in the response > rendered

Re: [pgAdmin][RM4279] : Issue with File Browser Home button

Hi Hackers, I have tested this patch in linux (Ubuntu 18.04) env only , which is working fine. It will be great if someone can review/test in the Windows environment as well as I don't have the setup ready for that. On Mon, Apr 27, 2020 at 10:47 AM Yogesh Jain wrote: > Hi Aditya, > > Thanks for

Re: Addition of support for base path in pgAdmin Web

Hi Eldhose, The changes you've suggested are already implemented in pgAdmin ( https://github.com/postgres/pgadmin4/blob/master/web/pgAdmin4.py#L87). Almost all the servers provide the way to set the header - "X-Script-Name". pgAdmin uses X-Script-Name to set the prefix. You don't need to add any n

Re: [pgAdmin4][RM#5213] Fixed materialized view issue when user perform refresh on it

Hi Murtuza API test cases are not running, there is no error but all the tests are skipped. I have run it for EPAS/PG 9.5 to 12 where the binary path for EPAS is not set. I also found one issue where the proper error message is not shown if the binary path is not set in the Preferences dialog. I

Re: [pgAdmin][RM3787] Issue with Stop Process button

Hi Nagesh Your patch looks good to me, but it will not solve the issue that "Richard" has mentioned in the RM. What if terminating the process takes a long time? Please consider that and provide the proper solution. On Fri, Apr 24, 2020 at 7:12 PM Nagesh Dhope wrote: > Hi Hackers, > After the p

Re: [pgAdmin4][RM#5213] Fixed materialized view issue when user perform refresh on it

Thanks Akshay, flag not to run tests set to true when the check utility fails in-case if the binary path is not set, I will fix that issue as I did not consider more than one server scenario. On Mon, Apr 27, 2020 at 12:05 PM Akshay Joshi wrote: > Hi Murtuza > > API test cases are not running,