pgAdmin 4 commit: Fixed feature test.

2020-04-24 Thread Akshay Joshi
Fixed feature test. Pass the row height to the function instead of making the decision onthe basis of whether it is a new row or not. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6de1d3f7deb2bfc8c25ac5e385c1b8ab309e0442 Modified Files

[pgAdmin][RM4504] Make like options disable if Relation is not selected.

2020-04-24 Thread Pradip Parkale
Hi Hackers, Attached is a patch to make like options disable if Relation is not selected while creating a table. Please review. -- Thanks & Regards, Pradip Parkale QMG, EnterpriseDB Corporation RM4504.patch Description: Binary data

Re: [pgagent]: Modified 'next_schedule' function and updated pgagent 4.2 version

2020-04-24 Thread Dave Page
Hi On Thu, Apr 23, 2020 at 12:21 PM Neel Patel wrote: > Hi, > > Please find an updated patch that fixes a bug in 'next_schedule' function > where minute should be extracted instead of year for calculation. > > Issue found by: Vik Fearing > > Please find the attached patch that fixed the issue in

Re: [pgAdmin][RM1257] Ensure all object types have a "System XXX?" property

2020-04-24 Thread Aditya Toshniwal
Hi Hackers, Attached is the patch to fix: 1. For synonyms, the property is shown as "Public Synonym". 2. For system procedure, the flag should be True but it is displaying as False. 3. For both views and materialized views, the property is "System View". 4. For FTS templates, the property is showi

pgAgent commit: Fix a minor bug in pga_next_schedule, and bump the vers

2020-04-24 Thread Dave Page
Fix a minor bug in pga_next_schedule, and bump the version to 4.2.0. Discovery and fix by Vik Fearing. Patch by Neel Patel. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgagent.git;a=commitdiff;h=d36435fc8b410ab6eba4760c4ab2559716a8d860 Modified Files --

Re: [pgagent]: Modified 'next_schedule' function and updated pgagent 4.2 version

2020-04-24 Thread Dave Page
On Fri, Apr 24, 2020 at 10:23 AM Vik Fearing wrote: > > > On Fri, Apr 24, 2020 at 11:10 AM Dave Page wrote: > >> Hi >> >> On Thu, Apr 23, 2020 at 12:21 PM Neel Patel >> wrote: >> >>> Hi, >>> >>> Please find an updated patch that fixes a bug in 'next_schedule' >>> function where minute should be

Re: [pgagent]: Modified 'next_schedule' function and updated pgagent 4.2 version

2020-04-24 Thread Neel Patel
Hi Dave, On Fri, Apr 24, 2020 at 3:00 PM Dave Page wrote: > > > On Fri, Apr 24, 2020 at 10:23 AM Vik Fearing > wrote: > >> >> >> On Fri, Apr 24, 2020 at 11:10 AM Dave Page wrote: >> >>> Hi >>> >>> On Thu, Apr 23, 2020 at 12:21 PM Neel Patel >>> wrote: >>> Hi, Please find an upd

Re: [pgAdmin][RM4504] Make like options disable if Relation is not selected.

2020-04-24 Thread navnath gadakh
Hi, I will be reviewing this RM. On Fri, Apr 24, 2020 at 1:48 PM Pradip Parkale < pradip.park...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is a patch to make like options disable if Relation is not > selected while creating a table. > > Please review. > > -- > Thanks & Regards, > Prad

Re: [pgagent]: Modified 'next_schedule' function and updated pgagent 4.2 version

2020-04-24 Thread Vik Fearing
On Fri, Apr 24, 2020 at 11:10 AM Dave Page wrote: > Hi > > On Thu, Apr 23, 2020 at 12:21 PM Neel Patel > wrote: > >> Hi, >> >> Please find an updated patch that fixes a bug in 'next_schedule' function >> where minute should be extracted instead of year for calculation. >> >> Issue found by: Vik

Re: [pgAdmin][RM4504] Make like options disable if Relation is not selected.

2020-04-24 Thread navnath gadakh
Hi Pradip, Patch looks good to me except one minor issue - Create a table without selecting any relation then try to update table like options switch buttons are still enabled. On Fri, Apr 24, 2020 at 3:04 PM navnath gadakh < navnath.gad...@enterprisedb.com> wrote: > Hi, > I will be reviewi

Re: [pgAdmin][RM4504] Make like options disable if Relation is not selected.

2020-04-24 Thread Pradip Parkale
Hi Navnath, Please find the updated patch. On Fri, Apr 24, 2020 at 4:29 PM navnath gadakh < navnath.gad...@enterprisedb.com> wrote: > Hi Pradip, > Patch looks good to me except one minor issue - > Create a table without selecting any relation then try to update table > like options switch butt

pgAgent build warnings on Fedora 32

2020-04-24 Thread Devrim Gündüz
Hi, pgAgent throws the warnings below while compiling it on Fedora 32, which uses GCC 10. Can you please take a look? Thanks! Devrim === /usr/bin/make DESTDIR=/var/lib/pgsql/rpm12/BUILDROOT/pgagent_12-4.0.0-4.f32.x86_64 install In file included from /var/lib/pgsq

Re: pgAgent build warnings on Fedora 32

2020-04-24 Thread Neel Patel
I will look into it. On Fri, Apr 24, 2020 at 5:51 PM Devrim Gündüz wrote: > > Hi, > > pgAgent throws the warnings below while compiling it on Fedora 32, which > uses GCC 10. Can you please take a look? > > Thanks! Devrim > > === > /usr/bin/make > DESTDIR=/var/lib/pgs

Drop Python 2 support in pgAdmin?

2020-04-24 Thread Dave Page
Python 2 has been unsupported for a few months now. Does anyone object to dropping Python 2 support in pgAdmin? This primarily affects our Python package - other installers and packages all use Python 3 I believe. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK:

[pgAdmin4][RM#5213] Fixed materialized view issue when user perform refresh on it

2020-04-24 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue for materialized view when the user performs refresh on it, large size materialized view can take longer time to refresh the view hence we will run it same as we run maintenance commands and it will also allow the user to view the status of the refresh command. --

pgAdmin 4 commit: Update library inventory.

2020-04-24 Thread Akshay Joshi
Update library inventory. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0dcb448f2ed1f150ee478812b10b5be1a0fa5d8e Modified Files -- libraries.txt | 626 +- 1 file changed, 309

pgAdmin 4 commit: Update message catalogs.

2020-04-24 Thread Akshay Joshi
Update message catalogs. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ccafde604ef12777ed07755dac50b192027878d5 Modified Files -- web/pgadmin/messages.pot | 4226 +++--- .../translations/cs/LC_MES

pgAdmin 4 commit: Remove the 'Beta' word from the Dark Theme.

2020-04-24 Thread Akshay Joshi
Remove the 'Beta' word from the Dark Theme. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6642860d51e5f87d0fcdbdc901740b6409519fbe Modified Files -- web/webpack.config.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgAdmin 4 commit: Fixed an issue where like options should be disabled 

2020-04-24 Thread Akshay Joshi
Fixed an issue where like options should be disabled if the relation is not selected while creating a table. Fixes #4504 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ef58d277ca1ffcca270e2a39a3790cf6c9ca2e5a Author: Pradip Parkale Modified

pgAdmin 4 commit: Fixed following issues for 1257:

2020-04-24 Thread Akshay Joshi
Fixed following issues for 1257: 1. For synonyms, the property is shown as "Public Synonym". 2. For system procedure, the flag should be True but it is displaying as False. 3. For both views and materialized views, the property is "System View". 4. For FTS templates, the property is showing as

Re: [pgAdmin][RM4504] Make like options disable if Relation is not selected.

2020-04-24 Thread Akshay Joshi
Thanks, patch applied. On Fri, Apr 24, 2020 at 5:42 PM Pradip Parkale < pradip.park...@enterprisedb.com> wrote: > Hi Navnath, > > Please find the updated patch. > > On Fri, Apr 24, 2020 at 4:29 PM navnath gadakh < > navnath.gad...@enterprisedb.com> wrote: > >> Hi Pradip, >> Patch looks good to

Re: [pgAdmin][RM1257] Ensure all object types have a "System XXX?" property

2020-04-24 Thread Akshay Joshi
Thanks, patch applied. On Fri, Apr 24, 2020 at 2:56 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to fix: > 1. For synonyms, the property is shown as "Public Synonym". > 2. For system procedure, the flag should be True but it is displaying

Translators: Release next week

2020-04-24 Thread Akshay Joshi
Hi Translators, We will have a release next week, so updates to translations before release would be helpful. The template and catalogs have been updated in git. -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246

[pgAdmin][RM3787] Issue with Stop Process button

2020-04-24 Thread Nagesh Dhope
Hi Hackers, After the process is terminated, it's taking some time to return exit_code and our frontend code is waiting for exit_code to notify the user that the process is terminated by the user. Also *Stop Process *button is not getting disabled and which is misleading the user that nothing is ha

pgAdmin 4 commit: Ignore the pre-compiled resources.

2020-04-24 Thread Dave Page
Ignore the pre-compiled resources. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d5bfc726c06b6d82a97333676486885293044b02 Modified Files -- runtime/.gitignore | 1 + 1 file changed, 1 insertion(+)

[pgAdmin][RM4279] : Issue with File Browser Home button

2020-04-24 Thread Yogesh Jain
Hi Hackers, Attached is the patch to fix the issue with the file browser Home button. FYI : While clicking on the home button it was pointing to the user's root directory rather than home directory, which is fixed in this patch. Please review. PFA. -- Regards, Yogesh Jain 8982696654 diff --git

pgAdmin 4 commit: Cleanup build log output by removing unnecessary file

2020-04-24 Thread Dave Page
Cleanup build log output by removing unnecessary files in a nicer way. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=64a26b560b6cf6048919198a0d987eb8c7d4ae91 Modified Files -- pkg/mac/build.sh | 14 +++--- 1 file changed,

Re: Drop Python 2 support in pgAdmin?

2020-04-24 Thread Christoph Berg
Re: Dave Page 2020-04-24 > Python 2 has been unsupported for a few months now. > > Does anyone object to dropping Python 2 support in pgAdmin? This primarily > affects our Python package - other installers and packages all use Python 3 > I believe. I've always been using Python 3 only for the p

pgAdmin 4 commit: We support Python 3.8

2020-04-24 Thread Dave Page
We support Python 3.8 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b7dad25d3eb29fae05fef4f161dea644f080276f Modified Files -- pkg/pip/setup_pip.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

[pgAdmin][RM5430] : Adding title to login page

2020-04-24 Thread Yogesh Jain
Hi Hackers, Attached is the patch to Add app title to login page. Please review. PFA. -- Regards, Yogesh Jain 8982696654 diff --git a/web/pgadmin/templates/security/panel.html b/web/pgadmin/templates/security/panel.html index b93e2914f..46aa0524c 100644 --- a/web/pgadmin/templates/security/pane

Re: Drop Python 2 support in pgAdmin?

2020-04-24 Thread Darren Duncan
On 2020-04-24 5:50 a.m., Dave Page wrote: Python 2 has been unsupported for a few months now. Does anyone object to dropping Python 2 support in pgAdmin? This primarily affects our Python package - other installers and packages all use Python 3 I believe. I know that Apple at least is pushin