Re: [pgAdmin4][Patch] - RM 2186 - Support external authentication sources [LDAP]

Hi Khushboo Some more review comments: - Fix one small PEP8 issue. - If ipAddress or Port is not set in the configuration file then browser showing the following data, it should be shown proper error message on the login page - {"success":0,"errormsg":"Port could not be cast to

[Accessibility] Parse & validate the web pages

Hi Hackers, PFA the patch for fixing accessibility issues. Patch includes 1. Fix for search filter label missing in backgrid. 2. Fix for broken aria issue for objects menu. Please review and commit. Regards, Vishal pgadmin_diff.patch Description: Binary data

Re: [pgAdmin4][Patch] - RM 2186 - Support external authentication sources [LDAP]

Hi, Please find the attached updated patch. On Fri, Apr 3, 2020 at 1:50 PM Akshay Joshi wrote: > Hi Khushboo > > Some more review comments: > >- Fix one small PEP8 issue. > > Fixed. > >- If ipAddress or Port is not set in the configuration file then >browser showing the following d

pgAdmin 4 commit: Added support of Packages, Sequences and Synonyms to

Added support of Packages, Sequences and Synonyms to the Schema Diff. Fixes #5264 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ce89ae3c1d4125daa311916e59645abf47829ca1 Modified Files -- docs/en_US/release_notes_4_21.rst

pgAdmin 4 commit: Fixed some accessibility issues:

Fixed some accessibility issues: 1) Added missing search filter label in backgrid. 2) broken aria issue for objects menu. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=99a72e529b5e38f92c9f5d091dc599c86eb8cb98 Author: Vishal Sawale Modif

pgAdmin 4 commit: Replace the existing color picker - spectrum-colorpic

Replace the existing color picker - spectrum-colorpicker with @simonwep/pickr. spectrum-colorpicker has accessibility issues and is not maintained since long Part of #5197 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=824e3866d86cfcafef9394

Re: [Accessibility] Parse & validate the web pages

Thanks, patch applied. On Fri, Apr 3, 2020 at 2:37 PM Vishal Sawale wrote: > Hi Hackers, > > PFA the patch for fixing accessibility issues. Patch includes > >1. Fix for search filter label missing in backgrid. >2. Fix for broken aria issue for objects menu. > > Please review and commit.

Re: [pgAdmin][RM5197] Accessibility issues of external packages

Thanks, patch applied. On Thu, Apr 2, 2020 at 4:46 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached patch will replace the existing color picker - > spectrum-colorpicker with @simonwep/pickr. > spectrum-colorpicker has accessibility issues and is not main

[pgAdmin][RM4512] PgAgent Jobs: The Calendar is not opening properly on the Exception tab inside schedules tab

Hi Hackers, Attached is a small patch fixes the Calendar opening issue on the Exception tab inside the schedules tab. This is the only solution I found. The datetimepicker package does not provide any way to place the DOM in the body. The solution is will display the picker completely but you need

RM5351 - Cleanup compilation warnings

Patch attached for $SUBJECT. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM5351.patch Description: Binary data

pgAdmin 4 commit: Added an option to prevent a browser tab being opened

Added an option to prevent a browser tab being opened at startup. Fixes #5353 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4da327088c864aa406ca99561590557a2519fde5 Author: Dave Page Modified Files -- docs/en_US/desktop_deployme

pgAdmin 4 commit: Fixed RESQL test cases for Packages.

Fixed RESQL test cases for Packages. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=99e4c3350f1495f218dd51c40f4a4b3d2fcbef55 Modified Files -- .../packages/tests/ppas/10_plus/alter_package_headers_and_comment.sql| 1 + .../pack

pgAdmin 4 commit: Fixed compilation warnings while building pgAdmin. Fi

Fixed compilation warnings while building pgAdmin. Fixes #5351 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e26a9a25d510a38a6f7ffdfa92d3bc801f2f11c3 Author: Dave Page Modified Files -- docs/en_US/release_notes_4_21.rst | 3 ++-

Re: RM5351 - Cleanup compilation warnings

Thanks, patch applied. On Fri, Apr 3, 2020 at 6:25 PM Dave Page wrote: > Patch attached for $SUBJECT. > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- *Thanks & Regards* *Akshay

[PgAdmin][RM5275] Accessibilty :Tab navigation is not working for table>> parameters.

Hi Hackers, Please find an attached patch for key navigation in Table >> Parameter. I have added a key down event to handle the key navigation. -- Thanks & Regards, Pradip Parkale QMG, EnterpriseDB Corporation RM5275.patch Description: Binary data