Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme

Hi On Mon, Nov 11, 2019 at 7:01 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Dave, > > On Thu, Nov 7, 2019 at 7:56 PM Dave Page wrote: > >> >> >> On Thu, Nov 7, 2019 at 2:18 PM Dave Page wrote: >> >>> >>> On Thu, Nov 7, 2019 at 1:25 PM Akshay Joshi < >>> akshay.jo...@ent

Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme

Hi Dave, On Mon, Nov 11, 2019 at 2:38 PM Dave Page wrote: > Hi > > On Mon, Nov 11, 2019 at 7:01 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Dave, >> >> On Thu, Nov 7, 2019 at 7:56 PM Dave Page wrote: >> >>> >>> >>> On Thu, Nov 7, 2019 at 2:18 PM Dave Page wrote: >

Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme

Hi Hackers, Attached is the patch for further improvements in the Dark theme colors. Gray shades and other colors are changed to identify different components more clearly. Few of the controls were missing the privileges of dark theme, fixed that. Few dashboard graph related changes. As suggested,

Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme

Hi, Kindly hold on with the patch. Few more changes required per review by @Ashesh Vashi . On Mon, Nov 11, 2019 at 3:07 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch for further improvements in the Dark theme colors. > Gray shades and ot

pgAdmin 4 commit: Fixed API and RESQL test cases for Compound Trigger a

Fixed API and RESQL test cases for Compound Trigger after the recent changes in EPAS 12. EPAS 12 Changes: Fix server crash when the compound trigger has both row and statement-level triggers having WHEN clause containing NEW/OLD vars. Branch -- master Details --- https://git.post

Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme

Hi Hackers, Attached is the updated patch. Kindly review. On Mon, Nov 11, 2019 at 3:42 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > Kindly hold on with the patch. Few more changes required per review by @Ashesh > Vashi . > > On Mon, Nov 11, 2019 at 3:07 PM Aditya To

pgAdmin 4 commit: 1) Further styling tweaks for Dark Theme.

1) Further styling tweaks for Dark Theme. 2) Theme related code changes are removed from config.py and moved to miscellaneous under a new package - "themes". Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c1c682402aca0cbd8fc5aa6c70b0221fb7ff9

Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme

Thanks, patch applied. As per discussion with Aditya, we have removed customized scroll bars for the time being as they are not clearly visible with some of the components. On Mon, Nov 11, 2019 at 5:25 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is

pgAdmin 4 commit: Ensure compatibility with older versions of Sphinx.

Ensure compatibility with older versions of Sphinx. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=314990447cb6c8765093b05fd17914a2bc14b4fb Modified Files -- docs/en_US/theme/pgadmin4/layout.html | 206 +---

pgAdmin 4 commit: Support older versions of Sphinx

Support older versions of Sphinx Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=664d9a214473b0bdeb5764f50bcdadae08d1fb12 Modified Files -- docs/en_US/theme/pgadmin4/layout.html | 37 ++- 1 file chang

pgAdmin 4 commit: Remove extra whitespace.

Remove extra whitespace. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5b00ad03360d978596f6048aaccc5c856074e78b Modified Files -- docs/en_US/theme/pgadmin4/layout.html | 5 - 1 file changed, 5 deletions(-)

Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme

Hi That's looking a lot better. I see a couple of issues (screenshots attached): - The combo box on the query tool toolbar isn't dark. - The tagline on the dashboard logo isn't readable. A couple of other thoughts: - The guide lines on the graphs are still too bright. Let's make them the same c

Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme

Hi Dave, On Mon, Nov 11, 2019, 20:33 Dave Page wrote: > Hi > > That's looking a lot better. I see a couple of issues (screenshots > attached): > > - The combo box on the query tool toolbar isn't dark. > I'm not sure why you are not able to see it but I've changed it. Try a python restart. > - T

Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme

Hi On Mon, Nov 11, 2019 at 3:11 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Dave, > > On Mon, Nov 11, 2019, 20:33 Dave Page wrote: > >> Hi >> >> That's looking a lot better. I see a couple of issues (screenshots >> attached): >> >> - The combo box on the query tool toolb

pgAdmin 4 commit: Update version for release.

Update version for release. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8a03c42bd4071eb8f700ade52b841396ba0f6585 Modified Files -- runtime/Info.plist | 4 ++-- runtime/pgAdmin4.pro | 2 +- web/config.py| 4 ++-- 3 files

pgAdmin4 v4.15 candidate builds

Hi All, pgAdmin4 v4.15 candidate builds and source can be found at https://developer.pgadmin.org/builds/2019-11-12-1/ *Note*:- Windows build is failed I am looking into it. Fahar, can you please verify it for release on Thursday. -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *