[pgAdmin][RM4553] Query tool UX improvement

Hi Hackers, Attached is the patch to improve user experience when opening query tool. Previously, when the query tool button was clicked, the request went to backend, the connection was created and sent back to the UI. Until then, there was no activity on the UI. For slow servers it looked like pg

Re: [pgAdmin][RM4553] Query tool UX improvement

Forgot to mention, this patch also fixes https://redmine.postgresql.org/issues/4584 - HTML entities aren't escaped in database names On Thu, Aug 22, 2019 at 1:05 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to improve user experience when

[pgAdmin][RM4419] Debugger does not work on python 2.7

Hi Hackers, Attached is the patch to fix an issue where debugger throws error and doesn't work when using Python 2.7. Also fixed a small issue where reload warning was thrown on closing debugger, which should applicable only if opened in new tab. Kindly review. -- Thanks and Regards, Aditya Tos

Re: pgAdmin4 Feature Tests intermittent failures fix

Nice work! I have run the feature test couple of times on EPAS 9.6, 11, 12 and PG 9.4, 10, 11, 12. Following are the review comments: - Following test cases are failing every time on *EPAS 12:* - Explain query with JIT stats... fails with error "*no such element: Unable to locate e

Re: pgAdmin4 Feature Tests intermittent failures fix

Akshay, On Thu, Aug 22, 2019 at 2:29 PM Akshay Joshi wrote: > Nice work! > It's big patch, and also improvement over last status. Can we commit the patch, as to avoid any merging issues later? -- Thanks, Ashesh > > I have run the feature test couple of times on EPAS 9.6, 11, 12 and PG > 9.4, 1

Re: pgAdmin4 Feature Tests intermittent failures fix

On Thu, Aug 22, 2019 at 2:43 PM Akshay Joshi wrote: > > > On Thu, Aug 22, 2019 at 2:41 PM Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> Akshay, >> >> On Thu, Aug 22, 2019 at 2:29 PM Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Nice work! >>> >> It's big patch, and

pgAdmin 4 commit: Feature test improvement and fix intermittent failure

Feature test improvement and fix intermittent failures part of #3936 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9f455a514e317412b03b9b6adac55cd601284098 Author: Shubham Agarwal Modified Files -- web/pgadmin/feature_tests/brow

Re: pgAdmin 4 commit: Feature test improvement and fix intermittent failure

On Thu, Aug 22, 2019 at 3:07 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > I think Jenkins should be enabled for the feature tests. > Not now, it's not stable couple of tests are failing on EPAS/PG 12. > > On Thu, Aug 22, 2019 at 2:51 PM Akshay Joshi < > akshay.jo...@enterpris

Re: pgAdmin 4 commit: Feature test improvement and fix intermittent failure

I think Jenkins should be enabled for the feature tests. On Thu, Aug 22, 2019 at 2:51 PM Akshay Joshi wrote: > Feature test improvement and fix intermittent failures part of #3936 > > Branch > -- > master > > Details > --- > > https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff

Re: pgAdmin 4 commit: Feature test improvement and fix intermittent failure

On Thu, Aug 22, 2019 at 3:14 PM Akshay Joshi wrote: > > > On Thu, Aug 22, 2019 at 3:07 PM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> I think Jenkins should be enabled for the feature tests. >> > >Not now, it's not stable couple of tests are failing on EPAS/PG 12. > It may

Re: pgAdmin4 Feature Tests intermittent failures fix

Hi Akshay, Thanks for the overall review and comments. >From the logs and screenshot shared by you, it is cleared that the debugger plugin is not installed for PG12 server, hence resulting in the failures of "xss_checks_pgadmin_debugger_test.py" test case. Please install and re-execute the test ca

Re: pgAdmin4 Feature Tests intermittent failures fix

On Thu, Aug 22, 2019 at 11:26 AM Shubham Agarwal < shubham.agar...@enterprisedb.com> wrote: > Hi Akshay, > Thanks for the overall review and comments. > > From the logs and screenshot shared by you, it is cleared that the > debugger plugin is not installed for PG12 server, hence resulting in the >

Re: pgAdmin4 Feature Tests intermittent failures fix

On Thu, Aug 22, 2019 at 4:04 PM Dave Page wrote: > > > On Thu, Aug 22, 2019 at 11:26 AM Shubham Agarwal < > shubham.agar...@enterprisedb.com> wrote: > >> Hi Akshay, >> Thanks for the overall review and comments. >> >> From the logs and screenshot shared by you, it is cleared that the >> debugger

Re: pgAdmin4 Feature Tests intermittent failures fix

Yes, I agreed too. The only thinking was if the test case objective is to check the debugger, then it should fail instead of skipping it to come into direct notice. If the only test case for debugger gets skip, then the functionality will never be tested. On Thu, Aug 22, 2019 at 4:06 PM Ashesh Vas

Re: pgAdmin4 Feature Tests intermittent failures fix

On Thu, Aug 22, 2019 at 2:41 PM Ashesh Vashi wrote: > Akshay, > > On Thu, Aug 22, 2019 at 2:29 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Nice work! >> > It's big patch, and also improvement over last status. > Can we commit the patch, as to avoid any merging issues later? >

Re: pgAdmin4 v4.12 candidate builds

Hi Akshay, One round of sanity and detail(level 1) testing has been completed. Can we release pgadmin4 4.12 release? On Tue, Aug 20, 2019 at 11:23 AM Fahar Abbas wrote: > Thanks for sharing candidate builds and will update the testing status. > > Kind Regards, > > > > On Tue, Aug 20, 2019 at

Re: pgAdmin4 v4.12 candidate builds

Hi Fahar On Thu, Aug 22, 2019 at 5:19 PM Fahar Abbas wrote: > Hi Akshay, > > One round of sanity and detail(level 1) testing has been completed. > > Can we release pgadmin4 4.12 release? > You need to tell me whether it is ready to release or not :) > > > On Tue, Aug 20, 2019 at 11:23 AM Fa

Re: pgAdmin4 v4.12 candidate builds

lol It's ready for the release. On Thu, Aug 22, 2019 at 4:53 PM Akshay Joshi wrote: > Hi Fahar > > On Thu, Aug 22, 2019 at 5:19 PM Fahar Abbas > wrote: > >> Hi Akshay, >> >> One round of sanity and detail(level 1) testing has been completed. >> >> Can we release pgadmin4 4.12 release? >> > >

pgAdmin 4 v4.12 released

The pgAdmin Development Team are pleased to announce pgAdmin 4 version 4.12. This release of pgAdmin 4 includes over 38 bug fixes and new features. For more details please see the release notes at: https://www.pgadmin.org/docs/pgadmin4/dev/release_notes_4_12.html. pgAdmin is the leading Open

pgAdmin 4 commit: Minor doc styling tweaks.

Minor doc styling tweaks. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1795141aecfb3a57b9bd5fdfdd56e18ce069a5ba Modified Files -- docs/en_US/theme/pgadmin4/static/style.css | 12 1 file changed, 4 insertions(+), 8 de

pgAdmin 4 commit: Allow configuration options to be set from the enviro

Allow configuration options to be set from the environment in the container distribution. Fixes #4651 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c76b30e35310dbbb1d1e0706cab9af95ee39c148 Modified Files -- docs/en_US/config_py.

pgAdmin 4 commit: Improve formatting.

Improve formatting. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=92aabb215f91847bb6a417697b6eb6dfc3f03618 Modified Files -- docs/en_US/container_deployment.rst | 26 +- 1 file changed, 13 insertions(+), 13

pgAdmin 4 commit: Further tweaks for formatting.

Further tweaks for formatting. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6192c48ef95ef5ea47cc51ae6ee10ea47d1b0fdc Modified Files -- docs/en_US/container_deployment.rst | 10 +- 1 file changed, 5 insertions(+), 5 deleti

Re: Query Tool JS Minimal Refactoring

Please find an updated patch attached. On Mon, Aug 19, 2019 at 9:54 AM Yosry Muhammad wrote: > Jasmine tests passed on my machine, I will take another look once I have > access to my machine. > > On Mon, Aug 19, 2019, 7:57 AM Akshay Joshi > wrote: > >> Hi Yosry >> >> Jasmine tests are failing,

pgAdmin 4 commit: Fix SQL tab issue for Views. It's a regression of com

Fix SQL tab issue for Views. It's a regression of compound triggers. Fixes #4650 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=232fe286ee21126bd358544ba15db549791b56a4 Modified Files -- docs/en_US/release_notes_4_13.rst

Re: Query Tool JS Minimal Refactoring

Hi Yosry, This breaks the reconnect for query tool. Open a query tool, execute some query and then restart the python server. Go to the query tool and click execute. It will show a warning, on continuing it should connect again. It throws exception in browser console: Uncaught TypeError: Cannot re