[Patch]: RM-4644 - Length and Precision control for domain node

2019-08-21 Thread Neel Patel
Hi, Please find attached patch to fix RM-4644 - Length and Precision control should enable/disable based on change in data type. Do review it and let me know for comment. Thanks, Neel Patel RM-4644.patch Description: Binary data

RM 4463 - MSQL test cases for domain node

2019-08-21 Thread Neel Patel
Hi, Please find attached patch that will add more resql test cases and msql test cases for domain node. - Covered test cases for Length, Precision and Collation. - Also added msql test cases. While writing resql test cases for domain node, I found one more issue RM-4644

Re: RM 4463 - RESQL test cases for domain node

2019-08-21 Thread Neel Patel
Hi, Please find attached patch that will add more resql test cases for domain node. - Covered test cases for Length, Precision and Collation. - Also added msql test cases. While writing resql test cases for domain node, I found one more issue RM-4644

Re: [GSoC][New Feature] Editable and Read-only Columns

2019-08-21 Thread Dave Page
Aditya, can you review this please? Thanks. On Thu, Aug 15, 2019 at 8:01 PM Yosry Muhammad wrote: > Hi, hackers ! > > Please find attached a work-in-progress patch adding a new feature to the > Query Tool on top of updatable result-sets. > > This patch allows individual columns of an updatable

pgAdmin 4 commit: Add Reverse Engineered SQL tests for Rules. Fixes #46

2019-08-21 Thread Akshay Joshi
Add Reverse Engineered SQL tests for Rules. Fixes #4600 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=094e5577e8a6165a74f9ac4b375841e7b031e137 Modified Files -- docs/en_US/release_notes_4_13.rst | 1 + .../tests

pgAdmin 4 commit: Fix length and precision enable/disable issue when ch

2019-08-21 Thread Akshay Joshi
Fix length and precision enable/disable issue when changing the data type for Domain node. Fixes #4644. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=dc64ce331a731115ad7722eb878c9528af1af930 Author: Neel Patel Modified Files --

Re: [Patch]: RM-4644 - Length and Precision control for domain node

2019-08-21 Thread Akshay Joshi
Thanks patch applied. On Wed, Aug 21, 2019 at 12:49 PM Neel Patel wrote: > Hi, > > Please find attached patch to fix RM-4644 - Length and Precision control > should enable/disable based on change in data type. > > Do review it and let me know for comment. > > Thanks, > Neel Patel > -- *Thanks

Re: RM 4463 - RESQL test cases for domain node

2019-08-21 Thread Akshay Joshi
Hi Neel MSQL test case for *create* was not running before. In my last patch I have fixed that. Applying your patch on latest code not working can you please fix that and re-send the patch. On Wed, Aug 21, 2019 at 2:33 PM Neel Patel wrote: > Hi, > > Please find attached patch that will add more

pgAdmin 4 commit: Move schema precondition logic into separate function

2019-08-21 Thread Akshay Joshi
Move schema precondition logic into separate function for RE-SQL. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7090c02014e375193afac40f9e392443f920acd5 Modified Files -- web/regression/re_sql/tests/test_resql.py | 65 +++

Re: You've got to be kidding me... pgAdmin 4 forgets passwords even with a dedicated Firefox profile!

2019-08-21 Thread Avin Kavish
It's massively entertaining to watch you fail at this. Here are some alternative things that you can do to improve your productivity in general that will offset the productivity loses imposed on you by the master password. - type faster - buy a mechanical keyboard - improve your memory skills so th