pgAdmin 4 commit: Ensure the comment on a Primary Key constraint can be

2019-08-08 Thread Dave Page
Ensure the comment on a Primary Key constraint can be edited under the Table node. Fixes #4581 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c29275011a1ec78e61e28521402c794997c27148 Author: Khushboo Vashi Modified Files -- docs

Re: [pgAdmin4][Patch] - RM 4581 - Can not edit comments of primary key constraint under table node

2019-08-08 Thread Dave Page
Thanks, patch applied. On Thu, Aug 8, 2019 at 7:11 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix the RM #4581 - Can not edit > comments of primary key constraint under table node. > > Thanks, > Khushboo > > -- Dave Page Blog: http://

pgAdmin 4 commit: Fix PEP-8 issue.

2019-08-08 Thread Dave Page
Fix PEP-8 issue. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8331f62e1caa4a26653f5170690e560c9df61423 Modified Files -- .../browser/server_groups/servers/databases/schemas/tables/utils.py | 2 +- 1 file changed, 1 insertion(

Food For Thought

2019-08-08 Thread Avin Kavish
I think there are some lessons to be learnt here, maybe not to be applied immediately but sooner rather than later. https://slack.engineering/rebuilding-slack-on-the-desktop-308d6fe94ae4

[RM- 4575] RE_SQL for Schema

2019-08-08 Thread Vishal Sawale
Hi Hackers, PFA the patch for RE-SQL test cases for Schema node. Please review. Regards, Vishal Schema_4575.patch Description: Binary data

[pgAdmin][RM4582] pgAgent - In create job step changing "kind" (SQL/Batch) throws console error

2019-08-08 Thread Aditya Toshniwal
Hi Hackers, Attached is the patch to fix console error in create step under pgAgent. Code is changed to use bootstrapToggle instead of bootstrapSwitch. -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" RM4582.patch D

pgAdmin 4 commit: 1) Add support of Compound Triggers for EPAS 12+. Fix

2019-08-08 Thread Akshay Joshi
1) Add support of Compound Triggers for EPAS 12+. Fixes #4144. 2) Ensure enable trigger menu should be visible when trigger is disabled. Fixes #4578. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=350ffcce7c6ce7eb13f813f343944585aef23717 Mod

pgAdmin 4 commit: Fix console error when changing kind(SQL/BATCH) for p

2019-08-08 Thread Akshay Joshi
Fix console error when changing kind(SQL/BATCH) for pgAgent job step. Fixes #4582 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1281f5cd6cd5c6631c6e26bf1f04e78f25f2e975 Author: Aditya Toshniwal Modified Files -- docs/en_US/rele

Re: [pgAdmin][RM4582] pgAgent - In create job step changing "kind" (SQL/Batch) throws console error

2019-08-08 Thread Akshay Joshi
Thanks patch applied. On Thu, Aug 8, 2019 at 4:40 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to fix console error in create step under pgAgent. > Code is changed to use bootstrapToggle instead of bootstrapSwitch. > > -- > Thanks and Reg

[pgAdmin] Remove hard-source-webpack-plugin

2019-08-08 Thread Aditya Toshniwal
Hi Hackers, We do not need hard-source-webpack-plugin as webpack 4 is fast enough. It is creating more problems than solving and sometimes we have remove the generated directory to build correctly. Attached is the patch to remove it. In addition to this, I have also changed werkzeug logging level

Re: [RM- 4575] RE_SQL for Schema

2019-08-08 Thread Akshay Joshi
Hi Vishal Following are my review comments: - Test cases for Schemas are not executing at all, we need to change the logic. - test.json file is not aligned properly. - Don't specify the namespaceowner/grantee/grantor as a hardcoded value to 'enterprisedb'. - Don't specify the ha

pgAdmin 4 commit: Add support for OpenSSL 1.1.1 to the Windows installe

2019-08-08 Thread Dave Page
Add support for OpenSSL 1.1.1 to the Windows installer build. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7f667f5761e73de70befb8bedb5586cf6a988ec9 Modified Files -- Make.bat | 11 +-- 1 file changed, 9 insertions(+), 2 d

Creating control sliders

2019-08-08 Thread Yosry Muhammad
Hi hackers, I am working on a patch introducing improvements and new features to the query history. I would like to add a slider controller to show/hide queries generated by pgAdmin from the query history. These sliders are used in several places such as preferences, table dialogs, etc. Can someo

pgAdmin 4 commit: Set the Werkzeug logger to the same log level as the

2019-08-08 Thread Dave Page
Set the Werkzeug logger to the same log level as the rest of the app. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bfca1e3ac8ead03304aa533bdb6e250c0d22622a Author: Aditya Toshniwal Modified Files -- web/pgadmin/__init__.py | 2

pgAdmin 4 commit: Remove HardSourceWebpackPlugin as WebPack 4 is fast e

2019-08-08 Thread Dave Page
Remove HardSourceWebpackPlugin as WebPack 4 is fast enough and it causes more problems than it solves. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=99b51f8f20e534b8c79da69af5ea79627355c725 Author: Aditya Toshniwal Modified Files -

Re: [pgAdmin] Remove hard-source-webpack-plugin

2019-08-08 Thread Dave Page
Thanks, applied. On Thu, Aug 8, 2019 at 2:18 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > We do not need hard-source-webpack-plugin as webpack 4 is fast enough. It > is creating more problems than solving and sometimes we have remove the > generated directory

Query Tool - Cell Double Click Fix

2019-08-08 Thread Yosry Muhammad
Hi hackers, Please find attached a fix of a bug where users could not double click to expand the contents of a cell if the resultset was not editable. Please review. Thanks. -- *Yosry Muhammad Yosry* Computer Engineering student, The Faculty of Engineering, Cairo University (2021). Class repres

pgAdmin 4 commit: Fix double click issue to expand the contents of a ce

2019-08-08 Thread Akshay Joshi
Fix double click issue to expand the contents of a cell if the resultset was not editable. Fixes #4585 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b618dfe286146c3c8db73de834eda60e8a12d556 Author: Yosry Muhammad Modified Files ---

Re: Query Tool - Cell Double Click Fix

2019-08-08 Thread Akshay Joshi
Thanks patch applied. On Thu, Aug 8, 2019 at 9:18 PM Yosry Muhammad wrote: > Hi hackers, > > Please find attached a fix of a bug where users could not double click to > expand the contents of a cell if the resultset was not editable. > > Please review. > Thanks. > -- > *Yosry Muhammad Yosry* > >