pgAdmin 4 commit: Allow enhanced cookie protection to be disabled for c

Allow enhanced cookie protection to be disabled for compatibility with dynamically addressed hosting environments. Fixes #4566 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ee8fec6d7fbcfe529fa9b6e7dbf8e1fd95a71ba6 Author: Murtuza Zabuawala

[pgAdmin][RM4570] Tree improvement to improve speed of finding a node

Hi Hackers, Attached is a tiny but very effective patch to improve the speed of finding a node using path (used internally). If you right click or just click on a node, internally the node is traversed using its path. But currently, it compares with the path of all the open nodes to find a match.

pgAdmin 4 commit: Add a --modules option to the RE-SQL test suite to al

Add a --modules option to the RE-SQL test suite to allow testing of specific object types. Fixes #4560 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=db7a2e30234b078b1ed53084933cd2e9477a3882 Author: Aditya Toshniwal Modified Files -

Re: [pgAdmin][RM4560] Allow RE-SQL test cases to be run for a module using --modules

Thanks, applied. On Tue, Aug 6, 2019 at 5:56 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached patch will allow to RE-SQL to run for certain modules using a > command line flag --modules foo,bar. > Added the info to README. > > Kindly review. > > -- > Than

[pgAdmin][RM4554] RE-SQL for trigger functions

Hi Hackers, Attached is the patch to add RE-SQL test cases for trigger functions. I've also fixed few spacing issues here and there in SQLs generated. This patch also includes fix for https://redmine.postgresql.org/issues/4565 Kindly review. -- Thanks and Regards, Aditya Toshniwal Software Eng

pgAdmin 4 commit: Add an optimisation to the internal code responsible

Add an optimisation to the internal code responsible for searching for treeview nodes. Fixes #4570 Attached is a tiny but very effective patch to improve the speed of finding a node using path (used internally). If you right click or just click on a node, internally the node is traversed using it

Re: [pgAdmin][RM4570] Tree improvement to improve speed of finding a node

Thanks, patch applied. On Tue, Aug 6, 2019 at 1:10 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is a tiny but very effective patch to improve the speed of > finding a node using path (used internally). > If you right click or just click on a node, int

pgAdmin 4 commit: Add Reverse Engineered SQL tests for Trigger Function

Add Reverse Engineered SQL tests for Trigger Functions. Fixes #4554 Fix the reverse engineered SQL for trigger functions with the WINDOW option selected. Fixes #4565 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9cdb3b40abdf8270696ab5d05d535

Re: [pgAdmin][RM4554] RE-SQL for trigger functions

Thanks, applied. On Tue, Aug 6, 2019 at 1:57 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to add RE-SQL test cases for trigger functions. > I've also fixed few spacing issues here and there in SQLs generated. > > This patch also includes

pgAdmin 4 commit: Improve message wording.

Improve message wording. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bfb05d3f9f13a650f77f2a0010228168269d7080 Modified Files -- .../xss_checks_panels_and_query_tool_test.py | 16 1 file changed, 8 in

pgAdmin 4 commit: Further message tweak.

Further message tweak. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ee2099d9c61d693ee4c57fc9b762864954fe3e15 Modified Files -- web/pgadmin/feature_tests/xss_checks_panels_and_query_tool_test.py | 2 +- 1 file changed, 1 insertion

Re: [GSoC] Query History Integration with updatable query resultsets and improvements

Hi Seems to work well :-). A few comments: - Should we have an icon by the non-generated queries (the lightning flash) and the COMMITs etc (the commit/rollback icon as appropriate) as well? I think just having the icon for generated queries looks a little odd. - PEP-8 checks failed: pycodestyle

Re: [GSoC] Query History Integration with updatable query resultsets and improvements

Hi, On Tue, Aug 6, 2019, 6:01 PM Dave Page wrote: > Hi > > Seems to work well :-). A few comments: > > - Should we have an icon by the non-generated queries (the lightning > flash) and the COMMITs etc (the commit/rollback icon as appropriate) as > well? I think just having the icon for generated

Re: [GSoC] Query History Integration with updatable query resultsets and improvements

Hi, On Tue, Aug 6, 2019, 6:46 PM Yosry Muhammad wrote: > Hi, > > On Tue, Aug 6, 2019, 6:01 PM Dave Page wrote: > >> Hi >> >> Seems to work well :-). A few comments: >> >> - Should we have an icon by the non-generated queries (the lightning >> flash) and the COMMITs etc (the commit/rollback icon

Re: [pgAdmin][RM4554] RE-SQL for trigger functions

Hi Hackers, I've improved the output messages to add more detail for trigger functions RE-SQL test cases. Attached is the patch. On Tue, Aug 6, 2019 at 6:58 PM Dave Page wrote: > Thanks, applied. > > On Tue, Aug 6, 2019 at 1:57 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: >

New versions "What's new"

Hi Hackers, I have noticed a lot of users are unaware of new features or changes that are made from one version to another. Maybe a "What's new" pop up window can be added, showing when the user opens the app for the first time after an upgrade? Does something similar already exist? Thanks.

Re: New versions "What's new"

If this were github, I'd press the thumbs up button, but here is the next best thing. 👍 On Wed, Aug 7, 2019 at 11:35 AM Yosry Muhammad wrote: > Hi Hackers, > > I have noticed a lot of users are unaware of new features or changes that > are made from one version to another. > > Maybe a "What's ne

pgAdmin 4 commit: Revert the changes done by commit id - f8baa9e5620e25

Revert the changes done by commit id - f8baa9e5620e250329ce0ff45fcff802f31a1bbd (old commit from electron branch) which had overridden the changes made to electron2 branch. Branch -- electron2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3dedadb20acd97665c

Re: New versions "What's new"

Thanks, Avin ! On Wed, Aug 7, 2019, 8:09 AM Avin Kavish wrote: > If this were github, I'd press the thumbs up button, but here is the next > best thing. 👍 > > On Wed, Aug 7, 2019 at 11:35 AM Yosry Muhammad wrote: > >> Hi Hackers, >> >> I have noticed a lot of users are unaware of new features o