[pgAdmin4][Patch] - RM 4555 - RE-SQL for Exclusion Constraint

Hi, Please find the attached patch for the RE-SQL tests of the Exclusion constraint node with some bug fixes in SQL. Thanks, Khushboo RM_4555.patch Description: Binary data

pgAdmin 4 commit: Ensure triggers should be updated properly for EPAS s

Ensure triggers should be updated properly for EPAS server. Fixes #4559 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b5c8c85c90b369aff0c613db32cedfc3a9667516 Author: Aditya Toshniwal Modified Files -- docs/en_US/release_notes_4

Re: [pgAdmin][RM4559] Updating a trigger on EPAS server throws browser error

Thanks patch applied. On Mon, Aug 5, 2019 at 12:25 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to fix the issue where tree node path is not updated > for EPAS triggers when trigger OID changes. > > -- > Thanks and Regards, > Aditya Toshn

Re: [pgAdmin4][Patch] - RM 4555 - RE-SQL for Exclusion Constraint

Hi Khushboo Test case are working fine, some minor review comments: - Scenario name "Create/Alter Exclusion Constraint" repeating twice instead of that it should be more understandable. - File name should not be like "create/alter_exclusion_constraint_1.sql" it should be like 'alter_c

pgAdmin 4 commit: Update Chinese translation.

Update Chinese translation. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=efbad77dbe0298d2942e7ddc8eaf7bbd4d2899ca Author: Ma Yanhong Modified Files -- .../translations/zh/LC_MESSAGES/messages.mo| Bin 139372 -> 139465 by

Re: [pgAdmin4][Patch] - RM 4555 - RE-SQL for Exclusion Constraint

Hi Akshay, Please find the attached updated patch. On Mon, Aug 5, 2019 at 1:20 PM Akshay Joshi wrote: > Hi Khushboo > > Test case are working fine, some minor review comments: > >- Scenario name "Create/Alter Exclusion Constraint" repeating twice >instead of that it should be more under

pgAdmin 4 commit: Add Reverse Engineered SQL tests for Exclusion Constr

Add Reverse Engineered SQL tests for Exclusion Constraint. Fixes #4555 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f8afe2ef940be607e8b6e87b62875b17e1b0c2c2 Author: Khushboo Vashi Modified Files -- docs/en_US/release_notes_4_12

Re: [pgAdmin4][Patch] - RM 4555 - RE-SQL for Exclusion Constraint

Thanks patch applied. On Mon, Aug 5, 2019 at 2:00 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Akshay, > > Please find the attached updated patch. > > On Mon, Aug 5, 2019 at 1:20 PM Akshay Joshi > wrote: > >> Hi Khushboo >> >> Test case are working fine, some minor review com

JavaScript Errors in the Query Tool Leads to a False Message

Hi Hackers, I have noticed a strange behavior in the JS code of the Query Tool. When a JS error occurs at any point during the execution of a query, the code is traced back to the last ajax call and goes to the catch portion (as if the ajax call failed). This leads to a "Not connected to the serve

[GSoC] Query History Integration with updatable query resultsets and improvements

Hi Dave and Hackers, Please find attached a work-in-progress patch with the following modifications to the query history: 1- Queries generated by pgAdmin in Save Data operations are now recorded in query history. This includes transaction control commands such as 'COMMIT, ROLLBACK, SAVEPOINT, etc

Re: JavaScript Errors in the Query Tool Leads to a False Message

Is there a way to reproduce this? i.e force a js error during query execution? One reason I can think of is using $.ajax({ async: false }) so the ajax request gets handled on the main thread and anything that throws on to the main thread gets caught. On Tue, Aug 6, 2019 at 4:07 AM Yosry Muhammad

Re: JavaScript Errors in the Query Tool Leads to a False Message

Hi Yosry, Yes, I have experienced the same but missed to log a bug. You can log a bug so that someone can work on it. To simulate the issue, just add some JS code that will cause error. On Tue, Aug 6, 2019 at 10:06 AM Avin Kavish wrote: > Is there a way to reproduce this? i.e force a js error d

Re: JavaScript Errors in the Query Tool Leads to a False Message

Yes, if you undo this commit: https://redmine.postgresql.org/projects/pgadmin4/repository/revisions/97e39699ead1005a4a5ef8e986d980df8f743db9 This was a fix of a bug that occurred when querying a table with no columns. It displayed the same error mentioned in the original email and was due to a JS

Re: JavaScript Errors in the Query Tool Leads to a False Message

On Tue, Aug 6, 2019, 6:42 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Yosry, > > Yes, I have experienced the same but missed to log a bug. You can log a > bug so that someone can work on it. > To simulate the issue, just add some JS code that will cause error. > >> >> Will

[pgAdmin][RM4560] Allow RE-SQL test cases to be run for a module using --modules

Hi Hackers, Attached patch will allow to RE-SQL to run for certain modules using a command line flag --modules foo,bar. Added the info to README. Kindly review. -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" RM45