[pgAdmin4][Patch]: Fix for Feature #4334, RM #4496 and #4497

Hi Hackers, I have added the support of Generated Columns (PG/EPAS 12) and also fixed RM #4496, #4497. During the implementation of that I have also fixed following issues that I encountered: - User should not be able to provide Default value with Identity column. - 'Drop Cascade' button t

Re: pgAdmin4 v4.11 candidate builds

Hi, On Wed, 2019-07-24 at 10:48 +0530, Akshay Joshi wrote: >Feature test are not stable yet, so we will have to remove that from our > build process. How? Will you re-wrap 4.11? If not, can you please send me a patch so that I can apply it to the RPMs? Thanks! Cheers, -- Devrim Gündüz Ope

Re: pgAdmin4 v4.11 candidate builds

Hi Devrim On Wed, Jul 24, 2019 at 1:02 PM Devrim Gündüz wrote: > > Hi, > > On Wed, 2019-07-24 at 10:48 +0530, Akshay Joshi wrote: > >Feature test are not stable yet, so we will have to remove that from > our > > build process. > > How? Will you re-wrap 4.11? If not, can you please send me a

Re: pgAdmin4 v4.11 candidate builds

On Wed, Jul 24, 2019 at 8:39 AM Akshay Joshi wrote: > Hi Devrim > > On Wed, Jul 24, 2019 at 1:02 PM Devrim Gündüz wrote: > >> >> Hi, >> >> On Wed, 2019-07-24 at 10:48 +0530, Akshay Joshi wrote: >> >Feature test are not stable yet, so we will have to remove that from >> our >> > build process

Re: pgAdmin4 v4.11 candidate builds

On Tue, Jul 23, 2019 at 10:41 PM Devrim Gündüz wrote: > > Hi Ashesh, > > On Tue, 2019-07-23 at 21:58 +0530, Ashesh Vashi wrote: > > Because - pgAdmin4 has its own documentation theme. :-) > > Thanks, but this does not answer my question. This theme (like the previous > "classic" theme) breaks RHE

Re: pgAdmin4 v4.11 candidate builds

Hi Akshay, On Wed, 2019-07-24 at 13:08 +0530, Akshay Joshi wrote: >No, I'll not re-wrap 4.11. I am not much aware of the RPM's, but I think > you will need to change the spec file and add "--exclude > feature_tests" > parameter to the command for regression test. I don't run regression tests

Re: pgAdmin4 v4.11 candidate builds

Hi Devrim We have figure out the problem with the syntax print("Copy rows...", file=sys.stderr, end="") with Python 2.7. Attached is the patch please apply, test it and let me know. On Wed, Jul 24, 2019 at 1:25 PM Devrim Gündüz wrote: > > Hi Akshay, > > On Wed, 2019-07-24 at 13:08 +0530, Akshay

[RM#4508] Fix tab navigation issue with Backgrid Datetime cell

Hi, PFA minor patch to fix the tab navigation issue with Backgrid datetime cell. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company fix_datetime_backgrid.diff Description: Binary data

Re: pgAdmin4 v4.11 candidate builds

Hi Akshay, On Wed, 2019-07-24 at 14:45 +0530, Akshay Joshi wrote: > We have figure out the problem with the syntax print("Copy rows...", > file=sys.stderr, end="") with Python 2.7. > Attached is the patch please apply, test it and let me know. Great, it worked! Will this patch be included in 4.

Re: pgAdmin4 v4.11 candidate builds

On Wed, 24 Jul, 2019, 19:26 Devrim Gündüz, wrote: > > Hi Akshay, > > On Wed, 2019-07-24 at 14:45 +0530, Akshay Joshi wrote: > > We have figure out the problem with the syntax print("Copy rows...", > > file=sys.stderr, end="") with Python 2.7. > > Attached is the patch please apply, test it and le

Re: pgAdmin4 v4.11 candidate builds

On Wed, Jul 24, 2019 at 3:10 PM Akshay Joshi wrote: > > > On Wed, 24 Jul, 2019, 19:26 Devrim Gündüz, wrote: > >> >> Hi Akshay, >> >> On Wed, 2019-07-24 at 14:45 +0530, Akshay Joshi wrote: >> > We have figure out the problem with the syntax print("Copy rows...", >> > file=sys.stderr, end="") with

pgAdmin 4 commit: Remove duplicated blank message entry which is illega

Remove duplicated blank message entry which is illegal. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ec968dbc14a6c6baef90c3ca1d38f89b40fa319d Modified Files -- web/pgadmin/translations/ja/LC_MESSAGES/messages.po | 3 --- 1 file c

pgAdmin 4 commit: Fix syntax error in query tool feature test for Pytho

Fix syntax error in query tool feature test for Python 2.7 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8cfe39e8371a6255b23b35c281e6d86f1a6e4ef4 Modified Files -- web/pgadmin/feature_tests/query_tool_journey_test.py | 1 + 1 file