Re: [GSoC] Finalized First Patch

Some points I missed: 1. I assumed that in this patch modification in case of OIDs= True (without primary key) has not considered as that is not working. 2. As we are already showing the changed Data prompt on closing the Query Tool, do we really need the Uncommitted Transaction prompt? On Wed, J

Re: [GSoC] Finalized First Patch

Hi Khushboo, On Wed, Jul 10, 2019, 8:33 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Yosry, > > I liked the way you have refactored the code at some places in the JS file > and made it cleaner. > Thanks ! I am doing my best. Here are some points: > > 1. The table (including

Re: [GSoC] Finalized First Patch

Hi, On Wed, Jul 10, 2019, 9:14 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Some points I missed: > 1. I assumed that in this patch modification in case of OIDs= True > (without primary key) has not considered as that is not working. > This is not implemented yet. I will work o

[pgAdmin4][Patch]: RM 4452 Add RE-SQL tests for Languages

Hi Hackers, Attached is the patch to fix RM #4452 "Add RE-SQL tests for Languages". Please review it. -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* RM_4452.patch Description: Binary data

pgAdmin 4 commit: Add documentation on using Traefik with pgAdmin mount

Add documentation on using Traefik with pgAdmin mounted under a subdirectory, and tidy up the reverse proxying docs a little. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=49503dc73d4f8eb4859683d63fca2542888073ca Modified Files

pgAdmin 4 commit: Added re_sql test cases for privileges in Foreign Dat

Added re_sql test cases for privileges in Foreign Data Wrappers Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6c7e95a4638e2db631a20626f1565ace2e60c0cd Modified Files -- .../foreign_data_wrappers/sql/9.3_plus/acl.sql | 1 + ..

RE-SQL tests patch for packages node

Hi Dave, I have attached the patch for RE-SQL test cases for *Packages* node. Thanks! -- *Regards,* *Navnath Gadakh* re_sql_packages_tests_v1.patch Description: Binary data

Re: [GSoC] Finalized First Patch

Hi Yosry, On Thu, Jul 11, 2019 at 4:10 AM Yosry Muhammad wrote: > Hi, > Please find an updated patch attached. > > On Wed, Jul 10, 2019 at 8:33 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi Yosry, >> >> I liked the way you have refactored the code at some places in the JS

Re: [GSoC] Finalized First Patch

Hi, On Wed, Jul 10, 2019 at 3:11 PM Yosry Muhammad wrote: > Hi, > > On Wed, Jul 10, 2019, 9:14 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Some points I missed: >> 1. I assumed that in this patch modification in case of OIDs= True >> (without primary key) has not consider