pgAdmin 4 commit: Update Chinese translation.

2019-06-25 Thread Dave Page
Update Chinese translation. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c69ffaa91c6729b1dc2ef95d67cc35c6a32b3cb8 Author: Ma Yanhong Modified Files -- .../translations/zh/LC_MESSAGES/messages.mo| Bin 138295 -> 138274 by

pgAdmin 4 commit: Fix SSH tunnel password decryption. Fixes #4320

2019-06-25 Thread Dave Page
Fix SSH tunnel password decryption. Fixes #4320 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0d42f8026c4cd4aec4fd2a7de04256c2ba0d7a71 Author: Aditya Toshniwal Modified Files -- web/pgadmin/utils/driver/psycopg2/server_manager.p

Re: [pgAdmin][RM4320] PgAdmin 4 fails to accept ssh password

2019-06-25 Thread Dave Page
Thanks, committed. On Tue, Jun 25, 2019 at 2:00 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Based on the latest comments on the RM, > https://redmine.postgresql.org/issues/4320#change-16998 - Replaced > server_manager.py on my Win 10 system - could login and

Re: [GSoC][Patch] Automatic Mode Detection V1

2019-06-25 Thread Aditya Toshniwal
Hi, On Mon, Jun 24, 2019 at 10:13 PM Yosry Muhammad wrote: > Hi, > > Please find attached a patch file with the following updates (last patch + > updates) attached: > - Changed the color to $color-gray-lighter and added the shortcut for the > new button. > - Added a preferences option to enable/

Re: [GSoC][Patch] Automatic Mode Detection V1

2019-06-25 Thread Dave Page
Hi On Mon, Jun 24, 2019 at 7:03 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > > - What else is missing from this patch to make it applicable ? I would >> like to produce a release-ready patch if possible. If so, I can continue >> working on the project on following patches, I

Re: [GSoC][Patch] Automatic Mode Detection V1

2019-06-25 Thread Dave Page
On Tue, Jun 25, 2019 at 7:09 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > On Mon, Jun 24, 2019 at 10:13 PM Yosry Muhammad > wrote: > >> Hi, >> >> Please find attached a patch file with the following updates (last patch >> + updates) attached: >> - Changed the color to

Re: [GSoC][Patch] Automatic Mode Detection V1

2019-06-25 Thread Aditya Toshniwal
Hi, On Tue, Jun 25, 2019 at 4:41 PM Dave Page wrote: > > > On Tue, Jun 25, 2019 at 7:09 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi, >> >> On Mon, Jun 24, 2019 at 10:13 PM Yosry Muhammad >> wrote: >> >>> Hi, >>> >>> Please find attached a patch file with the follow

Re: [GSoC][Patch] Automatic Mode Detection V1

2019-06-25 Thread Yosry Muhammad
Hi, OK. Yosry, How about storing the mogirfied query in the cookie/session when > the query is executed and then modifying query history storing logic to use > it when called ? This way you will not need to change any parsing when > query history is displayed. > >> -- >> > My problem is not where

Re: [GSoC][Patch] Automatic Mode Detection V1

2019-06-25 Thread Yosry Muhammad
On Tue, Jun 25, 2019 at 1:09 PM Dave Page wrote: > > - What else is missing from this patch to make it applicable ? I would >>> like to produce a release-ready patch if possible. If so, I can continue >>> working on the project on following patches, I just want to know what is >>> the minimum amo

Re: [GSoC][Patch] Automatic Mode Detection V1

2019-06-25 Thread Aditya Toshniwal
Hi Yosry, On Tue, Jun 25, 2019 at 8:46 PM Yosry Muhammad wrote: > Hi, > > > OK. Yosry, How about storing the mogirfied query in the cookie/session >> when the query is executed and then modifying query history storing logic >> to use it when called ? This way you will not need to change any pars

[pgAdmin][RM4139] Drag and drop object names in Query Editor from Browser Tree

2019-06-25 Thread Aditya Toshniwal
Hi Hackers, Attached is the patch to allow tree nodes to be dragged and dropped in query editor wherever you take the drop cursor. The drop text will be fully qualified and double quoted if required. For functions/procedures it will drop the the label stripping away the parameter names, with empty