[pgAdmin4][RM3587] Browser rendering of a bigint in a jsonb is wrong

2019-02-26 Thread Aditya Toshniwal
Hi Hackers, Attached is the patch to fix incorrect rendering of bigint in jsonb. The problem is in javascript limitations with big numbers. For fixing, jsonb data will be fetched as string now, similar to json, so that JS will not consider big numbers as number. The only drawback here is that, the

[pgAdmin4][Patch] - Encoding Fixes

2019-02-26 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the encoding related issues. #3992 - View data causes errors with DB encoding EUC_JIS_2004 #3982 - Encoding Problem with PGAdmin 4.2 #3911 - Data output does not display Arabic in WIN1256 encoding database - The CSV download for the same encoding has also

pgAdmin 4 commit: Support double-click on Query Tool result grid column

2019-02-26 Thread Dave Page
Support double-click on Query Tool result grid column resize handles to auto-size to the content. Fixes #4034 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9c5b9364b619c148b2542ac9ab907eb90247d4f8 Author: Aditya Toshniwal Modified Files --

Re: [pgAdmin4][RM4034] Auto resize column when double clicked on column resizer is SQL data output grid

2019-02-26 Thread Dave Page
Thanks - applied! On Mon, Feb 25, 2019 at 10:58 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to Auto resize column when double clicked on column > resizer is SQL data output grid. > > Kindly review. > > -- > Thanks and Regards, > Aditya T

Re: [pgAdmin4][RM3587] Browser rendering of a bigint in a jsonb is wrong

2019-02-26 Thread Dave Page
Hi On Tue, Feb 26, 2019 at 8:55 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to fix incorrect rendering of bigint in jsonb. > The problem is in javascript limitations with big numbers. For fixing, > jsonb data will be fetched as string no

Re: [pgAdmin4][RM3587] Browser rendering of a bigint in a jsonb is wrong

2019-02-26 Thread Aditya Toshniwal
Hi, On Tue, Feb 26, 2019 at 8:04 PM Dave Page wrote: > Hi > > On Tue, Feb 26, 2019 at 8:55 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch to fix incorrect rendering of bigint in jsonb. >> The problem is in javascript limitations wit

Re: Result grid rendering (was: Re: [pgAdmin4][Pattch] - RM #3673 - "Download as .csv" F8 does NOT work when one of joined files is a TEMPORARY file)

2019-02-26 Thread Khushboo Vashi
Hi Dave, Please find the attached fix. I have added the configurable option to add the extra classes in the panel.js, so in the future, we can utilize it if required. Here, I have added a class to hide the extra vertical scrollbar to the Datagrid panel. Thanks, Khushboo On Tue, Feb 26, 2019 at

Re: [pgAdmin4][RM3587] Browser rendering of a bigint in a jsonb is wrong

2019-02-26 Thread Aditya Toshniwal
Hi Hackers, Attached is the updated patch. As mentioned earlier, jsonb will be fetched as text. Only when the pop up editor opens, json-bignumber parser will be used to prettify. Kindly review. On Wed, Feb 27, 2019 at 10:12 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, >

[pgAdmin4][Patch]: RM #3933 Error dropping database pop up message displayed if user try to drop any database with Arabic character with non super user

2019-02-26 Thread Akshay Joshi
Hi Hackers, Attached is the patch to fix RM #3933 "Error dropping database pop up message displayed if user try to drop any database with Arabic character with non super user". There is an exception in the logging system for Arabic characters. I have read https://docs.python.org/2/library/logging