Re: [pgAdmin4][Pattch] - RM #3673 - "Download as .csv" F8 does NOT work when one of joined files is a TEMPORARY file

2019-02-18 Thread Khushboo Vashi
On Thu, Feb 14, 2019 at 4:12 PM Dave Page wrote: > Hi > > On Thu, Feb 14, 2019 at 6:56 AM Khushboo Vashi > wrote: > > > > Hi, > > > > Please find the attached patch to fix the RM #3673 - "Download as .csv" > F8 does NOT work when one of joined files is a TEMPORARY file > > > > To fix this issue,

Re: [pgAdmin4][Pattch] - RM #3673 - "Download as .csv" F8 does NOT work when one of joined files is a TEMPORARY file

2019-02-18 Thread Dave Page
On Mon, Feb 18, 2019 at 9:08 AM Khushboo Vashi wrote: > > > > On Thu, Feb 14, 2019 at 4:12 PM Dave Page wrote: >> >> Hi >> >> On Thu, Feb 14, 2019 at 6:56 AM Khushboo Vashi >> wrote: >> > >> > Hi, >> > >> > Please find the attached patch to fix the RM #3673 - "Download as .csv" F8 >> > does NOT

Re: [pgAdmin4][Pattch] - RM #3673 - "Download as .csv" F8 does NOT work when one of joined files is a TEMPORARY file

2019-02-18 Thread Khushboo Vashi
On Mon, Feb 18, 2019 at 3:08 PM Dave Page wrote: > On Mon, Feb 18, 2019 at 9:08 AM Khushboo Vashi > wrote: > > > > > > > > On Thu, Feb 14, 2019 at 4:12 PM Dave Page wrote: > >> > >> Hi > >> > >> On Thu, Feb 14, 2019 at 6:56 AM Khushboo Vashi > >> wrote: > >> > > >> > Hi, > >> > > >> > Please f

Re: [pgAdmin4][Pattch] - RM #3673 - "Download as .csv" F8 does NOT work when one of joined files is a TEMPORARY file

2019-02-18 Thread Dave Page
On Mon, Feb 18, 2019 at 10:51 AM Khushboo Vashi wrote: > > > > On Mon, Feb 18, 2019 at 3:08 PM Dave Page wrote: >> >> On Mon, Feb 18, 2019 at 9:08 AM Khushboo Vashi >> wrote: >> > >> > >> > >> > On Thu, Feb 14, 2019 at 4:12 PM Dave Page wrote: >> >> >> >> Hi >> >> >> >> On Thu, Feb 14, 2019 at

pgAdmin 4 commit: Fix treeview state saving after reset.

2019-02-18 Thread Dave Page
Fix treeview state saving after reset. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=554455fa75eea7794bdd826c4d080c7916d0a8d5 Author: Khushboo Vashi Modified Files -- web/pgadmin/static/js/tree/pgadmin_tree_save_state.js | 2 +-

pgAdmin 4 commit: Set the background colour for backform notes, and add

2019-02-18 Thread Dave Page
Set the background colour for backform notes, and add an icon. Fixes #3948 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e2482d2294434d0ece4e4787a58add9f8f343441 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/static/js/

Build failed in Jenkins: pgadmin4-master-python37 #174

2019-02-18 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Set the background colour for backform notes, and add an icon. Fixes -- [...truncated 960.13 KB...]

pgAdmin 4 commit: Fix paste issue during commit :-s

2019-02-18 Thread Dave Page
Fix paste issue during commit :-s Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=841af6868d0972894d8871521e90af1be874848c Modified Files -- web/pgadmin/tools/backup/static/js/backup.js | 2 +- 1 file changed, 1 insertion(+), 1 dele

Build failed in Jenkins: pgadmin4-master-python27 #943

2019-02-18 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Set the background colour for backform notes, and add an icon. Fixes -- [...truncated 962.31 KB...]

Jenkins build is back to normal : pgadmin4-master-python37 #175

2019-02-18 Thread pgAdmin 4 Jenkins
See

Jenkins build is back to normal : pgadmin4-master-python27 #944

2019-02-18 Thread pgAdmin 4 Jenkins
See

[Patch]: Minor change in dependency_inventory file to generate library file

2019-02-18 Thread Neel Patel
Hi, Please find attached patch to handle JSON object properly to avoid error like "the JSON object must be str, not 'bytes'" while generating library.txt file. Verified with both python2 and python3. Do review it and let me know for comments. Thanks, Neel Patel --

Re: [pgAdmin4][Pattch] - RM #3673 - "Download as .csv" F8 does NOT work when one of joined files is a TEMPORARY file

2019-02-18 Thread Khushboo Vashi
Hi Dave, On Mon, Feb 18, 2019 at 4:49 PM Dave Page wrote: > On Mon, Feb 18, 2019 at 10:51 AM Khushboo Vashi > wrote: > > > > > > > > On Mon, Feb 18, 2019 at 3:08 PM Dave Page wrote: > >> > >> On Mon, Feb 18, 2019 at 9:08 AM Khushboo Vashi > >> wrote: > >> > > >> > > >> > > >> > On Thu, Feb 14

[pgAdmin4][Patch]: RM #3958 Query Tool commits after SELECT statements regardless of 'Auto commit' setting

2019-02-18 Thread Akshay Joshi
Hi Hackers, Attached is the patch to fix RM "#3958 Query Tool commits after SELECT statements regardless of 'Auto commit' setting." Please review it. -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* --