Re: RM2233 - Scratch pad

2019-02-15 Thread Khushboo Vashi
Hi Dave, On Thu, Feb 14, 2019 at 8:14 PM Dave Page wrote: > Here's a draft patch for adding a scratch pad to the Query Tool, > similar to what we had in pgAdmin 3. > > Aside from regular review, can one of our CSS gurus (I'm looking at > you Aditya and Khushboo :-) ) help with the following ques

Re: RM2233 - Scratch pad

2019-02-15 Thread Dave Page
Hi On Fri, Feb 15, 2019 at 11:53 AM Khushboo Vashi wrote: > > Hi Dave, > > On Thu, Feb 14, 2019 at 8:14 PM Dave Page wrote: >> >> Here's a draft patch for adding a scratch pad to the Query Tool, >> similar to what we had in pgAdmin 3. >> >> Aside from regular review, can one of our CSS gurus (I'

Re: RM2233 - Scratch pad

2019-02-15 Thread Khushboo Vashi
On Fri, Feb 15, 2019 at 6:35 PM Dave Page wrote: > Hi > > On Fri, Feb 15, 2019 at 11:53 AM Khushboo Vashi > wrote: > > > > Hi Dave, > > > > On Thu, Feb 14, 2019 at 8:14 PM Dave Page wrote: > >> > >> Here's a draft patch for adding a scratch pad to the Query Tool, > >> similar to what we had in

pgAdmin 4 commit: Make the Query Tool tab titles more concise and usefu

2019-02-15 Thread Dave Page
Make the Query Tool tab titles more concise and useful. Fixes #3544 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c64373435b73ad0a37a15e677bbc4d8f69874155 Modified Files -- docs/en_US/release_notes_4_3.rst | 1

Re: RM2233 - Scratch pad

2019-02-15 Thread Dave Page
On Fri, Feb 15, 2019 at 1:29 PM Khushboo Vashi wrote: > > > > On Fri, Feb 15, 2019 at 6:35 PM Dave Page wrote: >> >> Hi >> >> On Fri, Feb 15, 2019 at 11:53 AM Khushboo Vashi >> wrote: >> > >> > Hi Dave, >> > >> > On Thu, Feb 14, 2019 at 8:14 PM Dave Page wrote: >> >> >> >> Here's a draft patch

Re: RM2233 - Scratch pad

2019-02-15 Thread Dave Page
Hi On Fri, Feb 15, 2019 at 1:53 PM Akshay Joshi wrote: > Hi Dave > > Following are my review comments: > >- When query is running then user should be able to work on Scratch >pad. > > That's a whole other issue - 3920 to be precise. > >- Try to resize the Data Output panel or just c

pgAdmin 4 commit: Add a "scratch pad" to the Query Tool to hold text sn

2019-02-15 Thread Dave Page
Add a "scratch pad" to the Query Tool to hold text snippets whilst editing. Fixes #2233 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=255afe673afbab9df45b7deb0a76481f5dc51d1d Modified Files -- docs/en_US/query_tool.rst