Re: [pgAdmin4] [RM3862] Fix Dialog tabset keyboard navigation

Hi, Please find attached patch to fix dialog tab navigation in backup and restore dialog. Note: If first control in dialog is bootstrap switch then tab and dialog tab navigation do not work. This is because bootstrap switch captures all keyboard events and it does not allow them to propagate /bub

pgAdmin 4 commit: Fixed dialog tab navigation for Backup and Restore di

Fixed dialog tab navigation for Backup and Restore dialog. Fixes regression of #3862 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=42c7ae372f7f4f26ba928926f22f1b9f872f15da Author: Harshal Dhumal Modified Files -- web/pgadmin/st

Re: [pgAdmin4] [RM3862] Fix Dialog tabset keyboard navigation

Thanks patch applied. On Thu, Jan 24, 2019 at 4:19 PM Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > Please find attached patch to fix dialog tab navigation in backup and > restore dialog. > > Note: If first control in dialog is bootstrap switch then tab and dialog > tab navig

Re: [pgAdmin4][patch] pgadmin responsive not working as expected for desktop

Hi Could you rebase this please? Thanks. On Thu, Jan 17, 2019 at 12:33 PM Aditya Toshniwal wrote: > > Hi Hackers, > > Attached is the patch to fix controls alignment responsiveness to docker size > change. > > Kindly review. > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer |

Re: [pgAdmin][RM3891]json/jsonb editing Save and Cancel buttons Reversed

Could you rebase this please? Thanks. On Fri, Jan 18, 2019 at 10:58 AM Aditya Toshniwal wrote: > > Hi Hackers, > > Attached is the patch to fix correct the buttons for json/jsonb type column > data editing. > > Kindly review. > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer |

Re: [pgAdmin4][RM3695] Long name is not displayed completely in Drop confirmation pop up screen for server group

Akshay, Are you look into this? Thanks. On Fri, Jan 18, 2019 at 9:58 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the revised patch. The previous patch may affect changes at > unwanted places. > The revised patch has limited scope and will affect

Re: [pgAdmin4][RM3695] Long name is not displayed completely in Drop confirmation pop up screen for server group

Hi Dave, This patch is applied. On Thu, Jan 24, 2019 at 7:36 PM Dave Page wrote: > Akshay, > > Are you look into this? > > Thanks. > > On Fri, Jan 18, 2019 at 9:58 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the revised patch. The previou

Re: [pgAdmin][RM3891]json/jsonb editing Save and Cancel buttons Reversed

On Thu, Jan 24, 2019 at 2:09 PM Aditya Toshniwal wrote: > > Hi Dave, > > This patch is already committed and resolved. > https://redmine.postgresql.org/issues/3891 Oh, OK - I don't have a message in-thread saying that :-( > On Thu, Jan 24, 2019 at 7:34 PM Dave Page wrote: >> >> Could you rebas

Re: [pgAdmin][RM3891]json/jsonb editing Save and Cancel buttons Reversed

Hi Dave, This patch is already committed and resolved. https://redmine.postgresql.org/issues/3891 On Thu, Jan 24, 2019 at 7:34 PM Dave Page wrote: > Could you rebase this please? > > Thanks. > > On Fri, Jan 18, 2019 at 10:58 AM Aditya Toshniwal > w

Re: [pgAdmin4][patch] pgadmin responsive not working as expected for desktop

Oh, and what RM is it related to? On Thu, Jan 24, 2019 at 2:01 PM Dave Page wrote: > > Hi > > Could you rebase this please? > > Thanks. > > On Thu, Jan 17, 2019 at 12:33 PM Aditya Toshniwal > wrote: > > > > Hi Hackers, > > > > Attached is the patch to fix controls alignment responsiveness to doc

Re: [pgAdmin4][patch] pgadmin responsive not working as expected for desktop

Hi Dave, This patch is applied and is a regression of new design changes. https://github.com/postgres/pgadmin4/commit/48660508ce52a34a94b41baceb3ff49bb134f22c On Thu, Jan 24, 2019 at 7:32 PM Dave Page wrote:

Re: [pgAdmin4][RM3695] Long name is not displayed completely in Drop confirmation pop up screen for server group

On Thu, Jan 24, 2019 at 2:11 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Dave, > > This patch is applied. > OK. Akshay, can you please make sure you reply to the thread when you commit a patch? Otherwise, others (like me) don't necessarily see to remove it from our TODOs.

Feature Request: Allow set a suffix/prefix in application_name

Hello everyone, It would be great to allow to customize the connection's application_name "pgAdmin 4 - CONN:1175178" to be able to distinguish the different connections by default. We are several people connecting to the same db with the same user (in dev) and it would be good to see for example

Re: [pgAdmin4][patch] pgadmin responsive not working as expected for desktop

Hi On Thu, Jan 24, 2019 at 2:12 PM Aditya Toshniwal wrote: > > Hi Dave, > > This patch is applied and is a regression of new design changes. > https://github.com/postgres/pgadmin4/commit/48660508ce52a34a94b41baceb3ff49bb134f22c Oh. Not sure it worked very well. See the attached screenshot which

Re: [pgAdmin4][patch] pgadmin responsive not working as expected for desktop

Oh it was not for mobile view screen. It was for the desktop view. On Thu, Jan 24, 2019, 19:50 Dave Page Hi > > On Thu, Jan 24, 2019 at 2:12 PM Aditya Toshniwal > wrote: > > > > Hi Dave, > > > > This patch is applied and is a regression of new design changes. > https://github.com/postgres/pgadmi

Re: [pgAdmin4][patch] pgadmin responsive not working as expected for desktop

Oh, OK - well please log a ticket and fix that too then :-) On Thu, Jan 24, 2019 at 2:48 PM Aditya Toshniwal wrote: > > Oh it was not for mobile view screen. It was for the desktop view. > > On Thu, Jan 24, 2019, 19:50 Dave Page > >> Hi >> >> On Thu, Jan 24, 2019 at 2:12 PM Aditya Toshniwal >> w

pgAdmin 4 commit: Ensure object names in external process dialogues are

Ensure object names in external process dialogues are properly escaped. Fixes #3872 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d9fc9fdc4db76edf75f360280c090d34ffb69f83 Author: Murtuza Zabuawala Modified Files -- docs/en_US/r

pgAdmin 4 commit: Fix alignment of help messages in properties panels.

Fix alignment of help messages in properties panels. Fixes #3929 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2d7eaa63c44e0f34d46a36a9029169964f36ae37 Author: Murtuza Zabuawala Modified Files -- docs/en_US/release_notes_4_2.rst

Re: [pgAdmin4][RM3695] Long name is not displayed completely in Drop confirmation pop up screen for server group

On Thu, 24 Jan 2019, 19:44 Dave Page > > On Thu, Jan 24, 2019 at 2:11 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Dave, >> >> This patch is applied. >> > > OK. Akshay, can you please make sure you reply to the thread when you > commit a patch? Otherwise, others (like