pgAdmin 4 commit: Make the setup process more robust against aborted ex

Make the setup process more robust against aborted executions. Fixes #3830 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=943fc25f60f2ab585ccc352455495045fe24e415 Author: Aditya Toshniwal Modified Files -- docs/en_US/release_note

Re: [pgAdmin4][RM3830] AttributeError if pgadmin4-web-setup.sh stopped in between login setup and run again

Thanks, applied. On Thu, Dec 20, 2018 at 10:56 AM Aditya Toshniwal wrote: > > Hi Hackers, > > Attached is patch to fix the exception "AttributeError: 'NoneType' object has > no attribute 'value'", which occurs when you stop(Ctrl+Z or Ctrl+C) > pgadmin4-web-setup.sh script while entering details

pgAdmin 4 commit: Add flask-migrate to the container doc build as it's

Add flask-migrate to the container doc build as it's now required. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=12b7e03085afef5ba7dc40c4114e69d122b55d94 Modified Files -- pkg/docker/Dockerfile | 2 +- 1 file changed, 1 insertion(

pgAdmin 4 commit: Further improvements to treeview restoration. Fixes #

Further improvements to treeview restoration. Fixes #3559 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a000dc6f60cc4bcf527ecab264ca9261e5c8172f Author: Khushboo Vashi Modified Files -- docs/en_US/release_notes_3_7.rst

Re: [pgAdmin 4][Patch]: RM 3559 - Far too many mouse clicks to drill down in Browser

Thanks, patch applied! On Thu, Dec 20, 2018 at 11:39 AM Khushboo Vashi wrote: > > > > On Thu, Dec 20, 2018 at 4:01 PM Dave Page wrote: >> >> Hi >> >> On Tue, Dec 18, 2018 at 9:46 AM Khushboo Vashi >> wrote: >> > >> > Hi, >> > >> > Please find the attached patch to fix the issue reported in RM #

Re: [pgAdmin4][Patch] - RM 3780 pgAdmin4 lacks ability to specify NULL values in CSV export

Hi Here's an updated patch as I've tweaked some of the wording. The screenshot probably isn't the right resolution, but as we're replacing them anyway it doesn't seem overly important. Feel free to fix if you like :-) With quoting set to either All or Strings, everything looks good. With it set t

pgAdmin 4 commit: Improvement in the look and feel of the whole applica

Improvement in the look and feel of the whole application Changed the SCSS/CSS for the below third party libraries to adopt the new look 'n' feel: - wcDocker - Alertify dialogs, and notifications - AciTree - Bootstrap Navbar - Bootstrap Tabs - Bootstrap Drop-Down menu - Backgrid - Select2 Adopate

Re: [pgAdmin4][Patch] - RM 3780 pgAdmin4 lacks ability to specify NULL values in CSV export

Hi Dave Can you please attached the updated patch with your changes. I'll try to fix the exception. On Fri, Dec 21, 2018 at 3:57 AM Dave Page wrote: > Hi > > Here's an updated patch as I've tweaked some of the wording. The > screenshot probably isn't the right resolution, but as we're replacing

Re: pgAdmin 4 commit: Improvement in the look and feel of the whole applica

Nice! Thanks Ashesh. Some small issues I spotted: - The font looks somewhat small. How does it compare in size to, say, Gmail? I think it needs to be increased to at least that size. - Dialogues have 2 close buttons next to each other in the top-right. Looks like an icon and a text version? - W

Re: pgAdmin 4 commit: Improvement in the look and feel of the whole applica

Hi Dave, On Fri, Dec 21, 2018 at 5:51 PM Dave Page wrote: > Nice! Thanks Ashesh. > > Some small issues I spotted: > > - The font looks somewhat small. How does it compare in size to, say, > Gmail? I think it needs to be increased to at least that size. > Gmail uses 0.875rem (14px) for the left p

Re: pgAdmin 4 commit: Improvement in the look and feel of the whole applica

Hi On Fri, Dec 21, 2018 at 12:29 PM Aditya Toshniwal wrote: > > Hi Dave, > > On Fri, Dec 21, 2018 at 5:51 PM Dave Page wrote: >> >> Nice! Thanks Ashesh. >> >> Some small issues I spotted: >> >> - The font looks somewhat small. How does it compare in size to, say, >> Gmail? I think it needs to be

Re: [pgAdmin4][Patch] - RM 3780 pgAdmin4 lacks ability to specify NULL values in CSV export

Hi Looks good - I just found one issue; please go ahead and commit (with a release notes update) when fixed. - If I set the NULL replacement value to an empty string, it defaults back to NULL. It's therefore not possible to replace null values with an empty value. Thanks! On Fri, Dec 21, 2018 a

Re: pgAdmin 4 commit: Improvement in the look and feel of the whole applica

One other issue: I'm seeing that standard sized dialogues (e.g. the Server or Database Properties dialogues) are wrapping their labels and controls at the default size. That should not be the case. On Fri, Dec 21, 2018 at 12:46 PM Dave Page wrote: > > Hi > > On Fri, Dec 21, 2018 at 12:29 PM Adity

Re: pgAdmin 4 commit: Improvement in the look and feel of the whole applica

And hopefully finally; it looks like the pop-out text editor on the query tool results grid hasn't been updated. On Fri, Dec 21, 2018 at 1:59 PM Dave Page wrote: > > One other issue: I'm seeing that standard sized dialogues (e.g. the > Server or Database Properties dialogues) are wrapping their l

Re: pgAdmin 4 commit: Improvement in the look and feel of the whole applica

On Fri, Dec 21, 2018 at 7:29 PM Dave Page wrote: > One other issue: I'm seeing that standard sized dialogues (e.g. the > Server or Database Properties dialogues) are wrapping their labels and > controls at the default size. That should not be the case. > Yep. Akshay has logged that in the sheet s

Re: pgAdmin 4 commit: Improvement in the look and feel of the whole applica

On Fri, Dec 21, 2018 at 2:02 PM Aditya Toshniwal wrote: > > > > On Fri, Dec 21, 2018 at 7:29 PM Dave Page wrote: >> >> One other issue: I'm seeing that standard sized dialogues (e.g. the >> Server or Database Properties dialogues) are wrapping their labels and >> controls at the default size. Tha

Re: [pgAdmin4][Patch] - RM 3780 pgAdmin4 lacks ability to specify NULL values in CSV export

On Fri, 21 Dec 2018, 18:52 Dave Page Hi > > Looks good - I just found one issue; please go ahead and commit (with a > release notes update) when fixed. > > - If I set the NULL replacement value to an empty string, it defaults back > to NULL. It's therefore not possible to replace null values with

Re: pgAdmin 4 commit: Improvement in the look and feel of the whole applica

For the query tool results grid text pop-out, you mean the border size around it ? We don't have any design discussed for it, so could you please propose what can be done. On Fri, Dec 21, 2018 at 7:35 PM Dave Page wrote: > On Fri, Dec 21, 2018 at 2:02 PM Aditya Toshniwal > wrote: > > > > > > >

Re: [pgAdmin4][Patch] - RM 3780 pgAdmin4 lacks ability to specify NULL values in CSV export

On Fri, Dec 21, 2018 at 2:08 PM Akshay Joshi wrote: > > > On Fri, 21 Dec 2018, 18:52 Dave Page >> Hi >> >> Looks good - I just found one issue; please go ahead and commit (with a >> release notes update) when fixed. >> >> - If I set the NULL replacement value to an empty string, it defaults >> b

Re: pgAdmin 4 commit: Improvement in the look and feel of the whole applica

On Fri, Dec 21, 2018 at 2:14 PM Aditya Toshniwal wrote: > > For the query tool results grid text pop-out, you mean the border size around > it ? > We don't have any design discussed for it, so could you please propose what > can be done. Border, button colours etc. I can't draw anything, but I'

Re: pgAdmin 4 commit: Improvement in the look and feel of the whole applica

On Fri, Dec 21, 2018 at 7:46 PM Dave Page wrote: > On Fri, Dec 21, 2018 at 2:14 PM Aditya Toshniwal > wrote: > > > > For the query tool results grid text pop-out, you mean the border size > around it ? > > We don't have any design discussed for it, so could you please propose > what can be done.