pgAdmin 4 commit: Doc updates after renaming SQL Editor section of the

2018-10-11 Thread Dave Page
Doc updates after renaming SQL Editor section of the Preference panel. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4a6426d3e770fca5e2db148822219ed2d0b2b8b3 Author: Aditya Toshniwal Modified Files -- .../images/preferences_sql_

Re: [pgAdmin4][RM3660] Rename 'SQL Editor' into 'Query Tool' in Preferences

2018-10-11 Thread Dave Page
Thanks - applied. Of course, this makes me think - we'll need to replace all the screenshots soon :-( On Thu, Oct 11, 2018 at 6:33 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > Attached is the patch for docs update. > > On Mon, Oct 8, 2018 at 4:13 PM Dave Page wrote:

Re: [pgAdmin4][RM3562] Migrate Bootstrap 3 to Bootstrap 4

2018-10-11 Thread Aditya Toshniwal
Hi Hackers, Team found few more issues. Calendar control totally messed up. The bootstrap-datetimepicker package does not work with Bootstrap 4. Fortunately, there exists one package which is advanced version of the same - https://tempusdominus.github.io/bootstrap-4/. With minimum changes I am abl

process_executor.py error

2018-10-11 Thread Usman Muzaffar
Hi Hackers, While running API test cases, i encountered following error in process_executor.py file == fp.write('EXCEPTION::\n{0}'.format(res)) TypeError: a bytes-like object is required, not 'str' ==

Re: process_executor.py error

2018-10-11 Thread Usman Muzaffar
+++ a little more information for the issue i - The file(log_file) mode was 'ab' due to which it was throwing concatenation error. ii- I have change the file opening mode to 'a' after which the issue is not encountered. The issue can be reproduced as following i) Enable Python 3.6 virtual envir

Re: [pgAdmin4][RM3562] Migrate Bootstrap 3 to Bootstrap 4

2018-10-11 Thread Aditya Toshniwal
Hi Hackers, Attached is part 3 of the patch, to be applied after part 2. Urgh, I know this is annoying, but I am trying to fix and send patches as and when I find them. This patch includes fix for hiding controls. Backform used "hidden" class for hiding elements, and hidden is replaced with d-none

pgAdmin 4 commit: Log process exceptions using ASCII mode to avoid issu

2018-10-11 Thread Dave Page
Log process exceptions using ASCII mode to avoid issues with string concatenation. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3f16a0c52cd473abd21fe626c1ee8b24165fcf6d Author: Usman Muzaffar Modified Files -- web/pgadmin/misc

Re: process_executor.py error

2018-10-11 Thread Dave Page
Thanks, applied. On Thu, Oct 11, 2018 at 12:51 PM Usman Muzaffar < usman.muzaf...@enterprisedb.com> wrote: > +++ a little more information for the issue > > > i - The file(log_file) mode was 'ab' due to which it was throwing > concatenation error. > ii- I have change the file opening mode to 'a'

pgAdmin 4 commit: Additional Bootstrap 4 fixes:

2018-10-11 Thread Dave Page
Additional Bootstrap 4 fixes: - Calendar control - Query Tool's Sort/Filter drop down - Backform hidden controls - Debugger toolbar Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6991c06937e89ba668d9a41b49febbe4f4e78c6c Author: Aditya Toshniw

Re: [pgAdmin4][RM3562] Migrate Bootstrap 3 to Bootstrap 4

2018-10-11 Thread Dave Page
Thanks, applied. On Thu, Oct 11, 2018 at 11:08 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Team found few more issues. Calendar control totally messed up. The > bootstrap-datetimepicker package does not work with Bootstrap 4. > Fortunately, there exists one p

Re: [pgAdmin4][RM3562] Migrate Bootstrap 3 to Bootstrap 4

2018-10-11 Thread Dave Page
Thanks, applied. On Thu, Oct 11, 2018 at 12:52 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is part 3 of the patch, to be applied after part 2. Urgh, I know > this is annoying, but I am trying to fix and send patches as and when I > find them. This pa