[pgAdmin4][RM3660] Rename 'SQL Editor' into 'Query Tool' in Preferences

Hi Hackers, Attached is the tiny patch for renaming 'SQL Editor' into 'Query Tool' in Preferences. -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tree" RM3660.patch Description: Binary data

Patch for setting preferences with user id

Hi Hackers, Please find here attached patch for following "modified the function test_utils/set_preference to accommodate user_id." It will help setting preferences in case user_id is other than 1(depending on the user which has been logged in). FYI - the patch is dependent on the patch shared

pgAdmin 4 commit: Save the treeview state periodically, and restore it

Save the treeview state periodically, and restore it automatically when reconnecting. Fixes #1253 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=528ea88deceacd593fc9e92b083e03f3b849fba9 Author: Khushboo Vashi Modified Files -- d

Re: [pgAdmin4][Patch]: RM 1253 - Store and reload current location in treeview

Thanks - committed! On Fri, Oct 5, 2018 at 5:24 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Dave, > > I found one issue with the selecting previous selected node which I was > fixed and attached the updated patch. > Please let me know if you find any specific scenario which i

pgAdmin 4 commit: Code refactoring:

Code refactoring: - Move the duplicate code for closing the background process dialog into 'test_gui_helper.py', - Simplify the logic by removing the duplicate steps to insert/update binary paths for each server type from 'test_utils.py'. Branch -- master Details --- https://git.postgr

Re: [pgAdmin4][Patch]: Code refactoring

Thanks, patch applied. On Fri, Oct 5, 2018 at 7:56 AM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > +++ > > Below are the changes, > - Move the duplicate code for closing the background process dialog into > 'test_gui_helper.py', > - Simplify the logic by removing the duplicate

Re: [pgAdmin4][Patch]: RM #1513 - Unable to do max selection to drop tables/sequences/functions

Hi On Fri, Oct 5, 2018 at 12:28 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached updated patch with the fixes. > Whenever I run the python tests, I get the following errors (even after manually deleting all test tablespaces):

pgAdmin 4 commit: Update French translation.

Update French translation. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=87b64cf3c04498499bdfac9b18cdedd62b2c84ed Author: Fred Escallier Modified Files -- .../translations/fr/LC_MESSAGES/messages.mo| Bin 151664 -> 152102

Re: french translation update

Thanks - committed! On Fri, Oct 5, 2018 at 1:33 PM wrote: > hello > based on 3.4 catalog > too late ! > will be for next one > bye > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Rename the 'SQL Editor' section of the Preferences to

Rename the 'SQL Editor' section of the Preferences to 'Query Tool' as it applies to the whole tool, not just the editor. Fixes #3660 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=26ad6d4c5d43d47999e322f91ff318f052654a5d Author: Aditya Toshni

Re: [pgAdmin4][RM3660] Rename 'SQL Editor' into 'Query Tool' in Preferences

Thanks, applied. On Mon, Oct 8, 2018 at 8:07 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the tiny patch for renaming 'SQL Editor' into 'Query Tool' in > Preferences. > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseD

Re: Patch for setting preferences with user id

Hi On Mon, Oct 8, 2018 at 9:08 AM Usman Muzaffar < usman.muzaf...@enterprisedb.com> wrote: > Hi Hackers, > > Please find here attached patch for following > > "modified the function test_utils/set_preference to accommodate user_id." > > It will help setting preferences in case user_id is other tha

Re: [pgAdmin4][Patch]: RM #1513 - Unable to do max selection to drop tables/sequences/functions

Hi Dave, On Mon, Oct 8, 2018 at 3:47 PM Dave Page wrote: > Hi > On Fri, Oct 5, 2018 at 12:28 PM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> Please find the attached updated patch with the fixes. >> > > Whenever I run the python tests, I get the following errors (eve

Re: Patch for setting preferences with user id

On Mon, Oct 8, 2018 at 4:18 PM Dave Page wrote: > Hi > On Mon, Oct 8, 2018 at 9:08 AM Usman Muzaffar < > usman.muzaf...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Please find here attached patch for following >> >> "modified the function test_utils/set_preference to accommodate user_id." >>

Re: Patch for setting preferences with user id

On Mon, Oct 8, 2018 at 12:55 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Mon, Oct 8, 2018 at 4:18 PM Dave Page wrote: > >> Hi >> On Mon, Oct 8, 2018 at 9:08 AM Usman Muzaffar < >> usman.muzaf...@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Please find here attached

Re: Patch for setting preferences with user id

On Mon, Oct 8, 2018 at 5:25 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Mon, Oct 8, 2018 at 4:18 PM Dave Page wrote: > >> Hi >> On Mon, Oct 8, 2018 at 9:08 AM Usman Muzaffar < >> usman.muzaf...@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Please find here attached

Re: [pgAdmin4][Patch]: RM #1513 - Unable to do max selection to drop tables/sequences/functions

On Mon, Oct 8, 2018 at 12:50 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Dave, > > On Mon, Oct 8, 2018 at 3:47 PM Dave Page wrote: > >> Hi >> On Fri, Oct 5, 2018 at 12:28 PM Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> Hi, >>> >>> Please find the attache

Re: Patch for setting preferences with user id

On Mon, Oct 8, 2018 at 1:00 PM Ashesh Vashi wrote: > On Mon, Oct 8, 2018 at 5:25 PM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On Mon, Oct 8, 2018 at 4:18 PM Dave Page wrote: >> >>> Hi >>> On Mon, Oct 8, 2018 at 9:08 AM Usman Muzaffar < >>> usman.muzaf...@enterprisedb.

Re: Patch for setting preferences with user id

On Mon, Oct 8, 2018 at 5:36 PM Dave Page wrote: > > > On Mon, Oct 8, 2018 at 1:00 PM Ashesh Vashi > wrote: > >> On Mon, Oct 8, 2018 at 5:25 PM Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> >>> >>> On Mon, Oct 8, 2018 at 4:18 PM Dave Page wrote: >>> Hi On Mon, Oct

Re: Patch for setting preferences with user id

On Mon, Oct 8, 2018 at 1:08 PM Ashesh Vashi wrote: > On Mon, Oct 8, 2018 at 5:36 PM Dave Page wrote: > >> >> >> On Mon, Oct 8, 2018 at 1:00 PM Ashesh Vashi < >> ashesh.va...@enterprisedb.com> wrote: >> >>> On Mon, Oct 8, 2018 at 5:25 PM Khushboo Vashi < >>> khushboo.va...@enterprisedb.com> wrote

Re: Patch for setting preferences with user id

On Mon, Oct 8, 2018 at 5:43 PM Dave Page wrote: > > > On Mon, Oct 8, 2018 at 1:08 PM Ashesh Vashi > wrote: > >> On Mon, Oct 8, 2018 at 5:36 PM Dave Page wrote: >> >>> >>> >>> On Mon, Oct 8, 2018 at 1:00 PM Ashesh Vashi < >>> ashesh.va...@enterprisedb.com> wrote: >>> On Mon, Oct 8, 2018 at

Re: Patch for setting preferences with user id

On Mon, Oct 8, 2018 at 1:14 PM Ashesh Vashi wrote: > On Mon, Oct 8, 2018 at 5:43 PM Dave Page wrote: > >> >> >> On Mon, Oct 8, 2018 at 1:08 PM Ashesh Vashi < >> ashesh.va...@enterprisedb.com> wrote: >> >>> On Mon, Oct 8, 2018 at 5:36 PM Dave Page wrote: >>> On Mon, Oct 8, 2018 at

Re: [pgAdmin4][RM3562] Migrate Bootstrap 3 to Bootstrap 4

Hi, On Mon, Oct 8, 2018 at 4:06 PM Dave Page wrote: > Hi > > On Fri, Oct 5, 2018 at 1:51 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch to migrate pgAdmin4 currently based on Bootstrap 3, >> to be Bootstrap 4 compatible. The idea is

Re: Patch for setting preferences with user id

On Mon, Oct 8, 2018 at 5:53 PM Dave Page wrote: > > > On Mon, Oct 8, 2018 at 1:14 PM Ashesh Vashi > wrote: > >> On Mon, Oct 8, 2018 at 5:43 PM Dave Page wrote: >> >>> >>> >>> On Mon, Oct 8, 2018 at 1:08 PM Ashesh Vashi < >>> ashesh.va...@enterprisedb.com> wrote: >>> On Mon, Oct 8, 2018 at

[pgAdmin4][Patch]: To fix minor CSS issue

Hi, PFA minor patch to add the required CSS for select2's select-all background color, It is a regression of RM#2927. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company fix_select-all_css.diff Description: Binary data

[pgAdmin4][Patch]: RM #3674 Old session files are not cleared in .pgAdmin session and keep piling up

Hi Hackers Attached is the patch to fix the RM #3674 "Old session files are not cleared in .pgAdmin session and keep piling up". Patch contains following changes: - With current implementation we have override *get_expiration_time*() method of flask and return the expiry time as "datetime.d

Re: [pgAdmin4][Patch]: RM #3674 Old session files are not cleared in .pgAdmin session and keep piling up

On Mon, Oct 8, 2018 at 6:30 PM Akshay Joshi wrote: > Hi Hackers > > Attached is the patch to fix the RM #3674 "Old session files are not > cleared in .pgAdmin session and keep piling up". Patch contains following > changes: > >- With current implementation we have override *get_expiration_tim

Re: [pgAdmin4][Patch]: RM #3674 Old session files are not cleared in .pgAdmin session and keep piling up

Hi Khushboo On Tue, Oct 9, 2018 at 9:38 AM Khushboo Vashi wrote: > > > On Mon, Oct 8, 2018 at 6:30 PM Akshay Joshi > wrote: > >> Hi Hackers >> >> Attached is the patch to fix the RM #3674 "Old session files are not >> cleared in .pgAdmin session and keep piling up". Patch contains >> following