On Mon, Aug 27, 2018 at 1:19 PM, Akshay Joshi wrote:
> Hi Khushboo
>
> Patch looks good to me, following are my review comments:
>
>- Logic doesn't work when we disconnect and re-connect to the database
>server. We have duplicated RM #1335.
>
> I have saved the current state of the tree.
Hi,
Please find attached patch to fix below debugger issues.
1. Allow debugging of EPAS package procedures/functions with INOUT params.
2. Add Support for indirect debugging for EPAS package procedures/functions.
3. Allow debugging with NULL param values.
Thanks,
--
*Harshal Dhumal*
*Sr. Soft
Thank you for reviewing Khusboo.
Please find the updated patch.
On Tue, Aug 28, 2018 at 11:22 AM Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:
> Hi Murtuza,
>
> The patch is working fine for the server nodes but not for database.
>
> Thanks,
> Khushboo
>
> On Mon, Aug 27, 2018 at 4:48
Looks good to me.
On Tue, Aug 28, 2018 at 8:10 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:
> Thank you for reviewing Khusboo.
> Please find the updated patch.
>
>
> On Tue, Aug 28, 2018 at 11:22 AM Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>> Hi Murtuza,
Hi Hackers,
Attached is the latest patch and will have the following changes:
1) Debugger scrolling issues fixed. Now debugger will scroll to active line
and keep the active line in the centre of the editor.
2) Changes to avoid reloading same proc/function again in case of a
recursive call.
3) Fou
Thanks patch applied.
On Wed, Aug 29, 2018 at 10:21 AM, Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:
> Looks good to me.
>
>
> On Tue, Aug 28, 2018 at 8:10 PM, Murtuza Zabuawala enterprisedb.com> wrote:
>
>> Thank you for reviewing Khusboo.
>> Please find the updated patch.
>>
>>
>>
Ensure that refresh button on dashboard should refresh the table. Fixes #3525
Branch
--
master
Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9c8cf267849d566e9a1dc344067e8f11b3829e71
Author: Murtuza Zabuawala
Modified Files
--
docs/en_US/release_
Hi Aditya,
yarn run bundle gives errors.
yarn run v0.27.5
$ yarn run linter && yarn run webpacker
/home/khushboo/Projects/pgadmin4/web/pgadmin/static/bundle/codemirror.js
20:28 error Strings must use singlequote quotes
22:53 error Strings must use singlequote quotes
Thanks,
Khushboo
Hi,
Attached is the updated patch. Fixed linter issues.
On Wed, Aug 29, 2018 at 11:26 AM Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:
> Hi Aditya,
>
> yarn run bundle gives errors.
>
> yarn run v0.27.5
> $ yarn run linter && yarn run webpacker
>
> /home/khushboo/Projects/pgadmin4/web
