[pgAdmin4][patch] Correct handling of URL param values when striping version number

Hi Hackers, Attached is minor patch to correctly handle "values" in web/pgadmin/__init__.py -> strip_version_number which can be None in some cases and will cause exception when None . -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Compl

Re: [pgAdmin4][RM2927] Move all CSS into SCSS files for consistency and ease of colour maintenance etc.

Hi On Thu, Aug 16, 2018 at 6:14 AM, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Dave, > > On Wed, Aug 15, 2018 at 9:31 PM, Dave Page wrote: > >> One more thought - can you please look at updating the style guide on the >> website to be consistent? https://git.postgresql.org

pgAdmin 4 commit: Correctly handle "values" in web/pgadmin/__init__.py

Correctly handle "values" in web/pgadmin/__init__.py -> strip_version_number which can be None in some cases and will cause exception when None Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ff87cf554414717b2978d95e02d2e7aedab3463c Author: Ad

Re: [pgAdmin4][patch] Correct handling of URL param values when striping version number

Thanks, applied. On Thu, Aug 16, 2018 at 9:13 AM, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is minor patch to correctly handle "values" in > web/pgadmin/__init__.py > -> strip_version_number which can be None in some cases and will cause > exception

[pgAdmin4][Patch]: Fixed issue where "Backup Globals" not working correctly

Hi Hackers, Attached is the patch to fix issue where "Backup Globals" not working correctly. pg_dumpall utility runs without "--globals-only" flag even if user click on "Backup Globals" menu . Also correct the regression test case for it. -- *Akshay Joshi* *Sr. Software Architect * *Phone: +

Re: [pgAdmin 4 - Bug #3556] Slash "/" in server group breaks table contents

Hi Jan, Could you please upgrade pgAdmin4 to 3.2 and give a try. I tried on 3.2, works fine for me. Let us know if you face the problem. On Thu, Aug 16, 2018 at 5:13 PM, Jan Birk wrote: > Sure and sorry I didn't do it from the beginning: > > > Version > 3.0 > Copyright > Copyright 2013 - 2018,

Re: [pgAdmin 4 - Bug #3556] Slash "/" in server group breaks table contents

Den 16-08-2018 kl. 13:51 skrev Aditya Toshniwal: Hi Jan, Could you please upgrade pgAdmin4 to 3.2 and give a try. I tried on 3.2, works fine for me. Let us know if you face the problem. Yes and thanks. It will take a few weeks but I will be back. Best /Jan

Re: [pgAdmin4][patch]: Feature #1407 - Support map view for PostGIS query result sets

Hi That's looking more awesome each time I try it :-). I found just 3 things I think need tweaking: - The maps sometimes include links to Leaflet or OpenStreet Map. Clicking these will open them in the current Query Tool tab. We need to ensure they open in a new browser tab or window, not inside

Re: [pgAdmin4][RM2927] Move all CSS into SCSS files for consistency and ease of colour maintenance etc.

Hi That looks much better... but, did you get the right shades of grey? They seem to have a slight green hint to them. On Thu, Aug 16, 2018 at 10:42 AM, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Dave/Hackers, > > Please find attached the updated patch. > > On Thu, Aug 16,

Re: [pgAdmin4][RM2927] Move all CSS into SCSS files for consistency and ease of colour maintenance etc.

Hi, On Thu, Aug 16, 2018 at 6:01 PM, Dave Page wrote: > Hi > > That looks much better... but, did you get the right shades of grey? They > seem to have a slight green hint to them. > I tried to get the correct ones. And we can always change them, its SASS. :-D > > On Thu, Aug 16, 2018 at 10:42

Re: [pgAdmin4][RM2927] Move all CSS into SCSS files for consistency and ease of colour maintenance etc.

On Thu, Aug 16, 2018 at 1:33 PM, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > On Thu, Aug 16, 2018 at 6:01 PM, Dave Page wrote: > >> Hi >> >> That looks much better... but, did you get the right shades of grey? They >> seem to have a slight green hint to them. >> > I tri

pgAdmin 4 commit: Fix passing of --globals-only to global backups.

Fix passing of --globals-only to global backups. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d68c967423771af7083511c0dc0d48986ce63a44 Author: Akshay Joshi Modified Files -- web/pgadmin/tools/backup/__init__.py

Re: [pgAdmin4][Patch]: Fixed issue where "Backup Globals" not working correctly

Thanks, applied. On Thu, Aug 16, 2018 at 11:14 AM, Akshay Joshi < akshay.jo...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to fix issue where "Backup Globals" not working > correctly. pg_dumpall utility runs without "--globals-only" flag even if > user click on "Backup Global

[pgadmin4][patch] GreenPlum error while checking roles SQL

Hi Hackers, Attached you can find a patch that will correct issue #3578 The SQL command used to retrieve the SQL for the Role does not work, because it as a piece of it that is intended for Postgres > 9.0. Thanks Joao diff --git a/web/pgadmin/browser/server_groups/servers/roles/templates/role/sq