Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree

Hi there, Yes, there's a lot of TODO that we intend for this effort - to be submitted. We'd like to remove as much *direct* invocations on the ACI Tree library, as it causes a lot of coupling to the library. It is not the final patch, but we cannot come up with a definitive list of the things we i

Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree

On Mon, Apr 30, 2018 at 3:51 PM, Anthony Emengo wrote: > Hi there, > > Yes, there's a lot of TODO that we intend for this effort - to be > submitted. We'd like to remove as much *direct* invocations on the ACI > Tree library, as it causes a lot of coupling to the library. It is not the > final pa

pgAdmin 4 commit: Ensure the JS-linter is running on all the tests file

Ensure the JS-linter is running on all the tests files. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=31e73f409693b46f6248f2d4fb9aeb4756891669 Author: Joao De Almeida Pereira Modified Files -- web/pga_eslint.js | 9 + 1 f

pgAdmin 4 commit: Fixed the issues for all the javascript files reporte

Fixed the issues for all the javascript files reported by the liner. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c94439bf8ea7678722453f0e3750060bee31a074 Modified Files -- .../backform_controls/keyboardshortcut_spec.js | 32

Possibility to increase release frequency

All, Currently we are starting to get a fair number of users leveraging pgAdmin 4. Because of this we are finding new issues with Greenplum we didn't previously know about and we would like to get the fixes for those issues out as soon as possible. The current release process is shrouded in a bit

Re: [pgAdmin4][Patch]: RM 3284 - F5 key not working consistently

Hi there, We weren't able to see these functions get called. Perhaps we're missing something. Thanks, Joao && Anthony On Mon, Apr 30, 2018 at 2:48 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Joao, > > The patches look good however I have noticed that you > deleted attachSho

Re: Possibility to increase release frequency

Hi On Mon, Apr 30, 2018 at 3:33 PM, Robert Eckhardt wrote: > All, > > Currently we are starting to get a fair number of users leveraging > pgAdmin 4. Because of this we are finding new issues with Greenplum we > didn't previously know about and we would like to get the fixes for > those issues o

Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree

On Sat, Apr 28, 2018 at 3:55 AM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Hackers, > As you are aware we kept on working on the patch, so we are attaching to > this email a new version of the patch. > This new version contains all the changes in the previous one plus mor

Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree

On Mon, Apr 30, 2018 at 8:30 PM, Ashesh Vashi wrote: > On Sat, Apr 28, 2018 at 3:55 AM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hi Hackers, >> As you are aware we kept on working on the patch, so we are attaching to >> this email a new version of the patch. >> This n

Re: Possibility to increase release frequency

On Mon, Apr 30, 2018 at 10:51 AM, Dave Page wrote: > Hi > > On Mon, Apr 30, 2018 at 3:33 PM, Robert Eckhardt > wrote: >> >> All, >> >> Currently we are starting to get a fair number of users leveraging >> pgAdmin 4. Because of this we are finding new issues with Greenplum we >> didn't previously

Re: Possibility to increase release frequency

On Mon, Apr 30, 2018 at 4:09 PM, Robert Eckhardt wrote: > On Mon, Apr 30, 2018 at 10:51 AM, Dave Page wrote: > > Hi > > > > On Mon, Apr 30, 2018 at 3:33 PM, Robert Eckhardt > > wrote: > >> > >> All, > >> > >> Currently we are starting to get a fair number of users leveraging > >> pgAdmin 4. Bec

pgAdmin 4 commit: HAve the clean target zap any generated JS or CSS. Fi

HAve the clean target zap any generated JS or CSS. Fixes #3134 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ae1b2149a1c87429f1024e2aa41bd29e2e0f3dbe Modified Files -- Makefile | 6 +- 1 file changed, 5 insertions(+), 1 deleti

Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree

> > I was expecting a separate layer between the tree implementation, and > aciTree adaptor. > Please find the patch for the example. > It will separate the two layers, and easy to replace with the new > implementation in future. In general, we want defer the separation of the layers for now. Eve

Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree

On Mon, Apr 30, 2018 at 8:58 PM, Anthony Emengo wrote: > I was expecting a separate layer between the tree implementation, and >> aciTree adaptor. >> Please find the patch for the example. >> It will separate the two layers, and easy to replace with the new >> implementation in future. > > > In g

Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree

On Mon, Apr 30, 2018 at 4:33 PM, Ashesh Vashi wrote: > > On Mon, Apr 30, 2018 at 8:58 PM, Anthony Emengo > wrote: > >> I was expecting a separate layer between the tree implementation, and >>> aciTree adaptor. >>> Please find the patch for the example. >>> It will separate the two layers, and ea

Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree

On Mon, Apr 30, 2018 at 9:07 PM, Dave Page wrote: > > > On Mon, Apr 30, 2018 at 4:33 PM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> >> On Mon, Apr 30, 2018 at 8:58 PM, Anthony Emengo >> wrote: >> >>> I was expecting a separate layer between the tree implementation, and aciT

pgAdmin 4 commit: Fix mis-edit.

Fix mis-edit. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c2122fbfb989fbc72db73e7bf64c92b4c8d11e86 Modified Files -- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree

You've lost us with the last reply. We'd love to know what we'd have to do to get this patch committed. You mention that "some things are missing at some places" and that "there are missing bits". Please note that this is not a complete solution that we've offered so far. But only one step in a gra