pgAdmin 4 commit: Don't use pycryptodome at the moment, as it doesn't p

Don't use pycryptodome at the moment, as it doesn't play well on Windows. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=051fd645d7f134af83215f783a155c8ef6db184b Modified Files -- requirements.txt | 3 +-- 1 file changed, 1 inserti

pgAdmin 4 commit: Only avoid pre-built binaries for psycopg2 when build

Only avoid pre-built binaries for psycopg2 when building the Mac package, as some others (e.g. pbr) don't like being forced to source builds at the moment. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=97cf58fdc8c524ed4c85bb27ba82c54a9f46ae4

pgAdmin 4 commit: Ensure the query tool will open properly under MS Edg

Ensure the query tool will open properly under MS Edge. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f5e474e4ece886830c2c7a870bee1fa8af90f4a5 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/browser/static/js/browser.js

pgAdmin 4 commit: Cleanup node modules when cleaning

Cleanup node modules when cleaning Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=be2ac25fed77963cf0e62834b074a3534e06acfa Modified Files -- Makefile | 5 - 1 file changed, 4 insertions(+), 1 deletion(-)

[pgAdmin4][RM#3257] Fix for explain functionality

Hi Dave, A minor fix for explain functionality. *Issue:* Due to multiline explain options in the SQL template CodeMirror was failing to highlight the exact line of error. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_3257.diff Des

pgAdmin 3.0 builds

The pgAdmin 3.0 builds are at https://developer.pgadmin.org/~dpage/v3.0/. Barring any show-stopper issues, these are what will be released on Thursday. As a reminder to packagers: - This release removes dependencies on QtWebKit and/or QtWebEngine, and uses the users default browser instead. - G

[pgAdmin4] Changes required to support PyCrypto

Hi, Please find patch to revert back the changes we have made for pycryptodom module, This will fix encrypt & decrypt functionality in python3. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company reverting_back_changes_for_pycrypto.diff Des

Re: pgAdmin 3.0 builds

Hi Dave, On Tue, Apr 10, 2018 at 4:21 PM, Dave Page wrote: > The pgAdmin 3.0 builds are at https://developer.pgadmin.org/~dpage/v3.0/. > > Barring any show-stopper issues, these are what will be released on > Thursday. > > As a reminder to packagers: > > - This release removes dependencies on Qt

Re: pgAdmin 3.0 builds

On Tue, Apr 10, 2018 at 12:52 PM, Sandeep Thakkar < sandeep.thak...@enterprisedb.com> wrote: > Hi Dave, > > On Tue, Apr 10, 2018 at 4:21 PM, Dave Page wrote: > >> The pgAdmin 3.0 builds are at https://developer.pgadmin.org/~dpage/v3.0/. >> >> Barring any show-stopper issues, these are what will b

Re: pgAdmin 3.0 builds

Hi Dave, I am still able to reproduce pgadmin4 crash issue on Windows 07 64 and Windows 2012 R2 64 on fresh VMs: https://redmine.postgresql.org/issues/3227 Kind Regards, On Tue, Apr 10, 2018 at 3:51 PM, Dave Page wrote: > The pgAdmin 3.0 builds are at https://developer.pgadmin.org/~dpage/v3.

Re: pgAdmin 3.0 builds

On Tue, Apr 10, 2018 at 12:54 PM, Fahar Abbas wrote: > Hi Dave, > > I am still able to reproduce pgadmin4 crash issue on Windows 07 64 and > Windows 2012 R2 64 on fresh VMs: > > https://redmine.postgresql.org/issues/3227 > Did you ever correlate it to VMware versions as I asked last week? -- D

Re: [pgAdmin4] Changes required to support PyCrypto

On Tue, Apr 10, 2018 at 12:49 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > Please find patch to revert back the changes we have made for pycryptodom > module, This will fix encrypt & decrypt functionality in python3. > Wait, what? Are you telling me that encrypt/de

Re: pgAdmin 3.0 builds

Yes Akshay is not able to reproduce this issue on VMWare Fusion 6.0.6 while Khushboo is facing same issue on Windows 07 64. I am using VMware Fusion 10 version and facing issue on Windows 2012 and Windows 07 64 bit. Kindly suggest, how i can proceed further on this, should we document this? On

Re: pgAdmin 3.0 builds

On Tue, Apr 10, 2018 at 1:02 PM, Fahar Abbas wrote: > Yes Akshay is not able to reproduce this issue on VMWare Fusion 6.0.6 > while Khushboo is facing same issue on Windows 07 64. > > I am using VMware Fusion 10 version and facing issue on Windows 2012 and > Windows 07 64 bit. > I also cannot re

Re: pgAdmin 3.0 builds

Hi, On Tue, Apr 10, 2018 at 5:44 PM, Dave Page wrote: > > > On Tue, Apr 10, 2018 at 1:02 PM, Fahar Abbas > wrote: > >> Yes Akshay is not able to reproduce this issue on VMWare Fusion 6.0.6 >> while Khushboo is facing same issue on Windows 07 64. >> >> I am using VMware Fusion 10 version and fac

Re: pgAdmin 3.0 builds

Hi Neel, On Tue, Apr 10, 2018 at 5:43 PM, Neel Patel wrote: > Hi, > > On Tue, Apr 10, 2018 at 5:44 PM, Dave Page wrote: > >> >> >> On Tue, Apr 10, 2018 at 1:02 PM, Fahar Abbas < >> fahar.ab...@enterprisedb.com> wrote: >> >>> Yes Akshay is not able to reproduce this issue on VMWare Fusion 6.0.6

Re: [pgAdmin4] Changes required to support PyCrypto

On Tue, Apr 10, 2018 at 5:27 PM, Dave Page wrote: > > > On Tue, Apr 10, 2018 at 12:49 PM, Murtuza Zabuawala < > murtuza.zabuaw...@enterprisedb.com> wrote: > >> Hi, >> >> Please find patch to revert back the changes we have made for pycryptodom >> module, This will fix encrypt & decrypt functional

Re: pgAdmin 3.0 builds

On Tue, Apr 10, 2018 at 6:15 PM, Fahar Abbas wrote: > Hi Neel, > > On Tue, Apr 10, 2018 at 5:43 PM, Neel Patel > wrote: > >> Hi, >> >> On Tue, Apr 10, 2018 at 5:44 PM, Dave Page wrote: >> >>> >>> >>> On Tue, Apr 10, 2018 at 1:02 PM, Fahar Abbas < >>> fahar.ab...@enterprisedb.com> wrote: >>> >>>

Re: pgAdmin 3.0 builds

On Tue, Apr 10, 2018 at 2:36 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Tue, Apr 10, 2018 at 6:15 PM, Fahar Abbas > wrote: > >> Hi Neel, >> >> On Tue, Apr 10, 2018 at 5:43 PM, Neel Patel >> wrote: >> >>> Hi, >>> >>> On Tue, Apr 10, 2018 at 5:44 PM, Dave Page wrote: >>

Re: [pgAdmin4][RM#3257] Fix for explain functionality

Hi Murtuza, Looks like the tests are failing due to this change. I also got some strange result on the linter, but I believe it is something related to this machine. Thanks Joao On Tue, Apr 10, 2018 at 6:20 AM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > A minor

Re: pgAdmin 3.0 builds

Hi Windows 7 Professional here. On Tue, Apr 10, 2018 at 3:50 PM, Fahar Abbas wrote: > Hi Murtuza, > > I am using Windows 07 64 ultimate and updates are already applied and > crash is still reproducible when change default browsers to chrome. So you > are using Windows 07 Home Premium as per the

pgAdmin 4 commit: Fix non-ASCII password decryption/encryption under Py

Fix non-ASCII password decryption/encryption under Python 3 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d0a640442cd6dc7bbfdb2647cf1775c13ad79a96 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/utils/crypto.py | 9 -

Re: [pgAdmin4] Changes required to support PyCrypto

*grumble*. Thanks, applied. On Tue, Apr 10, 2018 at 1:52 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > On Tue, Apr 10, 2018 at 5:27 PM, Dave Page wrote: > >> >> >> On Tue, Apr 10, 2018 at 12:49 PM, Murtuza Zabuawala < >> murtuza.zabuaw...@enterprisedb.com> wrote: >> >>> Hi

Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree

Hello Khushboo On Mon, Apr 9, 2018 at 1:59 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Joao, > > I have reviewed your patch and have some suggestions. > > On Sat, Apr 7, 2018 at 12:43 AM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hello Murtuza/Dave

pgAdmin 4 commit: Revert "Fix non-ASCII password decryption/encryption

Revert "Fix non-ASCII password decryption/encryption under Python 3" This reverts commit d0a640442cd6dc7bbfdb2647cf1775c13ad79a96. Seems to anger Python 2.7 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=163cadc279cec25390a6dd0243e7491321ad8

Re: [pgAdmin4] Changes required to support PyCrypto

On Tue, Apr 10, 2018 at 4:51 PM, Dave Page wrote: > *grumble*. Thanks, applied. > And reverted. When I went back to 2.7, it got very upset: ERROR runTest (pgadmin.browser.server_groups.servers.databases.schemas.tables.tests.test_table_put.TableUpdateTestCase) Create partitions of existing range

Re: pgAdmin 3.0 builds

On Tue, 10 Apr 2018, 20:20 Fahar Abbas, wrote: > Hi Murtuza, > > I am using Windows 07 64 ultimate and updates are already applied and > crash is still reproducible when change default browsers to chrome. So you > are using Windows 07 Home Premium as per the snapshot. > > Hi Dave, > > Can you ple

Re: pgAdmin 3.0 builds

I don't think sub version matters here. On Tue, 10 Apr 2018, 22:08 Khushboo Vashi, wrote: > > > On Tue, 10 Apr 2018, 20:20 Fahar Abbas, > wrote: > >> Hi Murtuza, >> >> I am using Windows 07 64 ultimate and updates are already applied and >> crash is still reproducible when change default browse

Re: [pgAdmin4] Changes required to support PyCrypto

​This is the exact code we had before pycrptodom changes, Is it fresh virtual environment? I suspect ​some conflicts from pycrptodom files. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, Apr 10, 2018 at 9:51 PM, Dave Page wrote:

Re: [pgAdmin4][RM#3257] Fix for explain functionality

Thanks for reviewing Joao. Yeah missed to run tests. I assumed its just a SQL formatting it wouldn't hurt anything but I was wrong :) Here's updated patch. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, Apr 10, 2018 at 8:18 PM,

Ignoring web/yarn-error.log and runtime/moc_LogWindow.cpp

These are generated files. We can choose to ignore them. diff --git a/.gitignore b/.gitignore index 467505c7..3bec41ff 100644 --- a/.gitignore +++ b/.gitignore @@ -40,3 +40,4 @@ web/regression/test_config.json node_modules/ web/pgAdmin/static/js/generated web/pgadmin/static/js/generated +web/yar

Re: [pgAdmin4][Patch][Feature #1998] Appends .sql if extension not given when using 'save' or 'save as' feature

I am trying to access the value in the format combobox for selected file type to put it here.. This snippet happens to be in web/pgadmin/tools/sqleditor/static/js/sqleditor.js How do I get access to that format combobox value to determine whether it is 'sql' or 'All Files' ? Also What is e here

Re: pgAdmin 3.0 builds

Hi Dave/Team! I just downloaded fresh iso and created new VM of Windows 2012 R2 server from MSDN subscription and crash issue is still reproduce. Now checking on Windows 07 Home basic 32 bit and Windows 07 Professional 64 bit. Kind Regards On Tue, Apr 10, 2018 at 10:15 PM, Murtuza Zabuawala < m

Re: pgAdmin 3.0 builds

Hi Dave, Now i know the actual root-cause of the issue. After further investigation, i realized that pgAdmin4 applications works fine on same Windows 2012 R2 and Windows 07 64 bit VM once Administrator user does not contain any space. Normally I use Fahar Abbas with Administrator user privileges a

Re: [pgAdmin4][Patch][Feature #1998] Appends .sql if extension not given when using 'save' or 'save as' feature

Hi, We are passing the file name when we trigger an event from File manager whenever user selects any file ../pgadmin/misc/file_manager/static/js/file_manager.js Line:302 OR creates any new file ../pgadmin/misc/file_manager/static/js/file_manager.js Line:583, Line:678 You can use jQuery selec