Re: pgAdmin 4 commit: Fix a number of broken connection detection scenarios

Thanks, RM#3249 created for the same. Regards, Neel Patel On Thu, Apr 5, 2018 at 11:27 AM, Akshay Joshi wrote: > Hi Neel > > This issue is not due to the above fix, if you can see the error it is > showing in dashboard.js line no 454 "err = JSON.parse(xhr.responseText);" > that code is from lon

Re: [pgAdmin4]: Fix for RM #3248

Thanks, applied. On Thu, Apr 5, 2018 at 7:49 AM, Neel Patel wrote: > Hi, > > Please find updated patch after fixing the comments. > Review it and let me know for comments. > > Thanks, > Neel Patel > > On Thu, Apr 5, 2018 at 11:32 AM, Neel Patel > wrote: > >> Thanks Murtuza & Khushboo. >> I will

pgAdmin 4 commit: Ensure Alertify dialogues are modal to prevent them b

Ensure Alertify dialogues are modal to prevent them being closed by mis-click. Fixes #3248 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=659390493d08fe62d97f1fb48ff68d5e15a534fb Author: Neel Patel Modified Files -- docs/en_US/r

Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree

Hi Joao, Can you please rebase the second patch? Thanks, Khushboo On Tue, Apr 3, 2018 at 12:15 AM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Hackers, > > Attached you can find the patch that will start to decouple pgAdmin from > ACITree library. > This patch is intende

Re: [pgAdmin4][RM#3055] Allow user to sort the data in View data mode

Can you rebase this please? On Wed, Mar 28, 2018 at 8:19 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > Please find updated patch with following changes, > - Combined Filter and Data sorting together same as pgAdmin3. > - Extracted model into separate file > - C

Re: [pgAdmin4][RM#3072] Make pgagent job history rows configurable

Hi On Thu, Apr 5, 2018 at 11:10 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch which allow user to configure how many rows they wish to display > for any pgagent jobs on statistics panel. > I think this is essentially good, however, I'm really not happy wi

Re: [pgAdmin4][RM#3072] Make pgagent job history rows configurable

On Thu, Apr 5, 2018 at 4:43 PM, Dave Page wrote: > Hi > > On Thu, Apr 5, 2018 at 11:10 AM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi, >> >> PFA patch which allow user to configure how many rows they wish to >> display for any pgagent jobs on statistics panel. >> > > I think this is esse

Re: [pgAdmin4][RM#3072] Make pgagent job history rows configurable

On Thu, Apr 5, 2018 at 4:43 PM, Dave Page wrote: > Hi > > On Thu, Apr 5, 2018 at 11:10 AM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi, >> >> PFA patch which allow user to configure how many rows they wish to >> display for any pgagent jobs on statistics panel. >> > > I think this is esse

Re: [pgAdmin4][RM#3155] Allow user to lock the Layout

On Wed, Apr 4, 2018 at 11:31 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Wed, Apr 4, 2018 at 8:09 PM, Dave Page wrote: > >> >> >> On Wed, Apr 4, 2018 at 12:54 PM, Murtuza Zabuawala < >> murtuza.zabuaw...@enterprisedb.com> wrote: >> >>> On Wed, Apr 4, 2018 at 5:00 PM, Dav

Re: [pgAdmin4][RM#3072] Make pgagent job history rows configurable

Hi Murtuza, Generally the patch looks good passes all CI but the linter fails: /tmp/build/4a5630c2/pivotal-rm-3072/web /tmp/build/4a5630c2 ./pgadmin/browse

Re: [pgAdmin4][RM#3072] Make pgagent job history rows configurable

Murtuza, please send me the screenshot as a PNG. I've been tweaking the code and will recreate the patch with my changes. On Thu, Apr 5, 2018 at 2:53 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Murtuza, > Generally the patch looks good passes all CI but the linter fail

Re: [pgAdmin4][RM#3072] Make pgagent job history rows configurable

Sorry Murtuza - I'm mixing patches up here. It's the sort/filter one I need the image for please. Which means this patch needs re-creating as well please. On Thu, Apr 5, 2018 at 3:03 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > Please find attached PNG. > > O

pgAdmin 4 commit: Allow sorting when viewing/editing data. Fixes #1894

Allow sorting when viewing/editing data. Fixes #1894 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fa1854bd85502ea9db2716f18d5edf0bd79cacdc Author: Murtuza Zabuawala Modified Files -- docs/en_US/editgrid.rst

Re: [pgAdmin4][RM#3072] Make pgagent job history rows configurable

Hi The description for the Preferences field doesn't seem to be there in the code or the screenshot. I suggested below using: "The maximum number of history rows to show on the Statistics tab for pgAgent jobs." Thanks. On Thu, Apr 5, 2018 at 1:09 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterpr