Re: [pgAdmin4][RM#3154] Update modules to latest version

Hi Joao, Yes it bundles latest version but I doubt that is not using it, If we upgrade the jQuery to 3.3.1 then it's breaking the SlickGrid. I have tried that and I started getting jQuery related errors when trying to run query tool or when running jasmine tests. -- Regards, Murtuza Zabuawala Ent

Re: [pgAdmin4][RM#3235] Code refactoring in Query tool

Hi, Thank you Victoria & Joao for reviewing. PFA updated patch. On Wed, Apr 4, 2018 at 12:26 AM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Murtuza > > It is really good to see other patches that are just refactoring code. > > We have some suggestions: > - We are trying

Re: pgAdmin4 - Issue of unmaintained libraries

Hi On Tue, Apr 3, 2018 at 9:09 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Dave, > > On Tue, Apr 3, 2018 at 8:32 AM Dave Page wrote: > >> Hi >> >> On Tue, Apr 3, 2018 at 1:22 PM, Murtuza Zabuawala > enterprisedb.com> wrote: >> >>> Hi Team, >>> >>> As we are heavily de

Re: [pgAdmin4][Patch]: RM #1978 - Add an option to allow user to disable alertifyjs and acitree animations

Thanks, applied. On Wed, Apr 4, 2018 at 6:26 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Dave, > > On Tue, Apr 3, 2018 at 7:23 PM, Dave Page wrote: > >> Hi >> >> Thanks - I've committed this, however, could you send me an updated >> screenshot for the docs? The one you sent

pgAdmin 4 commit: Update screenshot.

Update screenshot. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fc886cf8bb51987fb77b3e2b5553c401ed5b24be Author: Khushboo Vashi Modified Files -- docs/en_US/images/preferences_browser_display.png | Bin 124191 -> 83195 bytes 1 f

Re: [pgAdmin4][RM#3155] Allow user to lock the Layout

On Wed, Apr 4, 2018 at 7:20 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > On Tue, Apr 3, 2018 at 9:03 PM, Dave Page wrote: > >> Hi >> >> On Tue, Apr 3, 2018 at 12:56 PM, Murtuza Zabuawala < >> murtuza.zabuaw...@enterprisedb.com> wrote: >> >>> Hi, >>> >>> Thanks

Re: [pgAdmin4][RM#3155] Allow user to lock the Layout

On Wed, Apr 4, 2018 at 2:47 PM, Dave Page wrote: > > > On Wed, Apr 4, 2018 at 7:20 AM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi Dave, >> >> On Tue, Apr 3, 2018 at 9:03 PM, Dave Page wrote: >> >>> Hi >>> >>> On Tue, Apr 3, 2018 at 12:56 PM, Murtuza Zabuawala < >>> murtuza.zabuaw...@ent

pgAdmin 4 commit: Update Python and JS modules. Fixes #3154

Update Python and JS modules. Fixes #3154 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=be055ce57df548a75618143fbe74916a45a2b22c Author: Murtuza Zabuawala Modified Files -- pkg/pip/setup_pip.py | 11

Re: [pgAdmin4][RM#3154] Update modules to latest version

Thanks, patch applied. On Tue, Apr 3, 2018 at 4:49 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > ​Hi Dave, > > Reverted back jQuery version to 1.x because of SlickGrid dependancy. > Please find updated patch. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://ww

Re: [pgAdmin4][RM#3154] Update modules to latest version

On Wed, Apr 4, 2018 at 8:24 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Joao, > > Yes it bundles latest version but I doubt that is not using it, If we > upgrade the jQuery to 3.3.1 then it's breaking the SlickGrid. > I have tried that and I started getting jQuery relat

Re: [pgAdmin4][RM#3154] Update modules to latest version

On Wed, Apr 4, 2018 at 3:19 PM, Dave Page wrote: > > > On Wed, Apr 4, 2018 at 8:24 AM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi Joao, >> >> Yes it bundles latest version but I doubt that is not using it, If we >> upgrade the jQuery to 3.3.1 then it's breaking the SlickGrid. >> I have t

pgAdmin 4 commit: Refactor and simplify query tool connection error han

Refactor and simplify query tool connection error handling code. Fixes #3235 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a705fb46a8df9d4db072894d8214a568c38a341a Author: Murtuza Zabuawala Modified Files -- web/pgadmin/static/j

Re: [pgAdmin4][RM#3235] Code refactoring in Query tool

Thanks, applied. On Wed, Apr 4, 2018 at 9:43 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > Thank you Victoria & Joao for reviewing. > PFA updated patch. > > On Wed, Apr 4, 2018 at 12:26 AM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hi Mur

Build failed in Jenkins: pgadmin4-master-python26 #683

See Changes: [Dave Page] Update Python and JS modules. Fixes #3154 [Dave Page] Refactor and simplify query tool connection error handling code. Fixes -- Started

Re: [pgAdmin4][Patch] Remake Docker container packaging

Hi On Wed, Apr 4, 2018 at 9:46 AM, Максим Кольцов wrote: > I've updated patch. Now I drop tests and regressions. > > And I added new env var: PGADMIN_LISTEN_PORT. Default value is 8080 for > http and 8443 for https mode. > > Please review. > I'm seeing the following error when building. It look

Re: [pgAdmin4][Patch] Remake Docker container packaging

2018-04-04 13:55 GMT+03:00 Dave Page : > Hi > > On Wed, Apr 4, 2018 at 9:46 AM, Максим Кольцов wrote: >> >> I've updated patch. Now I drop tests and regressions. >> >> And I added new env var: PGADMIN_LISTEN_PORT. Default value is 8080 for >> http and 8443 for https mode. >> >> Please review. > >

Re: [pgAdmin4][Patch] Remake Docker container packaging

On Wed, Apr 4, 2018 at 12:16 PM, Максим Кольцов wrote: > 2018-04-04 13:55 GMT+03:00 Dave Page : > > Hi > > > > On Wed, Apr 4, 2018 at 9:46 AM, Максим Кольцов > wrote: > >> > >> I've updated patch. Now I drop tests and regressions. > >> > >> And I added new env var: PGADMIN_LISTEN_PORT. Default v

Re: [pgAdmin4][Patch] Remake Docker container packaging

2018-04-04 14:16 GMT+03:00 Максим Кольцов : > 2018-04-04 13:55 GMT+03:00 Dave Page : >> Hi >> >> On Wed, Apr 4, 2018 at 9:46 AM, Максим Кольцов wrote: >>> >>> I've updated patch. Now I drop tests and regressions. >>> >>> And I added new env var: PGADMIN_LISTEN_PORT. Default value is 8080 for >>> h

pgAdmin 4 commit: Fix requirements for Python 2.6.

Fix requirements for Python 2.6. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b7c86da58605a7e9f474b1a9f4508d9bfc0bdff6 Author: Murtuza Zabuawala Modified Files -- pkg/pip/setup_pip.py| 12 +--- requirements.t

Build failed in Jenkins: pgadmin4-master-python26 #684

See Changes: [Dave Page] Fix requirements for Python 2.6. -- Started by an SCM change [EnvInject] - Loading node environment variables. Building in workspace

Re: [pgAdmin4][RM#3155] Allow user to lock the Layout

On Wed, Apr 4, 2018 at 10:45 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > On Wed, Apr 4, 2018 at 2:47 PM, Dave Page wrote: > >> >> >> On Wed, Apr 4, 2018 at 7:20 AM, Murtuza Zabuawala < >> murtuza.zabuaw...@enterprisedb.com> wrote: >> >>> Hi Dave, >>> >>> On Tue, Apr 3, 20

Re: [pgAdmin4][RM#3155] Allow user to lock the Layout

On Wed, Apr 4, 2018 at 5:00 PM, Dave Page wrote: > > > On Wed, Apr 4, 2018 at 10:45 AM, Murtuza Zabuawala < > murtuza.zabuaw...@enterprisedb.com> wrote: > >> On Wed, Apr 4, 2018 at 2:47 PM, Dave Page wrote: >> >>> >>> >>> On Wed, Apr 4, 2018 at 7:20 AM, Murtuza Zabuawala < >>> murtuza.zabuaw...@

pgAdmin 4 commit: SQLAlchemy stopped supporting Python 2.6.

SQLAlchemy stopped supporting Python 2.6. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c0cfc9f29b1e8ac1099a135ff7acf327576691fd Author: Murtuza Zabuawala Modified Files -- pkg/pip/setup_pip.py | 6 -- requirements.txt |

Build failed in Jenkins: pgadmin4-master-python27 #556

See Changes: [Dave Page] Fix requirements for Python 2.6. [Dave Page] SQLAlchemy stopped supporting Python 2.6. -- Started by an SCM change Started by an SCM cha

Re: Build failed in Jenkins: pgadmin4-master-python27 #556

Fix typo. On Wed, Apr 4, 2018 at 5:30 PM, pgAdmin 4 Jenkins wrote: > See 556/display/redirect?page=changes> > > Changes: > > [Dave Page] Fix requirements for Python 2.6. > > [Dave Page] SQLAlchemy stopped supporting Python 2.6. > > ---

pgAdmin 4 commit: Typo fix.

Typo fix. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=33890da57e8e632119feef3a88e49ac655c64ec5 Modified Files -- requirements.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: Build failed in Jenkins: pgadmin4-master-python27 #556

Thanks. On Wed, Apr 4, 2018 at 1:03 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Fix typo. > > On Wed, Apr 4, 2018 at 5:30 PM, pgAdmin 4 Jenkins > wrote: > >> See > 6/display/redirect?page=changes> >> >> Change

Build failed in Jenkins: pgadmin4-master-python26 #686

See Changes: [Dave Page] Typo fix. -- [...truncated 4.98 KB...] Collecting Flask==0.12.2 (from -r requirements.txt (line 9)) Using cached Flask-0.12.2-py2.py3-n

Jenkins build is back to normal : pgadmin4-master-python33 #557

See

Jenkins build is back to normal : pgadmin4-master-python36 #551

See

Build failed in Jenkins: pgadmin4-master-python33 #556

See Changes: [Dave Page] SQLAlchemy stopped supporting Python 2.6. -- Started by an SCM change [EnvInject] - Loading node environment variables. Building in works

pgAdmin 4 commit: Another attempt to fix the Python 2.6 deps.

Another attempt to fix the Python 2.6 deps. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a95775ae49e47fe1f289c514bb936a726010033c Author: Murtuza Zabuawala Modified Files -- pkg/pip/setup_pip.py | 10 +++--- requirements.txt

Build failed in Jenkins: pgadmin4-master-python26 #685

See Changes: [Dave Page] SQLAlchemy stopped supporting Python 2.6. -- Started by an SCM change [EnvInject] - Loading node environment variables. Building in works

Build failed in Jenkins: pgadmin4-master-python35 #555

See Changes: [Dave Page] Fix requirements for Python 2.6. [Dave Page] SQLAlchemy stopped supporting Python 2.6. -- Started by an SCM change Started by an SCM cha

Jenkins build is back to normal : pgadmin4-master-python34 #546

See

Build failed in Jenkins: pgadmin4-master-python33 #558

See Changes: [Dave Page] Another attempt to fix the Python 2.6 deps. -- Started by an SCM change Started by an SCM change [EnvInject] - Loading node environment v

Build failed in Jenkins: pgadmin4-master-python36 #552

See Changes: [Dave Page] Another attempt to fix the Python 2.6 deps. -- Started by an SCM change Started by an SCM change [EnvInject] - Loading node environment v

Re: pgAdmin 4 commit: Fix requirements for Python 2.6.

Hi, Do we really require "*Flask-Security" *package to mentioned multiple times for different python version. If not, we should remove it from one place. I am getting below error while running "pip install -r requirements.txt". *Double requirement given: Flask-Security>=3.0.0 (from -r ../../requ

Build failed in Jenkins: pgadmin4-master-python26 #687

See Changes: [Dave Page] Another attempt to fix the Python 2.6 deps. -- Started by an SCM change [EnvInject] - Loading node environment variables. Building in wor

pgAdmin 4 commit: Cleanup some duplication in the requirements.

Cleanup some duplication in the requirements. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1617d003cd17be0a12883c994cf1bf6acf1beb26 Modified Files -- requirements.txt | 2 -- 1 file changed, 2 deletions(-)

Build failed in Jenkins: pgadmin4-master-python36 #550

See Changes: [Dave Page] SQLAlchemy stopped supporting Python 2.6. -- Started by an SCM change [EnvInject] - Loading node environment variables. Building in works

Re: pgAdmin 4 commit: Fix requirements for Python 2.6.

Already on it. Unfortunately this is being fine-tuned through the test infrastructure, as my Python 2.6 installation is exhibiting some weird behaviour. On Wed, Apr 4, 2018 at 2:15 PM, Neel Patel wrote: > Hi, > > Do we really require "*Flask-Security" *package to mentioned multiple > times for d

Jenkins build is back to normal : pgadmin4-master-python36 #553

See

Jenkins build is back to normal : pgadmin4-master-python34 #548

See

Build failed in Jenkins: pgadmin4-master-python35 #556

See Changes: [Dave Page] Typo fix. [Dave Page] Another attempt to fix the Python 2.6 deps. -- Started by an SCM change Started by an SCM change Started by an SCM

Re: [pgAdmin4][Patch] Remake Docker container packaging

2018-04-04 14:18 GMT+03:00 Dave Page : > > > On Wed, Apr 4, 2018 at 12:16 PM, Максим Кольцов wrote: >> >> 2018-04-04 13:55 GMT+03:00 Dave Page : >> > Hi >> > >> > On Wed, Apr 4, 2018 at 9:46 AM, Максим Кольцов >> > wrote: >> >> >> >> I've updated patch. Now I drop tests and regressions. >> >> >>

Jenkins build is back to normal : pgadmin4-master-python33 #559

See

Jenkins build is back to normal : pgadmin4-master-python35 #557

See

Jenkins build is back to normal : pgadmin4-master-python27 #558

See

Jenkins build is back to normal : pgadmin4-master-python26 #688

See

Build failed in Jenkins: pgadmin4-master-python34 #545

See Changes: [Dave Page] SQLAlchemy stopped supporting Python 2.6. -- Started by an SCM change [EnvInject] - Loading node environment variables. Building in works

Re: [pgAdmin4][RM#3155] Allow user to lock the Layout

On Wed, Apr 4, 2018 at 12:54 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > On Wed, Apr 4, 2018 at 5:00 PM, Dave Page wrote: > >> >> >> On Wed, Apr 4, 2018 at 10:45 AM, Murtuza Zabuawala < >> murtuza.zabuaw...@enterprisedb.com> wrote: >> >>> On Wed, Apr 4, 2018 at 2:47 PM, D

Re: [pgAdmin4][RM#3155] Allow user to lock the Layout

On Wed, Apr 4, 2018 at 8:09 PM, Dave Page wrote: > > > On Wed, Apr 4, 2018 at 12:54 PM, Murtuza Zabuawala enterprisedb.com> wrote: > >> On Wed, Apr 4, 2018 at 5:00 PM, Dave Page wrote: >> >>> >>> >>> On Wed, Apr 4, 2018 at 10:45 AM, Murtuza Zabuawala < >>> murtuza.zabuaw...@enterprisedb.com> wr

Build failed in Jenkins: pgadmin4-master-python34 #547

See Changes: [Dave Page] Another attempt to fix the Python 2.6 deps. -- Started by an SCM change Started by an SCM change [EnvInject] - Loading node environment v

pgAdmin 4 commit: Update container build to use Alpine Linux and Gunico

Update container build to use Alpine Linux and Gunicorn instead of CentOS and Apache. Fixes #3246 This results in a much more slim-line container, requiring fewer resources to run. In addition, the majority of the build is now done using the Docker infrastructure, allowing for quicker rebuilds

Re: pgAdmin4 - Issue of unmaintained libraries

Hi Dave, On Wed, Apr 4, 2018 at 5:03 AM, Dave Page wrote: > Hi > > On Tue, Apr 3, 2018 at 9:09 PM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hi Dave, >> >> On Tue, Apr 3, 2018 at 8:32 AM Dave Page wrote: >> >>> Hi >>> >>> On Tue, Apr 3, 2018 at 1:22 PM, Murtuza Zabua

Re: [pgAdmin4][Patch] Remake Docker container packaging

Hi On Wed, Apr 4, 2018 at 2:46 PM, Максим Кольцов wrote: > > So, I've fixed it. Patch attached. Now whole requirements.txt is > installed in one step, with no left-overs and incompabilities. I've committed the patch with some minor changes to avoid breaking compatibility with the older version

Re: [pgAdmin4][RM#3155] Allow user to lock the Layout

Hi Hackers, We just reread the issue in Redmine, and our take is a little bit different. Looks like the problem the person is complaining the tabs sticking to the mouse when clicked. We also experience that problem while developing. How hard would it be to eliminate the Drag and Drop of tabs in t

Re: [pgAdmin4][RM#3155] Allow user to lock the Layout

On Wed, Apr 4, 2018 at 4:46 PM, Victoria Henry wrote: > Hi Hackers, > > We just reread the issue in Redmine, and our take is a little bit > different. Looks like the problem the person is complaining the tabs > sticking to the mouse when clicked. We also experience that problem while > developing

Build failed in Jenkins: pgadmin4-master-python27 #557

See Changes: [Dave Page] Typo fix. [Dave Page] Another attempt to fix the Python 2.6 deps. -- Started by an SCM change Started by an SCM change Started by an SCM

Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree

Khushboo, Murtuza, Can you spend some time reviewing this please? I've started playing with it as well - the first thing that's irking me somewhat is the lack of comments. Descriptive function names are all well and good, but sometimes a little more is needed, especially for less experienced devel

Re: [pgAdmin4][Patch] Remake Docker container packaging

2018-04-04 18:22 GMT+03:00 Dave Page : > Hi > > On Wed, Apr 4, 2018 at 2:46 PM, Максим Кольцов wrote: >> >> >> So, I've fixed it. Patch attached. Now whole requirements.txt is >> installed in one step, with no left-overs and incompabilities. > > > I've committed the patch with some minor changes t

Re: [pgAdmin4][Patch] Remake Docker container packaging

> On 4 Apr 2018, at 19:28, Максим Кольцов wrote: > > 2018-04-04 18:22 GMT+03:00 Dave Page : >> Hi >> >>> On Wed, Apr 4, 2018 at 2:46 PM, Максим Кольцов wrote: >>> >>> >>> So, I've fixed it. Patch attached. Now whole requirements.txt is >>> installed in one step, with no left-overs and incom

Re: [pgAdmin4][RM#3155] Allow user to lock the Layout

On Wed, Apr 4, 2018 at 8:09 PM, Dave Page wrote: > > > On Wed, Apr 4, 2018 at 12:54 PM, Murtuza Zabuawala enterprisedb.com> wrote: > >> On Wed, Apr 4, 2018 at 5:00 PM, Dave Page wrote: >> >>> >>> >>> On Wed, Apr 4, 2018 at 10:45 AM, Murtuza Zabuawala < >>> murtuza.zabuaw...@enterprisedb.com> wr

Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree

On Wed, Apr 4, 2018 at 9:47 PM, Dave Page wrote: > Khushboo, Murtuza, > > Can you spend some time reviewing this please? I've started playing with > it as well - the first thing that's irking me somewhat is the lack of > comments. Descriptive function names are all well and good, but sometimes a

[pgAdmin4]: Fix for RM #3248

Hi, Please find attached patch for the fix of RM #3248 - we have modified alertify confirm dialog to modal dialog. Do review it and let me know for comments. Thanks, Neel Patel RM_3248.patch Description: Binary data

Re: [pgAdmin4]: Fix for RM #3248

Hi Neel, Can we make the change in wrapper instead of changing every where? File: ../web/pgadmin/static/js/alertify.pgadmin.defaults.js -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Apr 5, 2018 at 11:04 AM, Neel Patel wrote:

Re: pgAdmin 4 commit: Fix a number of broken connection detection scenarios

Hi Neel This issue is not due to the above fix, if you can see the error it is showing in dashboard.js line no 454 "err = JSON.parse(xhr.responseText);" that code is from long time. I have just added an extra check of the readyState in case of server is down in the above commit. Though it is a bug

Re: [pgAdmin4]: Fix for RM #3248

Neel, Add below code to the top (around line no 8) in alertify.pgadmin.defaults.js file will solve the problem. alertify.defaults.closable = false; Thanks, Khushboo On Thu, Apr 5, 2018 at 11:13 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Neel, > > Can we make the c

Re: [pgAdmin4]: Fix for RM #3248

Thanks Murtuza & Khushboo. I will send updated patch. Thanks, Neel Patel On Thu, Apr 5, 2018 at 11:29 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Neel, > > Add below code to the top (around line no 8) in > alertify.pgadmin.defaults.js file will solve the problem. > > alertify.

Re: [pgAdmin4]: Fix for RM #3248

Hi, Please find updated patch after fixing the comments. Review it and let me know for comments. Thanks, Neel Patel On Thu, Apr 5, 2018 at 11:32 AM, Neel Patel wrote: > Thanks Murtuza & Khushboo. > I will send updated patch. > > Thanks, > Neel Patel > > On Thu, Apr 5, 2018 at 11:29 AM, Khushbo