Re: Proposal for changes in official Docker image

Hi On Sat, Mar 31, 2018 at 5:54 PM, Максим Кольцов wrote: > 2018-03-19 17:55 GMT+03:00 Dave Page : > > > > - PGADMIN_SERVER_NAME doesn't appear to be supported. This was added at > user > > request, for security reasons (to help ensure the connection is going > where > > expected). I'm not entir

Re: [pgAdmin4][Patch]: RM #1978 - Add an option to allow user to disable alertifyjs and acitree animations

Hi Joao, Thanks for the review. I have sent the patch. On Thu, Mar 29, 2018 at 8:46 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Khushboo, > > The patch looks like it is heading on the correct direction, we passed it > through our test pipeline and all tests passed. >

Re: Regarding RM #2214 SCRAM Authentication for Change Password

Hi On Mon, Apr 2, 2018 at 11:02 AM, Akshay Joshi wrote: > Hi Hackers, > > As a part of RM #2214, we will have to support SCRAM authentication. User > will be able to login, but the problem is with "Change Password" of > database server won't work, as we are encrypting new password using md5 and

[pgAdmin4][RM#3235] Code refactoring in Query tool

Hi, PFA patch to extract the common code from query tool to handle ajax errors & connection handling, Also added unit tests around extracted code. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_3235.diff Description: Binary data

pgAdmin4 - Issue of unmaintained libraries

Hi Team, As we are heavily dependent on 3rd party JS libraries and some of them are no longer actively maintained by their respective authors (Last commit was approximate year ago). Some of the core libraries which are no longer actively maintained are, - Backbone

Re: pgAdmin4 - Issue of unmaintained libraries

Hi On Tue, Apr 3, 2018 at 1:22 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Team, > > As we are heavily dependent on 3rd party JS libraries and some of them are > no longer actively maintained by their respective authors (Last commit was > approximate year ago). > > Som

Re: Bug #3083 fix

Hi On Thu, Mar 29, 2018 at 4:29 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Dave, > That looks like in the surrounding area of the change. We run our pipeline > and everything was green. > Can you provide more details, which python version are you using? OS? > That wa

Re: Bug #3083 fix

Argh, managed to send before I finished typing... On Tue, Apr 3, 2018 at 1:38 PM, Dave Page wrote: > Hi > > On Thu, Mar 29, 2018 at 4:29 PM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hi Dave, >> That looks like in the surrounding area of the change. We run our >> pipe

Re: [pgAdmin4][RM#3154] Update modules to latest version

Hi On Fri, Mar 30, 2018 at 8:01 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to update the modules to latest version. > > - Why isn't jQuery updated to 3.3.1? - Shouldn't pkg/pip/setup_pip.py be updated with changes to psycopg2 and pycrypto etc? > We

Re: Bug #3083 fix

-- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, Apr 3, 2018 at 6:10 PM, Dave Page wrote: > Argh, managed to send before I finished typing... > > On Tue, Apr 3, 2018 at 1:38 PM, Dave Page wrote: > >> Hi >> >>

pgAdmin 4 commit: Show more granular timing info in the query tool hist

Show more granular timing info in the query tool history panel. Fixes #3244 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=94e1e462019df51a5cc2f13e57fabc0547446b43 Author: Joao Pedro De Almeida Pereira Modified Files -- web/packa

Re: [pgadmin4][patch] #3244 Query elapse time granularity

Thanks, patch applied. On Mon, Apr 2, 2018 at 11:24 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Hackers, > > Attached you can find a patch that increases the granularity of time > displayed for total run time of a query. > Also extracts the functionality, wraps it with

Re: v3.0 release on hold

All, Where are we with respect to cutting this release? -- Rob On Mon, Mar 26, 2018 at 9:59 AM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Hackers, > > Did we had any progress on the things that are holding the release back? > > Thanks > Joao > > On Fri, Mar 23, 2018 at

pgAdmin 4 commit: Add the ability to enable/disable UI animations. Fixe

Add the ability to enable/disable UI animations. Fixes #1978 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=78051707832f37d35c46ff8c13c86906b331b0fb Author: Khushboo Vashi Modified Files -- docs/en_US/images/preferences_browser_d

Re: [pgAdmin4][Patch]: RM #1978 - Add an option to allow user to disable alertifyjs and acitree animations

Hi Thanks - I've committed this, however, could you send me an updated screenshot for the docs? The one you sent was a different size and colour depth from the others (and looked like a different scale). On Tue, Apr 3, 2018 at 10:42 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: >

Re: [pgAdmin4][RM#3235] Code refactoring in Query tool

HI On Tue, Apr 3, 2018 at 12:27 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to extract the common code from query tool to handle ajax errors > & connection handling, Also added unit tests around extracted code. > Looks good to me, except, I wonder if we

Re: [pgAdmin4][RM#3154] Update modules to latest version

Hi Dave, Please find updated patches, there are two patches attached one is for the story and another is for changes required as per new modules. On Tue, Apr 3, 2018 at 6:27 PM, Dave Page wrote: > Hi > > On Fri, Mar 30, 2018 at 8:01 AM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi, >> >

Re: v3.0 release on hold

I'm thinking build Monday, release Thursday. Objections? On Tue, Apr 3, 2018 at 2:43 PM, Robert Eckhardt wrote: > All, > > Where are we with respect to cutting this release? > > -- Rob > > On Mon, Mar 26, 2018 at 9:59 AM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hi

Re: v3.0 release on hold

On Tue, Apr 3, 2018 at 11:04 AM, Dave Page wrote: > I'm thinking build Monday, release Thursday. > > Objections? > It we can make it happen faster I'd be all for it. If not that will work. Thanks -- Rob > > > On Tue, Apr 3, 2018 at 2:43 PM, Robert Eckhardt > wrote: > >> All, >> >> Where are

Re: [pgAdmin4][RM#3154] Update modules to latest version

Please hold on my previous patch. We can't use latest jQuery version as SlickGrid has dependancy on older version. I'll send updated patch again. On Tue, Apr 3, 2018 at 8:20 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > Please find updated patches, there are t

Re: [pgAdmin4][RM#3155] Allow user to lock the Layout

Hi Murtuza, Everything seems to work, the tests are all green and the linter is fixed. As we stated in an previous email, the direction we would love the application to go is a more robust Javascript Front-End that would rely in the Backend to provide data. Adding more things to templated Javascr

Re: [pgAdmin4][RM#3155] Allow user to lock the Layout

Hi On Tue, Apr 3, 2018 at 12:56 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > Thanks Joao for reviewing. > > PFA updated patch. > > On Tue, Apr 3, 2018 at 1:11 AM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hello, >> >> On Mon, Apr 2, 2018

Re: [pgAdmin4][RM#3235] Code refactoring in Query tool

Hi Dave, PFA updated patch, I've renamed it to query_tool_http_error_handler.js & query_tool_http_error_handler_spec.js respectively. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, Apr 3, 2018 at 7:43 PM, Dave Page wrote: > HI

Re: [pgAdmin4][RM#3154] Update modules to latest version

​Hi Dave, Reverted back jQuery version to 1.x because of SlickGrid dependancy. Please find updated patch. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, Apr 3, 2018 at 8:50 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.

Re: [pgAdmin4][RM#3235] Code refactoring in Query tool

Hi Murtuza It is really good to see other patches that are just refactoring code. We have some suggestions: - We are trying to use === instead of == because === ensure that the type is also checked ( https://developer.mozilla.org/en-US/docs/Web/JavaScript/Equality_comparisons_and_sameness ) - Now

Re: [pgAdmin4][RM#3154] Update modules to latest version

Hi Murtuza, The patches look good and they pass all tests in CI. One think that we realized was the SlickGrid as a npm package now: https://www.npmjs.com/package/slickgrid Also Slickgrid comes packaged with jquery 3.1 not sure if it is fully supported or not.. Thanks Victoria & Joao On Tue,

Re: pgAdmin4 - Issue of unmaintained libraries

Hi Dave, On Tue, Apr 3, 2018 at 8:32 AM Dave Page wrote: > Hi > > On Tue, Apr 3, 2018 at 1:22 PM, Murtuza Zabuawala < > murtuza.zabuaw...@enterprisedb.com> wrote: > >> Hi Team, >> >> As we are heavily dependent on 3rd party JS libraries and some of them >> are no longer actively maintained by th