Re: v3.0 release on hold

2018-03-23 Thread Dave Page
On Fri, Mar 23, 2018 at 5:43 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Thu, Mar 22, 2018 at 3:42 PM, Dave Page wrote: > >> >> >> On Thu, Mar 22, 2018 at 9:58 AM, Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> >>> >>> On Thu, Mar 22, 2018 at 3:20 PM,

Re: pgAdmin4 form control error icon position change

2018-03-23 Thread Dave Page
Thanks Aditya, patch applied. On Wed, Mar 21, 2018 at 9:34 AM, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Created - https://redmine.postgresql.org/issues/3226 > > > On Wed, Mar 21, 2018 at 2:51 PM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hello Aditya, >> >> Could you

pgAdmin 4 commit: Move the field error indicators in front of the affec

2018-03-23 Thread Dave Page
Move the field error indicators in front of the affected fields so they don't obscure spinners or drop downs etc. Fixes #3226 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1f84285d99003d1d26ab2cb5fdc7d149a9e9f719 Author: Aditya Toshniwal M

Re: v3.0 release on hold

2018-03-23 Thread Khushboo Vashi
On Fri, Mar 23, 2018 at 3:21 PM, Dave Page wrote: > > > On Fri, Mar 23, 2018 at 5:43 AM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On Thu, Mar 22, 2018 at 3:42 PM, Dave Page wrote: >> >>> >>> >>> On Thu, Mar 22, 2018 at 9:58 AM, Khushboo Vashi < >>> khushboo.va...@ent

Re: Showstopper desktop runtime issue

2018-03-23 Thread Magnus Hagander
On Thu, Mar 22, 2018 at 5:28 PM, Dave Page wrote: > >> >> 3) Electron >>> >>> Pros: >>> - Full Javascript runtime, no more C++ code to handle >>> - Self packaging for all the environments >>> Cons: >>> - No fully supported on Linux based OS with old libstdc++, (This might >>> solve the problem: h

Re: Showstopper desktop runtime issue

2018-03-23 Thread Magnus Hagander
On Thu, Mar 22, 2018 at 5:38 PM, Robert Eckhardt wrote: > > > On Thu, Mar 22, 2018 at 12:28 PM, Dave Page wrote: > >> >>> (And don't give up on proper tabs either, but I'm sure Electron might >>> catch up in that eventually -- and the issue around RHEL6 will also go away >>> eventually) >>> >> >

Re: Experiencing issues

2018-03-23 Thread Dave Page
On Fri, Mar 23, 2018 at 6:17 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > On Wed, Mar 21, 2018 at 9:31 PM, Dave Page wrote: > >> >> >> On Wed, Mar 21, 2018 at 3:57 PM, Joao De Almeida Pereira < >> jdealmeidapere...@pivotal.io> wrote: >> >>> Sorry I did not understand wha

pgAdmin 4 commit: Simplify cookie domain/path settings, per discussion.

2018-03-23 Thread Dave Page
Simplify cookie domain/path settings, per discussion. Instead of trying to be smart, just let the user specify them in the config, e.g. COOKIE_DEFAULT_DOMAIN = None SESSION_COOKIE_DOMAIN = None Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=

Re: v3.0 release on hold

2018-03-23 Thread Ashesh Vashi
On Fri, Mar 23, 2018 at 3:21 PM, Dave Page wrote: > > > On Fri, Mar 23, 2018 at 5:43 AM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On Thu, Mar 22, 2018 at 3:42 PM, Dave Page wrote: >> >>> >>> >>> On Thu, Mar 22, 2018 at 9:58 AM, Khushboo Vashi < >>> khushboo.va...@ent

Re: Showstopper desktop runtime issue

2018-03-23 Thread Dave Page
Hi On Thu, Mar 22, 2018 at 6:27 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Hackers > > In the PoC we did with Electron last month this was the point where we > stopped > > What did we accomplish: > - Use Electron as a runtime and packaging solution for the applica

Re: Showstopper desktop runtime issue

2018-03-23 Thread Dave Page
On Thu, Mar 22, 2018 at 4:58 PM, Dave Page wrote: > > > On Thu, Mar 22, 2018 at 4:28 PM, Dave Page wrote: > >> >> 2) This option is not very appealing to me, because we would be pilling code into the QT portion of the application, that I hope we remove in the future, that currently is

Re: v3.0 release on hold

2018-03-23 Thread Dave Page
On Fri, Mar 23, 2018 at 11:27 AM, Ashesh Vashi < ashesh.va...@enterprisedb.com> wrote: > On Fri, Mar 23, 2018 at 3:21 PM, Dave Page wrote: > >> >> >> On Fri, Mar 23, 2018 at 5:43 AM, Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> >>> >>> On Thu, Mar 22, 2018 at 3:42 PM, Dave P

Re: v3.0 release on hold

2018-03-23 Thread Akshay Joshi
Hi Dave On Fri, Mar 23, 2018 at 11:06 AM, Akshay Joshi < akshay.jo...@enterprisedb.com> wrote: > > > On Thu, Mar 22, 2018 at 10:24 PM, Dave Page wrote: > >> Hi >> >> On Thu, Mar 22, 2018 at 1:13 PM, Dave Page wrote: >> >>> >>> 2) Starting a second instance of the app bundle on Mac doesn't >