pgAdmin 4 commit: Sporadically crashes on Windows when exit. Fixes #317

Sporadically crashes on Windows when exit. Fixes #3177 1) Shutdown the python server properly. 2) Disabled "Shutdown server" menu till server is not successfully started. Initial patch sent by Maxim, modified by Akshay Joshi. Branch -- master Details --- https://git.postgresql.org/gi

Re: pgAdmin 4 commit: Sporadically crashes on Windows when exit. Fixes #317

Hi Akshay, Given commit introduce PEP8 issue, PFA minor patch to fix the issue. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Mar 15, 2018 at 1:27 PM, Akshay Joshi wrote: > Sporadically crashes on Windows when exit. Fixes #31

pgAdmin 4 commit: Fixed PEP8 issue

Fixed PEP8 issue Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=faf243db713970ef6267c972d504e8a64b1df340 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/misc/__init__.py | 1 + 1 file changed, 1 insertion(+)

Re: pgAdmin 4 commit: Sporadically crashes on Windows when exit. Fixes #317

Thanks patch applied On Thu, Mar 15, 2018 at 4:03 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Akshay, > > Given commit introduce PEP8 issue, PFA minor patch to fix the issue. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterp

pgAdmin 4 commit: Exit CI run if the PEP-8 checks fail.

Exit CI run if the PEP-8 checks fail. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1e303dafdde5eb4f5dfe966dc051acf65c15d645 Modified Files -- ci/run_python_tests.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Build failed in Jenkins: pgadmin4-master-python35 #528

See Changes: [akshay.joshi] Fixed PEP8 issue [Dave Page] Exit CI run if the PEP-8 checks fail. -- Started by an SCM change Started by an SCM change Started by an

Build failed in Jenkins: pgadmin4-master-python26 #655

See Changes: [akshay.joshi] Fixed PEP8 issue [Dave Page] Exit CI run if the PEP-8 checks fail. -- Started by an SCM change Started by an SCM change [EnvInject] -

pgAdmin 4 commit: Add a French translation. Fixes #3184

Add a French translation. Fixes #3184 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6c59563afac54537156ea6c89b0087f6612cfbe4 Author: Fred Escallier Modified Files -- web/config.py | 1 + .

Build failed in Jenkins: pgadmin4-master-python27 #530

See Changes: [Dave Page] Exit CI run if the PEP-8 checks fail. [Dave Page] Add a French translation. Fixes #3184 -- Started by an SCM change [EnvInject] - Loadin

pgAdmin 4 commit: Update message catalogs. Current status:

Update message catalogs. Current status: 1469 of 1956 messages (75%) translated in pgadmin/translations/de/LC_MESSAGES/messages.po 1842 of 1956 messages (94%) translated in pgadmin/translations/fr/LC_MESSAGES/messages.po 1679 of 1956 messages (85%) translated in pgadmin/translations/ja/LC_MESSA

Build failed in Jenkins: pgadmin4-master-python26 #656

See Changes: [Dave Page] Add a French translation. Fixes #3184 [Dave Page] Update message catalogs. Current status: -- Started by an SCM change [EnvInject] - Loa

Re: French translation

Hi Fred, On Thu, Mar 15, 2018 at 6:08 AM, wrote: > hi > as mentionned in redmine issue > https://redmine.postgresql.org/issues/3184 > I've just completed french translation > harder than initially expected :-) > Fred > > That's awesome, thank you! I've committed this. I also ran a message extra

Build failed in Jenkins: pgadmin4-master-python35 #530

See Changes: [Dave Page] Update message catalogs. Current status: -- Started by an SCM change [EnvInject] - Loading node environment variables. Building in worksp

Build failed in Jenkins: pgadmin4-master-python34 #519

See Changes: [akshay.joshi] Fixed PEP8 issue [Dave Page] Exit CI run if the PEP-8 checks fail. -- Started by an SCM change Started by an SCM change Started by an

pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn

Ignore config_local.py and config_distro.py when running PEP-8 checks. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=53ae960aeba0dde6109b91c171f22758b1b04ebe Modified Files -- web/.pycodestyle | 2 +- 1 file changed, 1 insertion(+

Translation updates

Translators; We're planning to build the next release of pgAdmin on Tuesday next week. It would be great if you could all send in updates for your translations before then if possible. Here's the current status: 1469 of 1956 messages (75%) translated in pgadmin/translations/de/LC_MESSAGES/message

Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn

Hi, I have just noticed, we're ignoring migrations directory too. Should we not also check code styling for migrations directory? -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi*

Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn

Hi On Thu, Mar 15, 2018 at 7:14 AM, Ashesh Vashi wrote: > Hi, > > I have just noticed, we're ignoring migrations directory too. > Should we not also check code styling for migrations directory? > Yeah, I was going to ask about that :-). Is there a specific reason why we're ignoring the migratio

Jenkins build is back to normal : pgadmin4-master-python26 #657

See

pgAdmin 4 commit: Ensure SSL options are pushed down to external tools

Ensure SSL options are pushed down to external tools like pg_dump. Fixes #3122 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=63ba3402e8113c20b0c929a9764642ca67b3befd Author: Khushboo Vashi Modified Files -- web/pgadmin/misc/bgpr

Re: [pgadmin4][Patch]: RM #3122 - Backup not working on certificate (SSL) protected servers

Hi On Thu, Mar 15, 2018 at 12:55 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Thu, Mar 15, 2018 at 3:21 AM, Dave Page wrote: > >> Hi >> >> On Wed, Mar 14, 2018 at 10:55 AM, Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> Hi, >>> >>> Please find the att

Jenkins build is back to normal : pgadmin4-master-python36 #522

See

Jenkins build is back to normal : pgadmin4-master-python33 #529

See

Jenkins build is back to normal : pgadmin4-master-python34 #521

See

Jenkins build is back to normal : pgadmin4-master-python35 #531

See

Re: [pgAdmin4][Patch]: RM #2963 - Backup database, Restore database and Maintenance Database failed for é object.

On Thu, Mar 15, 2018 at 3:13 AM, Dave Page wrote: > Hi > > On Tue, Mar 13, 2018 at 11:18 PM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On Wed, Mar 14, 2018 at 2:18 AM, Dave Page wrote: >> >>> >>> >>> On Tue, Mar 13, 2018 at 12:46 AM, Khushboo Vashi < >>> khushboo.va..

Jenkins build is back to normal : pgadmin4-master-python27 #532

See

Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn

On Thu, Mar 15, 2018 at 4:53 PM, Dave Page wrote: > Hi > > On Thu, Mar 15, 2018 at 7:14 AM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> Hi, >> >> I have just noticed, we're ignoring migrations directory too. >> Should we not also check code styling for migrations directory? >> > >

Build failed in Jenkins: pgadmin4-master-python36 #521

See Changes: [Dave Page] Add a French translation. Fixes #3184 [Dave Page] Update message catalogs. Current status: -- Started by an SCM change [EnvInject] - Loa

Build failed in Jenkins: pgadmin4-master-python33 #527

See Changes: [akshay.joshi] Fixed PEP8 issue [Dave Page] Exit CI run if the PEP-8 checks fail. -- Started by an SCM change Started by an SCM change [EnvInject] -

Build failed in Jenkins: pgadmin4-master-python36 #520

See Changes: [akshay.joshi] Fixed PEP8 issue [Dave Page] Exit CI run if the PEP-8 checks fail. -- Started by an SCM change Started by an SCM change [EnvInject] -

Build failed in Jenkins: pgadmin4-master-python34 #520

See Changes: [Dave Page] Add a French translation. Fixes #3184 [Dave Page] Update message catalogs. Current status: -- Started by an SCM change [EnvInject] - Loa

Build failed in Jenkins: pgadmin4-master-python27 #531

See Changes: [Dave Page] Update message catalogs. Current status: -- Started by an SCM change [EnvInject] - Loading node environment variables. Building in worksp

Build failed in Jenkins: pgadmin4-master-python35 #529

See Changes: [Dave Page] Add a French translation. Fixes #3184 -- Started by an SCM change [EnvInject] - Loading node environment variables. Building in workspace

Build failed in Jenkins: pgadmin4-master-python33 #528

See Changes: [Dave Page] Add a French translation. Fixes #3184 [Dave Page] Update message catalogs. Current status: -- Started by an SCM change [EnvInject] - Loa

Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn

On Thu, Mar 15, 2018 at 8:30 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > On Thu, Mar 15, 2018 at 4:53 PM, Dave Page wrote: > >> Hi >> >> On Thu, Mar 15, 2018 at 7:14 AM, Ashesh Vashi < >> ashesh.va...@enterprisedb.com> wrote: >> >>> Hi, >>> >>> I have just noticed, we're

[pgAdmin4][RM#3195] Include service name when executing Backup, Restore etc tools

Hi, PFA patch which will allow tools to pickup Service name properly. Please review. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_3195.diff Description: Binary data

Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn

Hi Dave, On Thu, Mar 15, 2018 at 9:42 PM, Dave Page wrote: > > > On Thu, Mar 15, 2018 at 8:30 AM, Murtuza Zabuawala enterprisedb.com> wrote: > >> On Thu, Mar 15, 2018 at 4:53 PM, Dave Page wrote: >> >>> Hi >>> >>> On Thu, Mar 15, 2018 at 7:14 AM, Ashesh Vashi < >>> ashesh.va...@enterprisedb.co

pgAdmin 4 commit: Ensure the cookie domain and path are properly set. F

Ensure the cookie domain and path are properly set. Fixes #3197 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9c4edb4a28795a2ea0951581c3962bebe3ffed32 Author: Khushboo Vashi Modified Files -- web/pgadmin/__init__.py

Build failed in Jenkins: pgadmin4-master-python35 #532

See Changes: [Dave Page] Ensure the cookie domain and path are properly set. Fixes #3197 -- [...truncated 16.63 KB...] Running setup.py install for pyperclip:

Build failed in Jenkins: pgadmin4-master-python27 #533

See Changes: [Dave Page] Ensure the cookie domain and path are properly set. Fixes #3197 -- [...truncated 17.21 KB...] Running setup.py install for pycodestyl

Build failed in Jenkins: pgadmin4-master-python33 #531

See Changes: [Dave Page] Ensure the cookie domain and path are properly set. Fixes #3197 -- [...truncated 16.77 KB...] Running setup.py install for pyperclip:

Build failed in Jenkins: pgadmin4-master-python26 #659

See Changes: [Dave Page] Ensure the cookie domain and path are properly set. Fixes #3197 -- [...truncated 18.66 KB...] Running setup.py install for pyperclip:

pgAdmin 4 commit: Revert "Ensure the cookie domain and path are properl

Revert "Ensure the cookie domain and path are properly set. Fixes #3197" This reverts commit 9c4edb4a28795a2ea0951581c3962bebe3ffed32. Jenkins really doesn't like this. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=93d44d5643f36362cd6dff458

Build failed in Jenkins: pgadmin4-master-python34 #522

See Changes: [Dave Page] Ensure the cookie domain and path are properly set. Fixes #3197 -- [...truncated 16.63 KB...] Running setup.py install for pyperclip:

Build failed in Jenkins: pgadmin4-master-python36 #524

See Changes: [Dave Page] Ensure the cookie domain and path are properly set. Fixes #3197 -- [...truncated 16.63 KB...] Running setup.py install for pyperclip:

Jenkins build is back to normal : pgadmin4-master-python27 #534

See

Jenkins build is back to normal : pgadmin4-master-python35 #533

See

Jenkins build is back to normal : pgadmin4-master-python26 #660

See

Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn

On Thu, Mar 15, 2018 at 12:25 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > On Thu, Mar 15, 2018 at 9:42 PM, Dave Page wrote: > >> >> >> On Thu, Mar 15, 2018 at 8:30 AM, Murtuza Zabuawala < >> murtuza.zabuaw...@enterprisedb.com> wrote: >> >>> On Thu, Mar 15, 20

Jenkins build is back to normal : pgadmin4-master-python34 #523

See

Jenkins build is back to normal : pgadmin4-master-python36 #525

See

Re: [pgAdmin4][Patch]: RM #2963 - Backup database, Restore database and Maintenance Database failed for é object.

Hi On Thu, Mar 15, 2018 at 8:10 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Thu, Mar 15, 2018 at 3:13 AM, Dave Page wrote: > >> Hi >> >> On Tue, Mar 13, 2018 at 11:18 PM, Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> >>> >>> On Wed, Mar 14, 2018 at

Jenkins build is back to normal : pgadmin4-master-python33 #532

See

Re: [pgAdmin4][RM#3195] Include service name when executing Backup, Restore etc tools

Hey Murtuza, This patch passed our test pipelines and it looks good. Do we have any tests around this behavior? Joao and Victoria

Re: [pgAdmin4][RM#3195] Include service name when executing Backup, Restore etc tools

Thanks Joao and Victoria for reviewing. As Khushboo mentioned in her previous email we already have RM for the same( https://redmine.postgresql.org/issues/3206), We will send separate patch. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company