Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI

Hi Dave, As validation related patch was committed with RM#3148 [ Sorry about that I forgot to checkout :) ] PFA patch to fix the issues you mentioned, I have also removed extra error message from sub node collection control and made it optional via flag. -- Regards, Murtuza Zabuawala Enterpris

pgAdmin 4 commit: Case sensitive paths are confusing git...

Case sensitive paths are confusing git... Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7dbfd23797bf46bc27eb4d8a5a20ecc4165b9d57 Modified Files -- .gitignore | 1 + 1 file changed, 1 insertion(+)

Re: [pgadmin4][patch] Solves the bug #3150

Thanks, applied. On Mon, Feb 26, 2018 at 8:36 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi hackers, > Attached you can find the correct for the bug #3150. The functions SQL tab > stopped working after #3060, this patch changes the SQL to ensure that the > tab is working

pgAdmin 4 commit: Fix function reserve SQL for GPDB. Fixes #3150

Fix function reserve SQL for GPDB. Fixes #3150 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3be22383b81b05b8f5fb62173809e85faaac638b Author: Joao Pedro De Almeida Pereira Modified Files -- .../templates/function/gpdb/sql/defaul

pgAdmin 4 commit: Support tab navigation in dialogs. Fixes #2898

Support tab navigation in dialogs. Fixes #2898 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=aa1849c13af7f7188c4ed0936eb22796b56a3998 Author: Harshal Dhumal Modified Files -- docs/en_US/keyboard_shortcuts.rst |

Re: RM2898 Keyboard navigation in dialog tabs (nav tabs)

Cool - that works. Patch applied. Thanks! On Tue, Feb 27, 2018 at 6:30 AM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > On Tue, Feb 27, 2018 at 1:08 AM, Dave Page wrote: > >> Hi, >> >> I'm still able to make it get stuck, if I tab back and forth quickly. >> > Quickly switc

Re: PEP-8 fixes

Thanks, applied! On Tue, Feb 27, 2018 at 7:19 AM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > Please find patch to fix pep-8 issues for given modules. > > 1. server group (__init__.py) > 2. server (__init__.py, gpdb.py, types.py, utils.py) > > > -- > *Harshal Dhumal* > *Sr.

pgAdmin 4 commit: PEP8 fixes for the server and server group modules.

PEP8 fixes for the server and server group modules. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=055f7abc9ed0f3b547cf1a93fac84ff3abdd14e1 Author: Harshal Dhumal Modified Files -- web/pgadmin/browser/server_groups/__init__.py

Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI

Hi Still not quite right - see the attached screenshot which is the result of simply viewing the properties of an existing job. Note that the start time is shown in the grid but not the subnode control. Thanks. On Tue, Feb 27, 2018 at 8:26 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.c

Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI

Hi Dave, Could you please send screenshot? -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, Feb 27, 2018 at 5:24 PM, Dave Page wrote: > Hi > > Still not quite right - see the attached screenshot which is the result of > simply v

Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI

I'm not able to re-produce the issue, Could you hard refresh and try again? If possible could you please provide exact steps? -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, Feb 27, 2018 at 5:30 PM, Dave Page wrote: > Sorry - h

[pgAdmin4][RM#3002] To fix the indentation issue in query tool editor

Hi, PFA patch to fix the issue where Tab key was not working as expected in query tool editor. Steps to reproduce: 1) Type any multiline sql/text. 2) select the complete sql by pressing Ctrl+A. 3) Press Tab key multiple times, you will see the problem in code indentation. Please review. -- Rega

pgAdmin 4 commit: Add keyboard shortcuts for the Query Tool. Fixes #290

Add keyboard shortcuts for the Query Tool. Fixes #2900 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a9de043fef964586858acb7070cbbebf2601b340 Author: Murtuza Zabuawala Modified Files -- .../images/preferences_sql_keyboard_shortc

Re: [pgAdmin4][RM#2900] Adding accessibility features in query tool

Thanks guys - patch applied. On Mon, Feb 26, 2018 at 5:31 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Thank you Joao for reviewing. > > On Mon, Feb 26, 2018 at 10:43 PM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hello Murtuza, >> We just passed

RM3079 fix for wrong sql datetime/time related datatypes

Hi, Please find patch to fix wrong sql issue for time related type. Steps to reproduce: Alter any time/datetime array related data type, it generates sql with addition array bracket [image: Inline image 1] -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterpri

Re: [pgAdmin4][RM#3002] To fix the indentation issue in query tool editor

Hello Murtuza, The patch looks good, and solves the problem. Run the patch on our CI and everything is green. Thanks Joao On Tue, Feb 27, 2018 at 8:11 AM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to fix the issue where Tab key was not working as expected

Re: [pgAdmin4][RM#3002] To fix the indentation issue in query tool editor

Thank you for testing it Joao. -- Regards, Murtuza On Tue, Feb 27, 2018 at 8:29 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Murtuza, > > The patch looks good, and solves the problem. Run the patch on our CI and > everything is green. > > Thanks > Joao > > On Tue, F

[pgAdmin4][RM#3156] Fix PEP-8 issues

Hi, PFA patch to fix the PEP-8 issues in Resource group, Roles & Tablespaces pycodestyle --config=.pycodestyle pgadmin/browser/server_groups/servers/tablespaces/ pycodestyle --config=.pycodestyle pgadmin/browser/server_groups/servers/roles/ pycodestyle --config=.pycodestyle pgadmin/browser/server

Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI

Hi On Tue, Feb 27, 2018 at 12:03 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > I'm not able to re-produce the issue, Could you hard refresh and try again? > I still see it. > > If possible could you please provide exact steps? > Attached is a dump of my test pgagent sch

Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI

​Thanks Dave, I'll look into it. ​ On Tue, Feb 27, 2018 at 8:37 PM, Dave Page wrote: > Hi > > On Tue, Feb 27, 2018 at 12:03 PM, Murtuza Zabuawala enterprisedb.com> wrote: > >> I'm not able to re-produce the issue, Could you hard refresh and try >> again? >> > > I still see it. > > >> >> If pos

pgAdmin 4 commit: Fix block indent/outdent with configurable width. Fix

Fix block indent/outdent with configurable width. Fixes #3002 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f5afd5fdb4883011a1a1c0510823f43e98264b23 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/browser/static/js/brows

Re: [pgAdmin4][RM#3002] To fix the indentation issue in query tool editor

Thanks, patch applied. On Tue, Feb 27, 2018 at 3:00 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Thank you for testing it Joao. > > -- > Regards, > Murtuza > > On Tue, Feb 27, 2018 at 8:29 PM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hello Murt

Re: RM3079 fix for wrong sql datetime/time related datatypes

Hi On Tue, Feb 27, 2018 at 2:36 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > Please find patch to fix wrong sql issue for time related type. > > Steps to reproduce: > > Alter any time/datetime array related data type, it generates sql with > addition array bracket > > [i

pgAdmin 4 commit: PEP8 fixes. Fixes #3156

PEP8 fixes. Fixes #3156 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=cca6504d54e2cac81c6be0d1e43138fa5c7e98a8 Author: Murtuza Zabuawala Modified Files -- .../servers/resource_groups/__init__.py| 196 ++--

Re: [pgAdmin4][RM#3156] Fix PEP-8 issues

Thanks, applied. On Tue, Feb 27, 2018 at 3:02 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to fix the PEP-8 issues in Resource group, Roles & Tablespaces > > pycodestyle --config=.pycodestyle pgadmin/browser/server_groups/ > servers/tablespaces/ > pycodes

Re: [pgAdmin4][Patch]: PEP-8 issue fixes

On Mon, Feb 26, 2018 at 9:19 PM, Dave Page wrote: > Can you rebase this please? It doesn't apply against master. > > Please find the updated patch excluding utils module as it is already done. > On Mon, Feb 26, 2018 at 12:04 PM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi,