pgAdmin 4 commit: Attempt to ensure the runtime is built with the corre

Attempt to ensure the runtime is built with the correct Python version. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8148a61279d453eb78209105275295364430a241 Modified Files -- ci/build_runtime_qt4.sh | 8 +++- ci/build_runtim

Build failed in Jenkins: pgadmin4-master-python35 #485

See Changes: [Dave Page] Attempt to ensure the runtime is built with the correct Python version. -- [...truncated 494.78 KB...] copying images... [ 27%] images/r

pgAdmin 4 commit: Fix silly typo

Fix silly typo Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3021060a32be8b7ff67ccce337e05aeeff6407b4 Modified Files -- ci/build_runtime_qt4.sh | 2 +- ci/build_runtime_qt5.sh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-

Jenkins build is back to normal : pgadmin4-master-python35 #486

See

RM2983: Fix transient error after application restart

Hi, Please find patch to fix specified_version_number ValueError issue. Now we try to restore server details like server version number and version string from flask session in-case if there was a application restart. -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.e

pgAdmin 4 commit: Ensure column names on indexes on views are properly

Ensure column names on indexes on views are properly quoted in RE-SQL. Fixes #3066 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9a498c2877521d7f49fbaf878678fe6306ae1597 Author: Khushboo Vashi Modified Files -- .../browser/serv

Re: [pgAdmin4][Patch]: RM #3066 - Create script doesn't add quotation marks to column names for the "add index" functions

Thanks, applied. On Mon, Feb 19, 2018 at 1:27 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Mon, Feb 19, 2018 at 5:19 PM, Dave Page wrote: > >> Hi >> >> On Mon, Feb 19, 2018 at 7:56 AM, Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> Hi, >>> >>> Please

pgAdmin 4 commit: Fix alignment issues in keyboard shortcut options. Fi

Fix alignment issues in keyboard shortcut options. Fixes #3080 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c91a597df9deb0a6017c175305c1cb2f462bfa00 Author: Harshal Dhumal Modified Files -- web/pgadmin/browser/__init__.py

Re: [pgadmin4][patch] Hides the tablespace node in ACI tree for GreenPlum

Hello Dave, No there is only tests around the the backendsupport function Thanks Joao On Mon, Feb 19, 2018 at 6:08 AM Dave Page wrote: > Hi > > On Mon, Feb 12, 2018 at 6:30 PM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hi Hackers >> >> The attached patch implements t

Re: RM3080 Fix for alignment issue in keyboard preferences

Thanks, patch applied. On Tue, Feb 20, 2018 at 6:16 AM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > Please find attached patch to fix alignment issue in keyboard preferences. > > -- > *Harshal Dhumal* > *Sr. Software Engineer* > > EnterpriseDB India: http://www.enterprisedb

Re: RM2898 Keyboard navigation in dialog tabs (nav tabs)

Hi On Tue, Feb 20, 2018 at 7:22 AM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > Please find attached patch to enable keyboard navigation in dialog. > > To allow navigation from one tab pane (bootstrap tab pane) to another one > I have added two new shortcut preferences *Dia

Re: [pgadmin4][patch] Hides the tablespace node in ACI tree for GreenPlum

Hi On Tue, Feb 20, 2018 at 4:51 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Dave, > No there is only tests around the the backendsupport function > Let me rephrase :-). What's this part of the patch for? --- a/web/pgadmin/feature_tests/keyboard_shortcut_test.py ++

Re: [pgadmin4][patch] Hides the tablespace node in ACI tree for GreenPlum

Hello, It is to make it clear which shortcut test is failing, something similar to the query tool tests. If you want I can separate those in 2 separate patches Thanks Joao On Tue, Feb 20, 2018 at 12:05 PM Dave Page wrote: > Hi > > On Tue, Feb 20, 2018 at 4:51 PM, Joao De Almeida Pereira < > jd

pgAdmin 4 commit: Fix intermittent specified_version_number ValueError

Fix intermittent specified_version_number ValueError issue on restart. Fixes #2983 Now we try to restore server details like server version number at restart so template paths can be resolved. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=

Re: RM2983: Fix transient error after application restart

Thanks, patch applied. On Tue, Feb 20, 2018 at 12:30 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > Please find patch to fix specified_version_number ValueError issue. > > Now we try to restore server details like server version number and > version string > from flask ses

pgAdmin 4 commit: Clarify which shortcut is being tested in the shortcu

Clarify which shortcut is being tested in the shortcut test. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bcb6f37d6f8e6aed4e433d1efb3d76efd14aee31 Author: Joao Pedro De Almeida Pereira Modified Files -- web/pgadmin/feature_test

pgAdmin 4 commit: Hide tablespace node on GPDB. Fixes #3107

Hide tablespace node on GPDB. Fixes #3107 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ba70634e5f4bcd952facf68c0f4d39a651867c67 Author: Joao Pedro De Almeida Pereira Modified Files -- .../server_groups/servers/tablespaces/__ini

Re: [pgadmin4][patch] Hides the tablespace node in ACI tree for GreenPlum

Hi On Tue, Feb 20, 2018 at 5:16 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello, > It is to make it clear which shortcut test is failing, something similar > to the query tool tests. > Ah. > > If you want I can separate those in 2 separate patches > No need - I comm

Regarding PEP-8 checker

Hi All, Earlier we have fixed PEP-8 issues in below modules, pycodestyle --config=.pycodestyle ./pgadmin/tools/ pycodestyle --config=.pycodestyle ./pgadmin/utils/ pycodestyle --config=.pycodestyle ./pgadmin/misc/ pycodestyle --config=.pycodestyle ./pgadmin/about/ pycodestyle --config=.pycodestyle

[pgAdmin4][Patch]: RM #3077 - ERROR: invalid byte sequence for encoding "LATIN1":0x00

Hi, Please find the attached patch to fix RM #3077 : ERROR: invalid byte sequence for encoding "LATIN1":0x00 Thanks, Khushboo diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/templates/trigger/sql/10_plus/properties.sql b/web/pgadmin/browser/server_groups/servers/da