Re: pgAdmin 4 commit: Don't quote variable values used by SET. It's usually

2018-02-05 Thread Dave Page
On Mon, Feb 5, 2018 at 2:26 AM, Ashesh Vashi wrote: > On Mon, Feb 5, 2018 at 1:35 AM, Dave Page wrote: > >> Hi >> >> On 4 Feb 2018, at 18:07, Ashesh Vashi >> wrote: >> >> Hi Dave, >> >> There is a possibility of SQL Injection (if we don't use qtLiteral. >> We need some kind of check for this. >

Re: [pgAdmin4][RM#3082] Fix PEP-8 issues

2018-02-05 Thread Dave Page
Hi On Fri, Feb 2, 2018 at 5:46 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to fix PEP-8 issues in feature_tests, dashboard, about and misc > module's python code. > > To verify the changes, > 1) activate virtual environemt > 2) Navigate to ../web directo

pgAdmin 4 commit: Rewrite the runtime as a tray-based server which can

2018-02-05 Thread Dave Page
Rewrite the runtime as a tray-based server which can launch a web browser. Fixes #3086 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7192a2b67502b2afbad9e88cd3fc4618e7e64da1 Modified Files -- .gitignore|

Build failed in Jenkins: pgadmin4-master-python27-feature #13

2018-02-05 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Fix layout of password prompt dialogue. Fixes #2684 [Dave Page] Fix quoting of index column names on tables. Fixes #2619 [Dave Page] Initial draft of the 2.0 release not

pgAdmin 4 commit: Bump the version to 3.0, per discussion on the mailin

2018-02-05 Thread Dave Page
Bump the version to 3.0, per discussion on the mailing lists Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2706d9cd8e6f98cf543e4e86afe881b8f4b571d3 Modified Files -- runtime/Info.plist | 4 ++-- web/config.py | 8 2 f

pgAdmin 4 commit: Branch refs/heads/runtime-revamp was removed

2018-02-05 Thread git
Branch refs/heads/runtime-revamp was removed.

suggestion: discard python2.x venv

2018-02-05 Thread Ioseph Kim
Hi, I used pgadmin4 since 2 month. pgadmin4 is a good application for PostgreSQL. that is true! but, in multibytes environment, python2 + pgadmin4 is not good choice. if table name or column name is multibytes, export, import is not working, becauseĀ  python2 unicode processing is ugly. and

Re: suggestion: discard python2.x venv

2018-02-05 Thread Khushboo Vashi
Hi Loseph, On Tue, Feb 6, 2018 at 9:21 AM, Ioseph Kim wrote: > Hi, > > I used pgadmin4 since 2 month. > > pgadmin4 is a good application for PostgreSQL. that is true! > > but, in multibytes environment, python2 + pgadmin4 is not good choice. > > > if table name or column name is multibytes, exp

Re: suggestion: discard python2.x venv

2018-02-05 Thread Murtuza Zabuawala
On Tue, Feb 6, 2018 at 9:21 AM, Ioseph Kim wrote: > Hi, > > I used pgadmin4 since 2 month. > > pgadmin4 is a good application for PostgreSQL. that is true! > > but, in multibytes environment, python2 + pgadmin4 is not good choice. > > > if table name or column name is multibytes, export, import i

Re: suggestion: discard python2.x venv

2018-02-05 Thread Ioseph Kim
Yes, I agree yours. thinking that, many pgadmin4 is used on windows, or mac, pgadmin4 for windows installer is including python2.7. so many users use the python2 environment, with no choice. if python3 is used on windows distribution (builtin python3), this will is good choice. Regards, i